New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792865 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : 'Next' button is seen disabled even Wi-Fi is connected and Dongle connection is in 'initialization..'

Project Member Reported by mmanchala@chromium.org, Dec 7 2017

Issue description

Chrome Version:  63.0.3239.85/10032.68.0 beta Candy,Reks and Daisy
OS: Chrome

What steps will reproduce the problem?
(1)Recover build -> Go to 'Connect to network' screen (OOBE screen)-> insert Mobile Dongle(it get initialized i.e. Mobile data with initializing... is seen) and now connect to Wi-Fi network
(2)Wi-Fi gets 'Connected' and Mobile data is still in 'initialization..'  state ->Now observe 'Next' button is seen disabled  even Wi-Fi is connected(Please refer Video and screenshot)

Expected: Next' button should be enabled after 'Wi-Fi' gets connected even  Dongle connection is in 'initialization..'  state
Actual:  Next' button is seen disabled  even Wi-Fi is connected

This is Regression Issue as same is working fine in 62.0.3202.97/9901.77.0 stable-channel Reks

@alemate :  Please confirm the issue
 
Actual_NextButtonISSeenDisabledEvenWi_FIISConnected.mp4
16.6 MB Download
Actual_NextButtonISSeenDisabledEvenWi_FIISConnected.jpg
601 KB View Download
Note : Issue is seen on latest M-65 also

Attaching Expected video and Screenshot for reference
Expected_NextButtonIsEnabledAfterWi-FiGetsConnected.mp4
15.3 MB Download
Expected_NextButtonIsEnabledAfterWi-FiGetsConnected.jpg
547 KB View Download
Could you check this again? There were several fixes landed to M65, I think this should be fixed by now.
C#2>

Issue is still seen on latest M-66 66.0.3341.0/10382.0.0 dev-channel Peppy device.
Attaching video for reference.

Thanks..!!
On66.0.3341.0Build.mp4
11.2 MB View Download
I cannot reproduce this.
Even when my dongle is "connecting", whenever I click on WiFi network, I get automatic transition to the next page (because my new WiFi network is connected".


Could you attach the full video? (Starting with device reboot, attaching dongle, etc...)
FWIW, I just noticed that the 'next' button *appears* to be disabled but actually works, so that may be all this bug is? (We should still fix that, but that would make this a P2).

Comment 6 Deleted

I was able to reproduce it. Here is the full video:

https://drive.google.com/file/d/1UtpblyuCeJ4UeCT81_DKP3eAuHAEXl7r/view?usp=sharing

We usually unblock "Next" button when any network is connected.
We automatically advance to the next screen when "selected (i.e. last clicked) network is connected.

On the video you can see that mobile network got connected before WiFi. But until WiFi network finished its connection, "Next" button was still grey.

Any update on this?

This is marked as release block stable for 65, so we need a fix in the next couple weeks.
Cc: zalcorn@chromium.org
Labels: -M-65 M-66
+zalcorn

It is actually by design, because we consider Cellular network to have to ppriority, so it becomes default network even if not connected. And we have to wait for its initialization before being able to change it.

Moving this to M66, as it only affects users who probably still want to use cellular network (and thus manually connected cellular dongle), but then changed their mind while waiting for cellular dongle to initialize.
Status: Started (was: Assigned)
We do not generally consider Cellular to have "priority" over WiFi. We do list Cellular above unconnected WiFi networks so that it does not get lost at the bottom of the list, but it doesn't actually have connection priority.

I think that we should simplify the logic for this page as follows:
a) 'Next' is enabled when any network is connected.
b) Auto-advance occurs when a network is clicked on by the user and it is either already connected, or it finishes connecting.

zalcorn@ / alemate@ - Does that sound reasonable? I am happy to take this over, I think there is a pretty simple way to fix the current logic.

Steven that sounds good except for that I'm not sure what you mean by "or it finishes connecting" - would this auto-advance happen asynchronously from a mouse-click?
Kind of yes. Let me clarify:

a) 'Next' is enabled when any network is connected.
b) Auto-advance occurs when:
b1) A connected network is clicked by the user.
b2) A non connected network is clicked by the user and that network becomes connected.

a) is not true if the first network in the list is not conencted (bug)
b1) & b2) are, I believe, the current behavior.

Gotcha, that all makes sense to me, I'm on board.
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c023b9192c4456cd1d96ce9dddbcd5a876b5551

commit 3c023b9192c4456cd1d96ce9dddbcd5a876b5551
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Mar 08 23:48:16 2018

Network config: cr-network-select: Ensure connected network is default

Bug:  792865 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I403b8d512bb6d7c8d0e4c6947a8704544ef0f27a
Reviewed-on: https://chromium-review.googlesource.com/956312
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541940}
[modify] https://crrev.com/3c023b9192c4456cd1d96ce9dddbcd5a876b5551/ui/webui/resources/cr_elements/chromeos/network/cr_network_select.js

Cc: alemate@chromium.org
Labels: -Pri-1 -ReleaseBlock-Stable -M-66 M-67 Pri-2
Owner: steve...@chromium.org
Status: Fixed (was: Started)
Removing P1 and RBS from this. This is an edge case (Cellular dongle) with a workaround (next button appears disabled but works, clicking on connected network also advances the screen).

Sign in to add a comment