New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792863 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

RenderFrameHostImplBrowserTest failing on chromium.android/Marshmallow 64 bit Tester

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 7 2017

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of perezju@google.com

renderer_side_navigation_content_browsertests failing on chromium.android/Marshmallow 64 bit Tester

Builders failed on: 
- Marshmallow 64 bit Tester: 
  https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester

Failing test:
  RenderFrameHostImplBrowserTest.EarlyInterfaceRequestsFromNewDocumentDispatchedAfterNavigationFinished
 
has failed on all builds:

https://ci.chromium.org/buildbot/chromium.android/Marshmallow%2064%20bit%20Tester/17943
https://ci.chromium.org/buildbot/chromium.android/Marshmallow%2064%20bit%20Tester/17942
https://ci.chromium.org/buildbot/chromium.android/Marshmallow%2064%20bit%20Tester/17937
https://ci.chromium.org/buildbot/chromium.android/Marshmallow%2064%20bit%20Tester/17935

The log of the test shows:

[ RUN      ] RenderFrameHostImplBrowserTest.EarlyInterfaceRequestsFromNewDocumentDispatchedAfterNavigationFinished
[WARNING:dns_config_service_posix.cc(341)] Failed to read DnsConfig.
[ERROR:devtools_http_handler.cc(249)] Cannot start http server for devtools. Stop devtools.
[ERROR:instance.cc(49)] Unable to locate service manifest for metrics
[ERROR:service_manager.cc(890)] Failed to resolve service name: metrics
[WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file assets/snapshot_blob_32.bin
[ERROR:instance.cc(49)] Unable to locate service manifest for metrics
[ERROR:service_manager.cc(890)] Failed to resolve service name: metrics
[WARNING:simple_synchronous_entry.cc(1170)] Could not open platform files for entry.
[ERROR:shell_android.cc(72)] Not implemented reached in void content::Shell::PlatformSetTitle(const base::string16 &): Title Of Awesomeness
referenceTable head length=54 1
../../content/browser/frame_host/render_frame_host_impl_browsertest.cc:1058: Failure
Actual function call count doesn't match EXPECT_CALL(dispatched_interface_request_callback, Run())...
         Expected: to be called once
           Actual: never called - unsatisfied and active
[  FAILED  ] RenderFrameHostImplBrowserTest.EarlyInterfaceRequestsFromNewDocumentDispatchedAfterNavigationFinished, where TypeParam =  and GetParam() =  (565 ms)
[----------] 1 test from RenderFrameHostImplBrowserTest (566 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (567 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] RenderFrameHostImplBrowserTest.EarlyInterfaceRequestsFromNewDocumentDispatchedAfterNavigationFinished, where TypeParam =  and GetParam() = 

 1 FAILED TEST
<<ScopedMainEntryLogger
[INFO:test_support_android.cc(185)] MessagePumpForUIFactory already set, unable to override.
>>ScopedMainEntryLogger
Note: Google Test filter = RenderFrameHostImplBrowserTest.GetVisibilityState_Basic
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from RenderFrameHostImplBrowserTest, where TypeParam = 

Cc: roc...@chromium.org maxmorin@chromium.org jbroman@chromium.org dcheng@chromium.org chcunningham@chromium.org nasko@chromium.org
Owner: engedy@chromium.org
Status: Assigned (was: Available)
It looks like the test got recently added at r522198. +engedy, can you have a look?

cc'ing reviewers too
Cc: -perezju@google.com
Cc: perezju@chromium.org
Status: Started (was: Assigned)
Yeah, the test should wait a bit longer, I'll prepare a fix. Do you want me to disable the test or revert the CL in the meantime?
This is only flakying a bit. If the fix doesn't take too long, I guess it's fine to wait. Otherwise please disable the test.
Fix is in the CQ.
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68815a3f56acd21576ce2a4bef51cd35c9ee6a02

commit 68815a3f56acd21576ce2a4bef51cd35c9ee6a02
Author: Balazs Engedy <engedy@chromium.org>
Date: Thu Dec 07 15:26:01 2017

Do not assume interface dispatch before DidStopLoading.

EarlyInterfaceRequestsFromNewDocumentDispatchedAfterNavigationFinished
in RenderFrameHostImplBrowserTest previously assumed that an interface
request issued right away by the newly committed document will be
necessarily dispatched before DidStopLoading.

This is incorrect: tiny testing documents with no subresources to load
might stop loading and send FrameHostMsg_DidStopLoading shortly after
the load committed, so RenderFrameHostImpl::OnDidStopLoading might end
up being invoked before RemderFrameHostImpl::GetInterface is.

TBR=nasko@chromium.org

Bug:  792863 , 729021
Change-Id: I6a631e7e996480fcfd148a54faa8a977386d9e03
Reviewed-on: https://chromium-review.googlesource.com/814096
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522431}
[modify] https://crrev.com/68815a3f56acd21576ce2a4bef51cd35c9ee6a02/content/browser/frame_host/render_frame_host_impl_browsertest.cc

Status: Verified (was: Started)
Didn't see a flake in the past 5 builds.

Sign in to add a comment