RenderFrameHostImplBrowserTest failing on chromium.android/Marshmallow 64 bit Tester |
||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of perezju@google.com renderer_side_navigation_content_browsertests failing on chromium.android/Marshmallow 64 bit Tester Builders failed on: - Marshmallow 64 bit Tester: https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester Failing test: RenderFrameHostImplBrowserTest.EarlyInterfaceRequestsFromNewDocumentDispatchedAfterNavigationFinished
,
Dec 7 2017
It looks like the test got recently added at r522198. +engedy, can you have a look? cc'ing reviewers too
,
Dec 7 2017
,
Dec 7 2017
,
Dec 7 2017
Yeah, the test should wait a bit longer, I'll prepare a fix. Do you want me to disable the test or revert the CL in the meantime?
,
Dec 7 2017
This is only flakying a bit. If the fix doesn't take too long, I guess it's fine to wait. Otherwise please disable the test.
,
Dec 7 2017
Fix is in the CQ.
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68815a3f56acd21576ce2a4bef51cd35c9ee6a02 commit 68815a3f56acd21576ce2a4bef51cd35c9ee6a02 Author: Balazs Engedy <engedy@chromium.org> Date: Thu Dec 07 15:26:01 2017 Do not assume interface dispatch before DidStopLoading. EarlyInterfaceRequestsFromNewDocumentDispatchedAfterNavigationFinished in RenderFrameHostImplBrowserTest previously assumed that an interface request issued right away by the newly committed document will be necessarily dispatched before DidStopLoading. This is incorrect: tiny testing documents with no subresources to load might stop loading and send FrameHostMsg_DidStopLoading shortly after the load committed, so RenderFrameHostImpl::OnDidStopLoading might end up being invoked before RemderFrameHostImpl::GetInterface is. TBR=nasko@chromium.org Bug: 792863 , 729021 Change-Id: I6a631e7e996480fcfd148a54faa8a977386d9e03 Reviewed-on: https://chromium-review.googlesource.com/814096 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#522431} [modify] https://crrev.com/68815a3f56acd21576ce2a4bef51cd35c9ee6a02/content/browser/frame_host/render_frame_host_impl_browsertest.cc
,
Dec 7 2017
Didn't see a flake in the past 5 builds. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by perezju@chromium.org
, Dec 7 2017