New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792850 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Local NTP: Two text carets are seen at the same time

Reported by avsha...@etouch.net, Dec 7 2017

Issue description

Chrome version : 64.0.3282.14 (Official Build) a6760eb77179ae79c288db9eaa47f8468f1ff7fb-refs/branch-heads/3282@{#67} 64 bit
OS : Mac(10.12.6)(10.13.2), Windows(7,8,10), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, enable #use-google-local-ntp flag from chrome://flags page and restart the browser.
2. Open NTP, click inside ‘Search box’ and hit spacebar key twice.
3. Press ‘Cmd + R’ keys to reload the NTP and observe text caret inside omnibox and ‘Search box’.

Actual Result : Two text caret are seen at the same time in NTP ‘Search box’ and omnibox.

Expected Result : Instead, only one text caret should appear at a time.

This is a non-regression issue seen from ‘M-60’ series, since the #use-google-local-ntp flag has been introduced in build #60.0.3097.0
 
Actual_Result.mov
4.8 MB Download
Update: 
Tested above issue on 64.0.3282.15(PGO) build and issue is reproducible.
Labels: -M-64 M-65
Status: Untriaged (was: Unconfirmed)
Changing the status to Untriaged, so that the issue would get addressed.
Thank You.

Comment 3 by treib@chromium.org, Dec 7 2017

Labels: OS-Chrome
Owner: treib@chromium.org
Status: Assigned (was: Untriaged)
Summary: Local NTP: Two text carets are seen at the same time (was: Two text caret are seen at the same time on NTP.)

Comment 4 by mastiz@chromium.org, Dec 12 2017

Labels: zine-triaged

Comment 5 by treib@chromium.org, Dec 14 2017

Status: Started (was: Assigned)
This happens not only when typing spaces, also with any other text + reload. Fix incoming.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8df992adae518b4641f79b644c275d554be0f395

commit 8df992adae518b4641f79b644c275d554be0f395
Author: Marc Treib <treib@chromium.org>
Date: Thu Dec 14 16:33:38 2017

Local NTP: Tell the browser if we start with keycapture enabled

This fixes a problem where both Omnibox and fakebox could have visible
focus at the same time.

Bug:  792850 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id4801641c1ee192ffef943ecb738abf41fecc348
Reviewed-on: https://chromium-review.googlesource.com/827076
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524082}
[modify] https://crrev.com/8df992adae518b4641f79b644c275d554be0f395/chrome/browser/resources/local_ntp/local_ntp.js

Comment 7 by treib@chromium.org, Dec 14 2017

Status: Fixed (was: Started)

Comment 8 by avsha...@etouch.net, Dec 15 2017

Labels: TE-Verified-M65 TE-Verified-65.0.3295.0
Update : 
Retested above issue on Mac(10.12.6, 10.13.2), Windows(7,8,10) and Linux(14.04 LTS) OS using latest Canary #65.0.3295.0 and issue is fixed. Now, only one text caret is observed on local NTP after reloading. Kindly review an attached screen cast.

Thank you!
Canary_behaviour.mov
4.0 MB Download

Sign in to add a comment