Issue metadata
Sign in to add a comment
|
Regression : ‘Profile chooser’ dialog stays open even after closing the current tab.
Reported by
avsha...@etouch.net,
Dec 7 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version : 64.0.3282.14 (Official Build) a6760eb77179ae79c288db9eaa47f8468f1ff7fb-refs/branch-heads/3282@{#67} 64-bit OS : Mac(10.12.6) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://version page and press ‘Cmd + T’ keys to open another NTP. 2. On NTP, click on Avatar icon (Profile chooser dialog appears) and middle click on current NTP to close the tab. 3. Observe the ‘Profile chooser’ dialog. (Kindly review an attached screen cast) Actual Result : ‘Profile chooser’ dialog stays open even after closing the current tab (through middle mouse click). Expected Result : ‘Profile chooser’ dialog should get closed after closing the current tab through middle click. This is a regression issue broken in ‘M-64’ and using the per-revision bisect providing the bisect results, Good build : 64.0.3264.0 (Revision : 515410) Bad build : 64.0.3265.0 (Revision : 515780) You are probably looking for a change made after 515522 (known good), but no later than 515523 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/a63b2ddd636c62a3fe3f5e46c6c951e9fce23993..ff683d4c68b0505229fe56d1bd34e371f1758124 Suspect : https://chromium.googlesource.com/chromium/src/+/ff683d4c68b0505229fe56d1bd34e371f1758124 @jlebel : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note : 1. Need to use external mouse in order to perform middle mouse click operation. 2. Issue is not observed on Mac Touch bar(10.13.2), Windows(7,8,10) & Linux(14.04 LTS).
,
Dec 7 2017
Eli:
,
Dec 13 2017
Still we are able to reproduce the issue on latest Canary-65.0.3292.0 on Mac 10.12.6 as per C#0. ‘Profile chooser’ dialog stays open even after closing the current tab (through middle mouse click). msarda@,Could you please take a look and update the thread accordingly as it is marked as stable blocker. Thanks..!
,
Dec 13 2017
Should have a CL to fix this bug this week.
,
Dec 14 2017
,
Dec 19 2017
Friendly ping to get an update on this issue. Thanks..!
,
Dec 19 2017
CL to fix this was ready for a while - see https://chromium-review.googlesource.com/c/chromium/src/+/824044 However, it looks like the new browser test fails only on the release bots (I cannot reproduce it locally though). I'm trying to debug the test now.
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d785ab2390c30136889ae77fe4fa540694a741e commit 9d785ab2390c30136889ae77fe4fa540694a741e Author: Mihai Sardarescu <msarda@chromium.org> Date: Tue Dec 19 17:36:10 2017 [signin] Close the user menu when the active tab changes. On macOS, all bubble views (including the user menu) are closed every time the user adds, closes or changes the active tab using keyboard accelerators. To achieve this, the BaseBubbleController closes all UI inheriting from it by observing active tab changes from its TabStripModelObserverBridge. This CL keeps the same behaviour for the user menu bubble for its MacViews implementation. The implementation is cross-platform, however on Windows and Linux the user cannot use the keyboard shortcuts to change the current tab when the user menu bubble is visible. This CL also enables the browser tests for the user menu on macOS. Bug: 792845 Change-Id: Ide932ed1795e21a2f2e2646f9c24062c6fbf0391 Reviewed-on: https://chromium-review.googlesource.com/824044 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#525070} [modify] https://crrev.com/9d785ab2390c30136889ae77fe4fa540694a741e/chrome/browser/ui/BUILD.gn [add] https://crrev.com/9d785ab2390c30136889ae77fe4fa540694a741e/chrome/browser/ui/views/close_bubble_on_tab_activation_helper.cc [add] https://crrev.com/9d785ab2390c30136889ae77fe4fa540694a741e/chrome/browser/ui/views/close_bubble_on_tab_activation_helper.h [modify] https://crrev.com/9d785ab2390c30136889ae77fe4fa540694a741e/chrome/browser/ui/views/profiles/profile_chooser_view.cc [modify] https://crrev.com/9d785ab2390c30136889ae77fe4fa540694a741e/chrome/browser/ui/views/profiles/profile_chooser_view.h [modify] https://crrev.com/9d785ab2390c30136889ae77fe4fa540694a741e/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc [modify] https://crrev.com/9d785ab2390c30136889ae77fe4fa540694a741e/chrome/test/BUILD.gn
,
Dec 19 2017
,
Dec 19 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.
,
Dec 21 2017
Verified on Canary.
,
Dec 21 2017
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 21 2017
Approving merge for M64. Branch:3282
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75bd163560775d256cb674917a397c7e570d69eb commit 75bd163560775d256cb674917a397c7e570d69eb Author: Mihai Sardarescu <msarda@chromium.org> Date: Fri Dec 22 10:01:52 2017 [signin] Close the user menu when the active tab changes. On macOS, all bubble views (including the user menu) are closed every time the user adds, closes or changes the active tab using keyboard accelerators. To achieve this, the BaseBubbleController closes all UI inheriting from it by observing active tab changes from its TabStripModelObserverBridge. This CL keeps the same behaviour for the user menu bubble for its MacViews implementation. The implementation is cross-platform, however on Windows and Linux the user cannot use the keyboard shortcuts to change the current tab when the user menu bubble is visible. This CL also enables the browser tests for the user menu on macOS. TBR=msarda@chromium.org (cherry picked from commit 9d785ab2390c30136889ae77fe4fa540694a741e) Bug: 792845 Change-Id: Ide932ed1795e21a2f2e2646f9c24062c6fbf0391 Reviewed-on: https://chromium-review.googlesource.com/824044 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#525070} Reviewed-on: https://chromium-review.googlesource.com/842644 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#340} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/75bd163560775d256cb674917a397c7e570d69eb/chrome/browser/ui/BUILD.gn [add] https://crrev.com/75bd163560775d256cb674917a397c7e570d69eb/chrome/browser/ui/views/close_bubble_on_tab_activation_helper.cc [add] https://crrev.com/75bd163560775d256cb674917a397c7e570d69eb/chrome/browser/ui/views/close_bubble_on_tab_activation_helper.h [modify] https://crrev.com/75bd163560775d256cb674917a397c7e570d69eb/chrome/browser/ui/views/profiles/profile_chooser_view.cc [modify] https://crrev.com/75bd163560775d256cb674917a397c7e570d69eb/chrome/browser/ui/views/profiles/profile_chooser_view.h [modify] https://crrev.com/75bd163560775d256cb674917a397c7e570d69eb/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc [modify] https://crrev.com/75bd163560775d256cb674917a397c7e570d69eb/chrome/test/BUILD.gn |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jlebel@chromium.org
, Dec 7 2017