New issue
Advanced search Search tips

Issue 792840 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocked on:
issue 819980



Sign in to add a comment

Code cleanup on iOS after enabling passwords export

Project Member Reported by ioanap@chromium.org, Dec 7 2017

Issue description

Clean code on iOS after the export passwords feature is enabled.

 
Blockedon: 819980
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afdfb291c7484c71125fe6bd773eb143e1428028

commit afdfb291c7484c71125fe6bd773eb143e1428028
Author: Ioana Pandele <ioanap@chromium.org>
Date: Thu Sep 06 16:07:37 2018

Remove password export feature flag

This feature has been enabled for the past few stable releases, so the
flag is not needed anymore.

Bug:  838789 , 792840
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib79921d30792dbd8e03fd2ec7652c15a76e84b73
Reviewed-on: https://chromium-review.googlesource.com/1203956
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589182}
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/components/password_manager/core/common/password_manager_features.cc
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/components/password_manager/core/common/password_manager_features.h
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm

Sign in to add a comment