New issue
Advanced search Search tips

Issue 792839 link

Starred by 1 user
Status: Fixed
Owner:
mpichlin...@opera.com
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Allow custom handling of ContentMainRunner initialization failure.

Project Member Reported by mpichlin...@opera.com, Dec 7 2017 
Currently if ContentMainRunner initialization fails then browser crashes. In Opera we pass initialization failure to the delegate and inform user about the failure and suggest to reinstall browser.

In this bug I want just to add to chromium possibility of handling ContentMainRunner initialization failure by the delegate with current default crash behavior.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8237d65cd0b6ad28b59ede3bdc0930a11274a2f7

commit 8237d65cd0b6ad28b59ede3bdc0930a11274a2f7
Author: Michał Pichliński <mpichlinski@opera.com>
Date: Thu Jan 04 19:15:53 2018

Allow delegate to handle ContentMainRunner fatal initialization error.

Report ContentMainRunner fatal error during initialization to the delegate,
which may gracefuly exit with some message instead crashing.
Default behavior is CHECK(false).

Bug:  792839 
Change-Id: I1e7c85c58f1a008e8818e2efb00dbba7f4774826
Reviewed-on: https://chromium-review.googlesource.com/815054
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527056}
[modify] https://crrev.com/8237d65cd0b6ad28b59ede3bdc0930a11274a2f7/content/app/content_main_runner.cc
[modify] https://crrev.com/8237d65cd0b6ad28b59ede3bdc0930a11274a2f7/content/public/app/content_main_delegate.cc
[modify] https://crrev.com/8237d65cd0b6ad28b59ede3bdc0930a11274a2f7/content/public/app/content_main_delegate.h

Comment 2 by mpichlin...@opera.com, Jan 18 2018

Status: Fixed (was: Started)
►

Sign in to add a comment