New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 792829 link

Starred by 2 users
Status: Fixed
Owner:
wzang@chromium.org
Closed: Jan 2018
Cc:
x...@chromium.org
ajha@chromium.org
█ brajkumar@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Broken thumbnail image is seen at the bottom of Set wallpaper overlay

Project Member Reported by kebalaji@chromium.org, Dec 7 2017 
Chrome Version:  63.0.3239.85/10032.68.0 beta Candy,Reks,Daisy
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover build>> Sign-in to user
(2)Wait until the user account gets synced with the machine
(3)Click on Set Wallpaper and observe(Refer Video)

Actual: Broken thumbnail image is seen at the bottom of Set wallpaper overlay
Expected: No such broken image should be seen

This is a Regression issue seen from M60.

NOTE: Issue is not seen in Windows and Linux

@Wzang: Please confirm the issue
ActualWallpaper.mp4
6.8 MB View Download

Comment 1 by songsuk@chromium.org, Dec 7 2017 

After installing Recover build,  I see the issue the first time "Set Wallpaper" runs (63.0.3239.85/10032.68.0 -peppy). Thumbnail image is properly displayed when clicking on the other images or relaunching the "Set Wallpaper".

Comment 2 by songsuk@chromium.org, Dec 7 2017 

Able to reproduce the issue on Chrome 62.0.3202.97/CrOS 9901.77.0 -Reks.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/134424bb09ebf38a13453dc7da14be648c5b08b9

commit 134424bb09ebf38a13453dc7da14be648c5b08b9
Author: Wenzhao Zang <wzang@chromium.org>
Date: Sat Jan 27 07:40:12 2018

cros: Fix broken thumbnail on wallpaper picker

When showing the wallpaper picker for the first time after OOBE,
|saveThumbnail| may not completed, when the bottom left small thumbnail
to show. In this case, initial a HTTP request to fetch the thumbnail.

Bug:  792829 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3016687326156bc25d7a0e9a09c770efd1d1b4d7
Reviewed-on: https://chromium-review.googlesource.com/887963
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532191}
[modify] https://crrev.com/134424bb09ebf38a13453dc7da14be648c5b08b9/chrome/browser/resources/chromeos/wallpaper_manager/js/constants.js
[modify] https://crrev.com/134424bb09ebf38a13453dc7da14be648c5b08b9/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js
[modify] https://crrev.com/134424bb09ebf38a13453dc7da14be648c5b08b9/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

Comment 4 by wzang@chromium.org, Jan 27 2018

Labels: Merge-Request-65
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 28 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 29 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e8ea720670bbc86704850a75495d5d1dc0eca5a

commit 2e8ea720670bbc86704850a75495d5d1dc0eca5a
Author: Wenzhao Zang <wzang@chromium.org>
Date: Mon Jan 29 20:00:29 2018

[Merge to M65] cros: Fix broken thumbnail on wallpaper picker

When showing the wallpaper picker for the first time after OOBE,
|saveThumbnail| may not completed, when the bottom left small thumbnail
to show. In this case, initial a HTTP request to fetch the thumbnail.

TBR=wzang@chromium.org

(cherry picked from commit 134424bb09ebf38a13453dc7da14be648c5b08b9)

Bug:  792829 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3016687326156bc25d7a0e9a09c770efd1d1b4d7
Reviewed-on: https://chromium-review.googlesource.com/887963
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#532191}
Reviewed-on: https://chromium-review.googlesource.com/891762
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#150}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/2e8ea720670bbc86704850a75495d5d1dc0eca5a/chrome/browser/resources/chromeos/wallpaper_manager/js/constants.js
[modify] https://crrev.com/2e8ea720670bbc86704850a75495d5d1dc0eca5a/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js
[modify] https://crrev.com/2e8ea720670bbc86704850a75495d5d1dc0eca5a/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

Comment 7 by wzang@chromium.org, Jan 29 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment