New issue
Advanced search Search tips

Issue 792815 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in SkString::operator=

Project Member Reported by ClusterFuzz, Dec 7 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4544656678584320

Fuzzer: sugoi_filter_fuzzer
Job Type: linux_asan_filter_fuzz_stub
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  SkString::operator=
  SkReadBuffer::readFlattenable
  SkImageFilter::Common::unflatten
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_filter_fuzz_stub&range=522280:522288

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4544656678584320

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 7 2017

Labels: M-64 ClusterFuzz-Top-Crash ReleaseBlock-Beta
Testcase 4544656678584320 is a top crash on ClusterFuzz for linux platform. Please prioritize fixing this crash.

Marking this crash as a Beta release blocker.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 2 by ClusterFuzz, Dec 7 2017

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, Dec 7 2017

Labels: Test-Predator-Auto-Owner
Owner: reed@google.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://skia.googlesource.com/skia/+/fadbfcd4aba676d44dfb08de1a83143a1c63b95c (upgrade SkReadBuffer to always validate).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 4 by reed@google.com, Dec 7 2017

Cc: mtkl...@google.com
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/44aa9b2d1e708acb0e32db549abff793283ff442

commit 44aa9b2d1e708acb0e32db549abff793283ff442
Author: Mike Reed <reed@google.com>
Date: Thu Dec 07 18:25:09 2017

check for bad strings in readFlattenable

Bug:792815
Change-Id: I3b79d8b182bd129e9a17185991020d1dafb66a34
Reviewed-on: https://skia-review.googlesource.com/82060
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>

[modify] https://crrev.com/44aa9b2d1e708acb0e32db549abff793283ff442/src/core/SkReadBuffer.cpp

Project Member

Comment 6 by ClusterFuzz, Dec 8 2017

ClusterFuzz has detected this issue as fixed in range 522604:522607.

Detailed report: https://clusterfuzz.com/testcase?key=4544656678584320

Fuzzer: sugoi_filter_fuzzer
Job Type: linux_asan_filter_fuzz_stub
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  SkString::operator=
  SkReadBuffer::readFlattenable
  SkImageFilter::Common::unflatten
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_filter_fuzz_stub&range=522280:522288
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_filter_fuzz_stub&range=522604:522607

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4544656678584320

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Dec 8 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4544656678584320 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment