New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792798 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 634542
issue 792797



Sign in to add a comment

Add ImageData constructor from StaticBitmapImage

Project Member Reported by zakerinasab@chromium.org, Dec 7 2017

Issue description

Add a new ImageData constructor from StaticBitmapImage. This is in line with the current strategy of preferring StaticBitmapImage over other intermediate forms of pixel storage. This also helps to fix two current bugs: 

-  crbug.com/792797 : adding color management to HTMLCanvasElement toBlob/toDataURL
-  crbug.com/776806 : removing ImageBuffer and ImageBufferSurface (non-blocking?)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c863229da24ed1cb180759c9342e7a5125fd6f5

commit 2c863229da24ed1cb180759c9342e7a5125fd6f5
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Wed Dec 13 22:13:38 2017

Add ImageData constructor from StaticBitmapImage

This change adds a new ImageData constructor from StaticBitmapImage. This is
in line with the current strategy of preferring StaticBitmapImage over other
intermediate forms of pixel storage. This also helps to fix two current bugs:

-  crbug.com/792797 : adding color management to HTMLCanvasElement toBlob/toDataURL
-  crbug.com/776806 : removing ImageBuffer and ImageBufferSurface (non-blocking?)

Bug:  792798 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id64eb6695399a2b0f6640e3261ef70caf4ccf5f3
Reviewed-on: https://chromium-review.googlesource.com/814497
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523902}
[modify] https://crrev.com/2c863229da24ed1cb180759c9342e7a5125fd6f5/third_party/WebKit/Source/core/html/ImageData.cpp
[modify] https://crrev.com/2c863229da24ed1cb180759c9342e7a5125fd6f5/third_party/WebKit/Source/core/html/ImageData.h
[modify] https://crrev.com/2c863229da24ed1cb180759c9342e7a5125fd6f5/third_party/WebKit/Source/core/html/ImageDataTest.cpp
[modify] https://crrev.com/2c863229da24ed1cb180759c9342e7a5125fd6f5/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
[modify] https://crrev.com/2c863229da24ed1cb180759c9342e7a5125fd6f5/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/2c863229da24ed1cb180759c9342e7a5125fd6f5/third_party/WebKit/Source/platform/graphics/GraphicsTypes.h

Status: Fixed (was: Assigned)

Sign in to add a comment