app_list::SearchResultView should use views::StyledLabel for title/details |
||||||
Issue descriptionChrome Version: m65 currently it manipulates gfx::RenderText instances directly, which takes some decision-making and optimisation opportunities away from the toolkit. E.g. it uses Font::DeriveWithSizeDelta(2) which is quite slow, and has custom color constants rather than using ash_typography.h for styling Context: https://chromium-review.googlesource.com/c/chromium/src/+/805534#157 and Issue 791391
,
Aug 24
Should we not be using DeriveWithSizeDelta? It's used in other places as well.
,
Aug 27
Yeah all the places using gfx::Font[List]::DeriveWithSizeDelta are slow and they should all be replaced. That method typically requires synchronous IPC with the font server, and may even access font files on disk. These are not things we do on the UI thread in Chrome. Note there is also ui::ResourceBundle::GetFontListWithDelta(), which has a cache. It's better. But more generally, we shouldn't be scattering constants throughout the codebase in order to call GetFontListWithDelta(). Typically there's another set of constants for text color, and another for line spacing. ash_typography.h provides a means to bundle these up together, in one place.
,
Aug 27
Ok, thanks for explaining! Very interesting.
,
Dec 12
Unassigning so others from the launcher team can take it.
,
Dec 12
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vadimt@chromium.org
, Dec 13 2017