New issue
Advanced search Search tips

Issue 792784 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
calamity@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ash::[Default]FrameHeader should use regular views::

Project Member Reported by tapted@chromium.org, Dec 7 2017 
Chrome Version: m65

ash::HeaderView has a unique_ptr to ash::DefaultFrameHeader to paint the header (not a View). But it has a weak pointer to a FrameCaptionButtonContainerView member (a View)

DefaultFrameHeader could probably just be a regular View, and host a views::Label for the title rather than constructing a gfx::RenderText

(Is there a reason why it can't?)

Context: https://chromium-review.googlesource.com/c/chromium/src/+/805534#44 and Issue 791391

Comment 1 by calamity@chromium.org, Dec 7 2017 

AFAICT, this would be ideal. It's a big refactor because of the chaotic state of the ash browser frame.

BrowserNonClientFrameViewAsh - used for tabbed browsers 
(BrowserFrameHeader), popups (DefaultFrameHeader), and hosted app windows (HostedAppFrameHeader)
PanelFrameView - Used for panels (DefaultFrameHeader). Slated for deletion
HeaderView - Used for Chrome Apps (DefaultFrameHeader)

Each of these relies on the FrameHeader to draw and layout their buttons and titles. Ideally, we'd unify this all under one view (probably HeaderView) and remove the FrameHeader class entirely.
Project Member

Comment 2 by sheriffbot@chromium.org, Dec 7

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by xiy...@chromium.org, Dec 7

Components: -UI>Shell Internals>Views
►

Sign in to add a comment