-
Merge impl of content/renderer/service_worker/web_service_worker_installed_scripts_manager_impl.{cc,h} into third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerInstalledScriptsManager.{cc,h}.
-
Remove the unnecessary layer third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerInstalledScriptsManager.h.
-
Pass blink::mojom::ServiceWorkerInstalledScriptsInfoPtr along until ctor of blink::WebEmbeddedWorkerImpl to create blink::ServiceWorkerInstalledScriptsManager.
We need to discuss:
-
Move content/renderer/service_worker/thread_safe_script_container.{cc,h} into
Option1 -- third_party/WebKit/Source/modules/serviceworkers/ ?
or
Option2 -- third_party/WebKit/Source/platform/ ?
The problem is, we may introduce the following dependencies into the target directory:
#include "base/memory/ref_counted.h"
#include "base/synchronization/condition_variable.h"
#include "base/synchronization/lock.h"
#include "base/stl_util.h"
I think Onion Soup 2.0 encourages Blink core/ and modules/ to use //base directly, see https://docs.google.com/document/d/1hBKAYGGM2Zm7qhqXtdLSubklVDKUo9ir-vJtPEOx11Y/edit#heading=h.ewlfo4dv694q, so I'd like to choose the above Option1, but I noticed that currently modules/ is not using any //base impl except the only one 'base/memory/scoped_refptr.h'.. So maybe there are still some concerns about that? WDYT?
# For either case, we need to put blink::WebServiceWorkerInstalledScriptsManager::RawScriptData together with thread_safe_script_container impl.
Comment 1 by shimazu@chromium.org
, Dec 7 2017