New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 840448
issue 777621
issue 797357



Sign in to add a comment
link

Issue 792774: WebUI: Migrate away from using 'var'.

Reported by dpa...@chromium.org, Dec 7 2017 Project Member

Issue description

Per Google JS styleguide const/let should always be preferred over 'var', see [1].

Specifically the part that says "The var keyword must not be used."

As we migrate various folders to not use var, we should also enable the ESLint no-var check. Example CL is at [2]. Also note that there is a tool that can help automatic migrations. I'll post more instructions soon.

[1] https://google.github.io/styleguide/jsguide.html#features-use-const-and-let
[2] https://chromium-review.googlesource.com/c/chromium/src/+/807684.
 

Comment 1 by bugdroid1@chromium.org, Dec 7 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e81dda83e2309e9faa74cda282d6f9ed4a6f870

commit 7e81dda83e2309e9faa74cda282d6f9ed4a6f870
Author: dpapad <dpapad@chromium.org>
Date: Thu Dec 07 04:29:57 2017

WebUI: Migrate cr_elements tests to use let/const instead of var.

Bug: 792774
Change-Id: I2507ec439d43880de311edc9bc8131bc774edc3d
Reviewed-on: https://chromium-review.googlesource.com/807684
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522336}
[add] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/.eslintrc.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_action_menu_test.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_dialog_test.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_elements_focus_test.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_lazy_render_tests.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_policy_indicator_behavior_tests.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_policy_indicator_tests.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_policy_network_indicator_tests.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_policy_pref_indicator_tests.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_policy_strings.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_profile_avatar_selector_tests.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_toast_test.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_toggle_test.js
[modify] https://crrev.com/7e81dda83e2309e9faa74cda282d6f9ed4a6f870/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js

Comment 2 by dpa...@chromium.org, Dec 22 2017

Blockedon: 797357

Comment 3 by bugdroid1@chromium.org, Jan 4 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70f3d32a0b77a6214b22ccc0b4486540880373e7

commit 70f3d32a0b77a6214b22ccc0b4486540880373e7
Author: dpapad <dpapad@chromium.org>
Date: Thu Jan 04 22:38:52 2018

Settings WebUI cleanup: Migrate tests from var to let/const.

Also enabling an ESLint presubmit check to enforce it from now on.

Bug: 792774
Change-Id: If700ff1c88e31001019fc693e201c8c4ff8b9675
Reviewed-on: https://chromium-review.googlesource.com/841536
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527124}
[add] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/.eslintrc.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/a11y/basic_a11y_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/a11y/edit_dictionary_a11y_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/a11y/manage_profile_a11y_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/a11y/passwords_a11y_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/a11y/sign_out_a11y_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/about_page_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/advanced_page_browsertest.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/all_sites_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/android_apps_page_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/animation_browsertest.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/appearance_fonts_page_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/appearance_page_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/basic_page_browsertest.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/bluetooth_page_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/category_default_setting_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/category_setting_exceptions_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/certificate_manager_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/checkbox_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/chrome_cleanup_page_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/controlled_button_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/controlled_radio_button_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/cr_settings_interactive_ui_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/cups_printer_page_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/date_time_page_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/default_browser_browsertest.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/device_page_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/downloads_page_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/dropdown_menu_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/edit_dictionary_a11y_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/edit_dictionary_page_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/extension_controlled_indicator_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/fake_bluetooth.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/fake_bluetooth_private.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/fake_language_settings_private.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/fake_quick_unlock_private.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/fake_quick_unlock_uma.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/fake_settings_private.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/fake_system_display.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/fingerprint_browsertest_chromeos.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/fingerprint_progress_arc_browsertest_chromeos.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/focus_row_behavior_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/google_assistant_page_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/help_page_browsertest.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/import_data_dialog_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/internet_page_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/languages_page_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/languages_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/metrics_reporting_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/multidevice_page_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/on_startup_browsertest.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/people_page_change_picture_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/people_page_manage_profile_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/people_page_sync_page_interactive_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/people_page_sync_page_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/people_page_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/pref_util_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/prefs_test_cases.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/prefs_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/privacy_page_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/protocol_handlers_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/reset_page_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/reset_profile_banner_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/route_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/search_engines_page_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/search_page_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/search_settings_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/settings_animated_pages_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/settings_idle_load_browsertest.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/settings_main_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/settings_menu_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/settings_page_browsertest.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/settings_slider_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/settings_subpage_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/settings_toggle_button_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/settings_ui_browsertest.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/site_data_details_subpage_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/site_data_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/site_details_permission_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/site_details_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/site_list_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/site_settings_page_browsertest.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/startup_urls_page_test.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/system_page_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/test_android_apps_browser_proxy.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/test_languages_browser_proxy.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/test_lifetime_browser_proxy.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/test_util.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/usb_devices_tests.js
[modify] https://crrev.com/70f3d32a0b77a6214b22ccc0b4486540880373e7/chrome/test/data/webui/settings/zoom_levels_tests.js

Comment 4 by bugdroid1@chromium.org, Jan 6 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e1257638b5542d485199545a9a826618982fe44

commit 9e1257638b5542d485199545a9a826618982fe44
Author: dpapad <dpapad@chromium.org>
Date: Sat Jan 06 00:01:06 2018

Settings WebUI: Remove unnecessary while loop.

The loop always executes exactly once. The while loop revealed a Closure
compiler bug when migrating var to const. Removing the while loop bypasses the
bug, and unblocks further migration.

Bug: 792774
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7eecae5c797eab359a3ecd00e145bbf3d406fadc
Reviewed-on: https://chromium-review.googlesource.com/852635
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527435}
[modify] https://crrev.com/9e1257638b5542d485199545a9a826618982fe44/chrome/browser/resources/settings/search_settings.js

Comment 5 by bugdroid1@chromium.org, Jan 8 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edf1b3f094a4a48c41bbc255644130db6d8d53a6

commit edf1b3f094a4a48c41bbc255644130db6d8d53a6
Author: dpapad <dpapad@chromium.org>
Date: Mon Jan 08 20:22:22 2018

History WebUI cleanup: Migrate from var to let/const.

Also enabling an ESLint presubmit check to enforce it from now on.

Bug: 792774
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieb8471fb1755ffcf0d26b24e7c37d7d28c462dda
Reviewed-on: https://chromium-review.googlesource.com/853125
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527735}
[add] https://crrev.com/edf1b3f094a4a48c41bbc255644130db6d8d53a6/chrome/browser/resources/md_history/.eslintrc.js
[modify] https://crrev.com/edf1b3f094a4a48c41bbc255644130db6d8d53a6/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/edf1b3f094a4a48c41bbc255644130db6d8d53a6/chrome/browser/resources/md_history/browser_service.js
[modify] https://crrev.com/edf1b3f094a4a48c41bbc255644130db6d8d53a6/chrome/browser/resources/md_history/constants.js
[modify] https://crrev.com/edf1b3f094a4a48c41bbc255644130db6d8d53a6/chrome/browser/resources/md_history/externs.js
[modify] https://crrev.com/edf1b3f094a4a48c41bbc255644130db6d8d53a6/chrome/browser/resources/md_history/history.js
[modify] https://crrev.com/edf1b3f094a4a48c41bbc255644130db6d8d53a6/chrome/browser/resources/md_history/history_item.js
[modify] https://crrev.com/edf1b3f094a4a48c41bbc255644130db6d8d53a6/chrome/browser/resources/md_history/history_list.js
[modify] https://crrev.com/edf1b3f094a4a48c41bbc255644130db6d8d53a6/chrome/browser/resources/md_history/query_manager.js
[modify] https://crrev.com/edf1b3f094a4a48c41bbc255644130db6d8d53a6/chrome/browser/resources/md_history/router.js
[modify] https://crrev.com/edf1b3f094a4a48c41bbc255644130db6d8d53a6/chrome/browser/resources/md_history/searched_label.js
[modify] https://crrev.com/edf1b3f094a4a48c41bbc255644130db6d8d53a6/chrome/browser/resources/md_history/side_bar.js
[modify] https://crrev.com/edf1b3f094a4a48c41bbc255644130db6d8d53a6/chrome/browser/resources/md_history/synced_device_card.js
[modify] https://crrev.com/edf1b3f094a4a48c41bbc255644130db6d8d53a6/chrome/browser/resources/md_history/synced_device_manager.js

Comment 6 by bugdroid1@chromium.org, Jan 8 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00039d9d25367b9b21ff13a495729db513cf6ffe

commit 00039d9d25367b9b21ff13a495729db513cf6ffe
Author: dpapad <dpapad@chromium.org>
Date: Mon Jan 08 23:35:06 2018

Settings WebUI cleanup: Migrate from var to let/const.

Bug: 792774
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2ec7def66af31e959639c0d5919f850d41219cfe
Reviewed-on: https://chromium-review.googlesource.com/842477
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527811}
[add] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/.eslintrc.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/a11y_page/a11y_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/about_page/channel_switcher_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/about_page/detailed_build_info.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/android_apps_page/android_apps_browser_proxy.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/android_apps_page/android_apps_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/animation/animation.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/animation/fade_animations.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/appearance_page/appearance_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/appearance_page/fonts_browser_proxy.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/basic_page/basic_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/controls/extension_controlled_indicator.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/controls/pref_control_behavior.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/controls/settings_checkbox.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/controls/settings_dropdown_menu.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/controls/settings_idle_load.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/controls/settings_radio_group.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/controls/settings_slider.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/date_time_page/date_time_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/date_time_page/timezone_selector.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/default_browser_page/default_browser_browser_proxy.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/device_page/device_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/device_page/display.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/device_page/display_layout.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/device_page/display_overscan_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/device_page/drag_behavior.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/device_page/layout_behavior.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/device_page/night_light_slider.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/device_page/pointers.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/device_page/power.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/device_page/stylus.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/focus_row_behavior.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/global_scroll_target_behavior.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/internet_page/internet_config.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/internet_page/internet_subpage.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/internet_page/network_proxy_section.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/internet_page/network_summary.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/internet_page/network_summary_item.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/internet_page/tether_connection_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/languages_page/edit_dictionary_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/languages_page/languages.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/languages_page/languages_types.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/languages_page/manage_input_methods_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/on_startup_page/on_startup_browser_proxy.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/on_startup_page/startup_urls_page_browser_proxy.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/page_visibility.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/passwords_and_forms_page/show_password_behavior.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/people_page/change_picture.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/people_page/fingerprint_list.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/people_page/fingerprint_progress_arc.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/people_page/lock_screen_constants.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/people_page/lock_state_behavior.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/people_page/manage_profile.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/people_page/manage_profile_browser_proxy.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/people_page/users_add_user_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/prefs/pref_util.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/prefs/prefs.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/prefs/prefs_behavior.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/prefs/prefs_types.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/printing_page/cups_printers.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/printing_page/cups_printers_list.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/printing_page/cups_set_manufacturer_model_behavior.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/printing_page/printing_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/privacy_page/privacy_page_browser_proxy.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/reset_page/reset_browser_proxy.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/search_engines_page/search_engines_browser_proxy.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/search_engines_page/search_engines_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/search_page/search_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/search_settings.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/settings_page/main_page_behavior.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/settings_page/settings_section.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/all_sites.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/category_default_setting.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/constants.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/cookie_info.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/local_data_browser_proxy.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/protocol_handlers.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/site_data.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/site_details.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/usb_devices.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/website_usage_private_api.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings/zoom_levels.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
[modify] https://crrev.com/00039d9d25367b9b21ff13a495729db513cf6ffe/chrome/browser/resources/settings/system_page/system_page.js

Comment 7 by bugdroid1@chromium.org, Jan 9 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c42548c9cd927c19b246dcafbef8ba9d45d451ce

commit c42548c9cd927c19b246dcafbef8ba9d45d451ce
Author: Demetrios Papadopoulos <dpapad@chromium.org>
Date: Tue Jan 09 21:25:12 2018

MD History/Bookmarks cleanup:  Migrate from var to let/const.

Bug: 792774
Change-Id: If460242199dfe9e7cead62def00d3cb6e861eaa3
Reviewed-on: https://chromium-review.googlesource.com/855588
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528116}
[add] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/.eslintrc.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/actions_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/app_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/command_manager_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/edit_dialog_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/folder_node_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/item_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/list_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/policy_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/reducers_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/router_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/store_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/test_command_manager.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/test_store.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/test_util.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/toast_manager_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/toolbar_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_bookmarks/util_test.js
[add] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_history/.eslintrc.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_history/history_drawer_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_history/history_item_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_history/history_list_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_history/history_metrics_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_history/history_overflow_menu_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_history/history_routing_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_history/history_supervised_user_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_history/history_synced_tabs_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_history/history_toolbar_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_history/md_history_browsertest.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_history/md_history_focus_test.js
[modify] https://crrev.com/c42548c9cd927c19b246dcafbef8ba9d45d451ce/chrome/test/data/webui/md_history/test_util.js

Comment 8 by dpa...@chromium.org, Jan 9 2018

Blockedon: 777621

Comment 9 by dpa...@chromium.org, Jan 10 2018

Two more CLs landed about this, before this bug was created, listing for completeness:

https://chromium-review.googlesource.com/c/chromium/src/+/661719
https://chromium-review.googlesource.com/c/chromium/src/+/602602

Comment 10 by bugdroid1@chromium.org, Jan 12 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b52d97bb1a93b595f6ee00abba0eb01a41ee252e

commit b52d97bb1a93b595f6ee00abba0eb01a41ee252e
Author: Demetrios Papadopoulos <dpapad@chromium.org>
Date: Fri Jan 12 01:33:48 2018

md_user_manager cleanup: Migrate from var to let/const.

Migration caught a case where AvatarIcon typedef was declared twice
with slightly different types.

Bug: 792774
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib6ba85956dedb9d8f28c779a1e77357a643b02a9
Reviewed-on: https://chromium-review.googlesource.com/855505
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528838}
[add] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/browser/resources/md_user_manager/.eslintrc.js
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/browser/resources/md_user_manager/compiled_resources2.gyp
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/browser/resources/md_user_manager/create_profile.js
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/browser/resources/md_user_manager/import_supervised_user.js
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/browser/resources/md_user_manager/profile_browser_proxy.js
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/browser/resources/md_user_manager/supervised_user_create_confirm.js
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/browser/resources/md_user_manager/supervised_user_learn_more.js
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/browser/resources/md_user_manager/user_manager.js
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/browser/resources/md_user_manager/user_manager_pages.js
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/browser/resources/md_user_manager/user_manager_tutorial.js
[add] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/test/data/webui/md_user_manager/.eslintrc.js
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/test/data/webui/md_user_manager/control_bar_tests.js
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/test/data/webui/md_user_manager/create_profile_tests.js
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/test/data/webui/md_user_manager/user_manager_browsertest.js
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/chrome/test/data/webui/md_user_manager/user_manager_pages_tests.js
[modify] https://crrev.com/b52d97bb1a93b595f6ee00abba0eb01a41ee252e/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.js

Comment 11 by bugdroid1@chromium.org, Jul 11 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c

commit 92de4b2e3c9b3df980e5dd7e781c8c239378cb9c
Author: dpapad <dpapad@chromium.org>
Date: Wed Jul 11 01:29:26 2018

Extensions WebUI: Migrate tests from var to const/let.

Bug: 792774
Change-Id: I81bc4c1d032a775319c68ee17f8e1322839d8fd7
Reviewed-on: https://chromium-review.googlesource.com/991155
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574031}
[add] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/.eslintrc.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/a11y/extensions_a11y_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_code_section_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_detail_view_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_error_page_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_item_list_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_item_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_keyboard_shortcuts_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_load_error_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_manager_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_manager_unit_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_navigation_helper_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_options_dialog_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_pack_dialog_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_shortcut_input_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_sidebar_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_test_util.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_toolbar_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/extension_view_manager_test.js
[modify] https://crrev.com/92de4b2e3c9b3df980e5dd7e781c8c239378cb9c/chrome/test/data/webui/extensions/toggle_row_test.js

Comment 12 by dpa...@chromium.org, Jul 30 2018

Blockedon: 840448

Comment 13 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/004cb56af22ba271c2fbf22f911b784a4a8b2132

commit 004cb56af22ba271c2fbf22f911b784a4a8b2132
Author: Roman Aleksandrov <raleksandrov@google.com>
Date: Fri Nov 09 18:50:09 2018

Migrate away from using 'var' in network directory.

Just simple refactoring.

Bug: 792774
Change-Id: I90e97fb8fd4e1ab5bb91f03b19ec8031eeb24375
Reviewed-on: https://chromium-review.googlesource.com/c/1326145
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#606918}
[modify] https://crrev.com/004cb56af22ba271c2fbf22f911b784a4a8b2132/ui/webui/resources/cr_components/chromeos/network/network_apnlist.js
[modify] https://crrev.com/004cb56af22ba271c2fbf22f911b784a4a8b2132/ui/webui/resources/cr_components/chromeos/network/network_choose_mobile.js
[modify] https://crrev.com/004cb56af22ba271c2fbf22f911b784a4a8b2132/ui/webui/resources/cr_components/chromeos/network/network_config.js
[modify] https://crrev.com/004cb56af22ba271c2fbf22f911b784a4a8b2132/ui/webui/resources/cr_components/chromeos/network/network_config_element_behavior.js
[modify] https://crrev.com/004cb56af22ba271c2fbf22f911b784a4a8b2132/ui/webui/resources/cr_components/chromeos/network/network_config_select.js
[modify] https://crrev.com/004cb56af22ba271c2fbf22f911b784a4a8b2132/ui/webui/resources/cr_components/chromeos/network/network_ip_config.js
[modify] https://crrev.com/004cb56af22ba271c2fbf22f911b784a4a8b2132/ui/webui/resources/cr_components/chromeos/network/network_nameservers.js
[modify] https://crrev.com/004cb56af22ba271c2fbf22f911b784a4a8b2132/ui/webui/resources/cr_components/chromeos/network/network_property_list.js
[modify] https://crrev.com/004cb56af22ba271c2fbf22f911b784a4a8b2132/ui/webui/resources/cr_components/chromeos/network/network_proxy.js
[modify] https://crrev.com/004cb56af22ba271c2fbf22f911b784a4a8b2132/ui/webui/resources/cr_components/chromeos/network/network_proxy_exclusions.js
[modify] https://crrev.com/004cb56af22ba271c2fbf22f911b784a4a8b2132/ui/webui/resources/cr_components/chromeos/network/network_proxy_input.js
[modify] https://crrev.com/004cb56af22ba271c2fbf22f911b784a4a8b2132/ui/webui/resources/cr_components/chromeos/network/network_siminfo.js

Comment 14 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/145a1f3761c8aae5d31b55acf7211af378e174f5

commit 145a1f3761c8aae5d31b55acf7211af378e174f5
Author: dpapad <dpapad@chromium.org>
Date: Thu Nov 29 03:47:48 2018

WebUI: Use const/let instead of var in cr_elements/.

Conversions performed with a tool
./node_modules/lebab/bin/index.js --replace ui/webui/resources/cr_elements --transform let

Also adding .eslintrc.js file to prevent future additions of 'var' in that folder.

Bug: 792774
Change-Id: Ia7de669ffa717bc898fdc2989b9820a156ac1b1a
Reviewed-on: https://chromium-review.googlesource.com/c/1354565
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612022}
[add] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/.eslintrc.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_types.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_png_behavior.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/chromeos/network/cr_network_icon.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/chromeos/network/cr_network_list.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/chromeos/network/cr_network_list_item.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/chromeos/network/cr_network_list_types.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/chromeos/network/cr_network_listener_behavior.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/chromeos/network/cr_network_select.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/chromeos/network/cr_onc_types.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/cr_container_shadow_behavior.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector_grid.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/cr_radio_button/cr_radio_button_behavior.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/cr_scrollable_behavior.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/policy/cr_policy_network_behavior.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/policy/cr_policy_pref_behavior.js
[modify] https://crrev.com/145a1f3761c8aae5d31b55acf7211af378e174f5/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js

Comment 15 by bugdroid1@chromium.org, Nov 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4afa337efecd91c6b0180aeb2a2e538cb042faef

commit 4afa337efecd91c6b0180aeb2a2e538cb042faef
Author: dpapad <dpapad@chromium.org>
Date: Fri Nov 30 22:30:24 2018

WebUI: Use const/let instead of var in cr_components/.

Conversions performed with a tool
./node_modules/lebab/bin/index.js \
    --replace ui/webui/resources/cr_components --transform let

A .eslintrc.js file already exists, so probably these violations had
not been fixed at the time it was added.

Bug: 792774
Change-Id: I647bbf9a08c816fe810acf6582a5d9a0a45a96a0
Reviewed-on: https://chromium-review.googlesource.com/c/1354575
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612822}
[modify] https://crrev.com/4afa337efecd91c6b0180aeb2a2e538cb042faef/ui/webui/resources/cr_components/certificate_manager/ca_trust_edit_dialog.js
[modify] https://crrev.com/4afa337efecd91c6b0180aeb2a2e538cb042faef/ui/webui/resources/cr_components/certificate_manager/certificate_delete_confirmation_dialog.js
[modify] https://crrev.com/4afa337efecd91c6b0180aeb2a2e538cb042faef/ui/webui/resources/cr_components/certificate_manager/certificate_list.js
[modify] https://crrev.com/4afa337efecd91c6b0180aeb2a2e538cb042faef/ui/webui/resources/cr_components/certificate_manager/certificate_manager.js
[modify] https://crrev.com/4afa337efecd91c6b0180aeb2a2e538cb042faef/ui/webui/resources/cr_components/certificate_manager/certificate_manager_types.js
[modify] https://crrev.com/4afa337efecd91c6b0180aeb2a2e538cb042faef/ui/webui/resources/cr_components/certificate_manager/certificate_password_encryption_dialog.js
[modify] https://crrev.com/4afa337efecd91c6b0180aeb2a2e538cb042faef/ui/webui/resources/cr_components/certificate_manager/certificate_subentry.js
[modify] https://crrev.com/4afa337efecd91c6b0180aeb2a2e538cb042faef/ui/webui/resources/cr_components/certificate_manager/certificates_browser_proxy.js
[modify] https://crrev.com/4afa337efecd91c6b0180aeb2a2e538cb042faef/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.js

Comment 16 by bugdroid1@chromium.org, Dec 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afba4e4b79cfdb85a6c13a46971a97ef95ebf719

commit afba4e4b79cfdb85a6c13a46971a97ef95ebf719
Author: dstockwell <dstockwell@google.com>
Date: Sun Dec 02 22:58:06 2018

pdf: enable eslint checks for no-var and prefer-const

Most of this change was automated by running `eslint --fix` but a
few cases were resolved manually (in particular global definitions
and typedefs).

Bug: 792774
Change-Id: Iea4e373a088d7d276975bf946a738bc9d81772c3
Reviewed-on: https://chromium-review.googlesource.com/c/1355302
Commit-Queue: dstockwell <dstockwell@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612985}
[add] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/.eslintrc.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/browser_api.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/gesture_detector.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/main.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/navigator.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/open_pdf_params_parser.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/pdf_fitting_type.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/pdf_scripting_api.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/pdf_viewer.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/toolbar_manager.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/viewport.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/viewport_scroller.js
[modify] https://crrev.com/afba4e4b79cfdb85a6c13a46971a97ef95ebf719/chrome/browser/resources/pdf/zoom_manager.js

Comment 17 by bugdroid1@chromium.org, Dec 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25

commit ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25
Author: dpapad <dpapad@chromium.org>
Date: Mon Dec 03 23:47:42 2018

WebUI: Convert remaining usages of var to let/const, part 1.

Conversions performed with a tool (lebab). In a few occasions had to
manually convert, where the tool could not determine if the conversion
was safe.

This is in preparation of turning on no-var, and prefer-const ESLint
checks for all of chrome/browser/resources/

Bug: 792774
Change-Id: I0d5fa98d5efb935e84c1990db635f96df5957e4d
Reviewed-on: https://chromium-review.googlesource.com/c/1357726
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613328}
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/about_sys/about_sys.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/accessibility/accessibility.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/feedback/js/event_handler.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/feedback/js/feedback.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/feedback/js/feedback_util.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/feedback/js/sys_info.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/feedback/js/take_screenshot.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/gaia_auth_host/authenticator.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/gaia_auth_host/channel.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/gaia_auth_host/post_message_channel.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/gaia_auth_host/saml_handler.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/gaia_auth_host/saml_injected.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/gaia_auth_host/webview_event_manager.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/hangout_services/thunk.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/identity_scope_approval_dialog/background.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/inline_login/inline_login.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/inspect/inspect.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/local_discovery/local_discovery.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/media/media_engagement.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/media/webrtc_logs.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/net_internals/browser_bridge.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/net_internals/chromeos_view.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/net_internals/dns_view.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/net_internals/domain_security_policy_view.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/net_internals/events_view.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/net_internals/main.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/net_internals/proxy_view.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/net_internals/sockets_view.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/net_internals/tab_switcher_view.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/net_internals/util.js
[modify] https://crrev.com/ed18408a82a82fc8bbe1a872ba9ccce5fb36bc25/chrome/browser/resources/net_internals/view.js

Comment 18 by bugdroid1@chromium.org, Dec 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aab699ede4dd07c16fde4428e347f55877071b2d

commit aab699ede4dd07c16fde4428e347f55877071b2d
Author: dpapad <dpapad@chromium.org>
Date: Tue Dec 04 19:33:48 2018

WebUI: Convert remaining usages of var to let/const, part 2.

Conversions performed with a combination of lebab and ESLint --fix.
In a few occasions had to manually convert, where the tool could not determine
if the conversion was safe.

This is in preparation of turning on no-var, and prefer-const ESLint
checks for all of chrome/browser/resources/

Bug: 792774
Change-Id: Ib0fe3108b1b6ec7b52b5f066358cf2fbae17895e
Reviewed-on: https://chromium-review.googlesource.com/c/1359465
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613645}
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/network_speech_synthesis/tts_extension.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/ntp4/apps_page.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/ntp4/dot_list.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/ntp4/incognito_tab.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/ntp4/logging.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/ntp4/nav_dot.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/ntp4/new_tab.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/ntp4/page_list_view.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/ntp4/page_switcher.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/ntp4/tile_page.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/ntp4/trash.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/offline_pages/offline_internals.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/predictors/autocomplete_action_predictor.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/predictors/resource_prefetch_predictor.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/quota_internals/event_handler.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/quota_internals/message_dispatcher.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/reset_password/reset_password.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/sandbox_internals/sandbox_internals.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/signin/dice_sync_confirmation/sync_confirmation_app.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/sync_file_system_internals/dump_database.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/sync_file_system_internals/extension_statuses.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/sync_file_system_internals/file_metadata.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/sync_file_system_internals/sync_service.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/sync_file_system_internals/task_log.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/sync_file_system_internals/utils.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/task_scheduler_internals/index.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/translate_internals/translate_internals.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/webapks/about_webapks.js
[modify] https://crrev.com/aab699ede4dd07c16fde4428e347f55877071b2d/chrome/browser/resources/welcome/welcome_win10.js

Comment 19 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa2d59dd31f5381e752783fd003fd1a197446a15

commit aa2d59dd31f5381e752783fd003fd1a197446a15
Author: dpapad <dpapad@chromium.org>
Date: Wed Dec 05 19:10:40 2018

WebUI: Convert remaining usages of var to let/const, part 3/3.

Conversions performed with a tool (lebab). In a few occasions had to
manually convert, where the tool could not determine if the conversion
was safe.

This is in preparation of turning on no-var, and prefer-const ESLint
checks for all of chrome/browser/resources/

Bug: 792774
Change-Id: I6df38ac00c27a412108ed841660bd758f5db0d67
Reviewed-on: https://chromium-review.googlesource.com/c/1361795
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614050}
[modify] https://crrev.com/aa2d59dd31f5381e752783fd003fd1a197446a15/chrome/browser/resources/about_flash.js
[modify] https://crrev.com/aa2d59dd31f5381e752783fd003fd1a197446a15/chrome/browser/resources/about_invalidations.js
[modify] https://crrev.com/aa2d59dd31f5381e752783fd003fd1a197446a15/chrome/browser/resources/about_nacl.js
[modify] https://crrev.com/aa2d59dd31f5381e752783fd003fd1a197446a15/chrome/browser/resources/certificate_viewer.js
[modify] https://crrev.com/aa2d59dd31f5381e752783fd003fd1a197446a15/chrome/browser/resources/components.js
[modify] https://crrev.com/aa2d59dd31f5381e752783fd003fd1a197446a15/chrome/browser/resources/connection_manager.js
[modify] https://crrev.com/aa2d59dd31f5381e752783fd003fd1a197446a15/chrome/browser/resources/identity_internals.js
[modify] https://crrev.com/aa2d59dd31f5381e752783fd003fd1a197446a15/chrome/browser/resources/policy_base.js
[modify] https://crrev.com/aa2d59dd31f5381e752783fd003fd1a197446a15/chrome/browser/resources/policy_tool.js
[modify] https://crrev.com/aa2d59dd31f5381e752783fd003fd1a197446a15/chrome/browser/resources/supervised_user_internals.js

Comment 20 by bugdroid1@chromium.org, Dec 6

Project Member

Comment 21 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c679720af6e8a2451705abf1acdcd7fe080c5a6

commit 7c679720af6e8a2451705abf1acdcd7fe080c5a6
Author: dpapad <dpapad@chromium.org>
Date: Tue Dec 11 01:37:03 2018

WebUI: Enable no-var and prefer-const ESLint rules for most folders.

Specifically:
 - Update chrome/browser/resources/.eslintrc.js to have the desired
   ESLint checks.
 - Explicitly override the default checks for folders that still have
   plenty of violations (bluetooth_internals/, chromeos/, cryptotoken/,
   local_ntp/, media_router/)

Bug: 792774,720034
Change-Id: I505b9ce7773bb706c47757447260630a3c4a38b1
Reviewed-on: https://chromium-review.googlesource.com/c/1357531
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615370}
[rename] https://crrev.com/7c679720af6e8a2451705abf1acdcd7fe080c5a6/chrome/browser/resources/.eslintrc.js
[rename] https://crrev.com/7c679720af6e8a2451705abf1acdcd7fe080c5a6/chrome/browser/resources/bluetooth_internals/.eslintrc.js
[copy] https://crrev.com/7c679720af6e8a2451705abf1acdcd7fe080c5a6/chrome/browser/resources/chromeos/.eslintrc.js
[modify] https://crrev.com/7c679720af6e8a2451705abf1acdcd7fe080c5a6/chrome/browser/resources/chromeos/chromevox/.eslintrc.js
[delete] https://crrev.com/41a1fad4c04e0c753656e710a06d38cae263bcef/chrome/browser/resources/chromeos/multidevice_setup/.eslintrc.js
[modify] https://crrev.com/7c679720af6e8a2451705abf1acdcd7fe080c5a6/chrome/browser/resources/chromeos/select_to_speak/.eslintrc.js
[modify] https://crrev.com/7c679720af6e8a2451705abf1acdcd7fe080c5a6/chrome/browser/resources/chromeos/switch_access/.eslintrc.js
[copy] https://crrev.com/7c679720af6e8a2451705abf1acdcd7fe080c5a6/chrome/browser/resources/cryptotoken/.eslintrc.js
[copy] https://crrev.com/7c679720af6e8a2451705abf1acdcd7fe080c5a6/chrome/browser/resources/local_ntp/.eslintrc.js
[delete] https://crrev.com/41a1fad4c04e0c753656e710a06d38cae263bcef/chrome/browser/resources/management/.eslintrc.js
[delete] https://crrev.com/41a1fad4c04e0c753656e710a06d38cae263bcef/chrome/browser/resources/md_bookmarks/.eslintrc.js
[delete] https://crrev.com/41a1fad4c04e0c753656e710a06d38cae263bcef/chrome/browser/resources/md_downloads/.eslintrc.js
[delete] https://crrev.com/41a1fad4c04e0c753656e710a06d38cae263bcef/chrome/browser/resources/md_extensions/.eslintrc.js
[delete] https://crrev.com/41a1fad4c04e0c753656e710a06d38cae263bcef/chrome/browser/resources/md_history/.eslintrc.js
[delete] https://crrev.com/41a1fad4c04e0c753656e710a06d38cae263bcef/chrome/browser/resources/md_user_manager/.eslintrc.js
[copy] https://crrev.com/7c679720af6e8a2451705abf1acdcd7fe080c5a6/chrome/browser/resources/media_router/.eslintrc.js
[delete] https://crrev.com/41a1fad4c04e0c753656e710a06d38cae263bcef/chrome/browser/resources/omnibox/.eslintrc.js
[delete] https://crrev.com/41a1fad4c04e0c753656e710a06d38cae263bcef/chrome/browser/resources/pdf/.eslintrc.js
[delete] https://crrev.com/41a1fad4c04e0c753656e710a06d38cae263bcef/chrome/browser/resources/print_preview/.eslintrc.js
[delete] https://crrev.com/41a1fad4c04e0c753656e710a06d38cae263bcef/chrome/browser/resources/settings/.eslintrc.js
[delete] https://crrev.com/41a1fad4c04e0c753656e710a06d38cae263bcef/chrome/browser/resources/snippets_internals/.eslintrc.js
[delete] https://crrev.com/41a1fad4c04e0c753656e710a06d38cae263bcef/chrome/browser/resources/welcome/onboarding_welcome/.eslintrc.js

Comment 22 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/657ebb7bbab4e31fe59762564ee3491de37cd10c

commit 657ebb7bbab4e31fe59762564ee3491de37cd10c
Author: Scott Chen <scottchen@chromium.org>
Date: Thu Dec 20 01:49:54 2018

WebUI: convert more let to const in c/r/b

Automatically convert more let to const in c/r/b using "eslint --fix".

Bug: 792774
Change-Id: If4422807022368c2c29a03cca78ce10eb6c4be87
Reviewed-on: https://chromium-review.googlesource.com/c/1385114
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618071}
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/discards/database_tab.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/discards/discards.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/discards/sorted_table_behavior.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/md_extensions/code_section.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/md_extensions/drag_and_drop_handler.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/md_extensions/error_page.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/md_extensions/item.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/md_extensions/navigation_helper.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/md_extensions/runtime_hosts_dialog.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/md_extensions/shortcut_input.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/md_extensions/shortcut_util.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/memory_internals.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/policy_base.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/print_preview/data/destination.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/print_preview/new/advanced_settings_item.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/print_preview/new/margin_control_container.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/a11y_page/manage_a11y_page.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/a11y_page/tts_subpage.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/about_page/channel_switcher_dialog.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/autofill_page/payments_section.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/controls/settings_toggle_button.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/crostini_page/crostini_shared_paths.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/date_time_page/timezone_subpage.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/device_page/display.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/incompatible_applications_page/incompatible_applications_page.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/multidevice_page/multidevice_page.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/search_settings.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/settings_page/settings_section.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/snippets_internals/snippets_internals.js
[modify] https://crrev.com/657ebb7bbab4e31fe59762564ee3491de37cd10c/chrome/browser/resources/usb_internals/usb_internals.js

Comment 23 by bugdroid1@chromium.org, Jan 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4894c8d753670a5de57cf2a5bb1214235a2fbe8c

commit 4894c8d753670a5de57cf2a5bb1214235a2fbe8c
Author: dpapad <dpapad@chromium.org>
Date: Fri Jan 04 22:52:36 2019

WebUI: Remove unnecessary global var "global", exposed from cr.js.

This is in preparation of converting more var to let/const.

Bug: 792774
Change-Id: I2b6ab4b92c3a81e775051ed535ffec1e88b2adc2
Reviewed-on: https://chromium-review.googlesource.com/c/1396477
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620095}
[modify] https://crrev.com/4894c8d753670a5de57cf2a5bb1214235a2fbe8c/ui/webui/resources/js/cr.js

Comment 24 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f968f610359dabba8a722e45b10aa28d5bba5a04

commit f968f610359dabba8a722e45b10aa28d5bba5a04
Author: dpapad <dpapad@chromium.org>
Date: Thu Jan 10 01:16:58 2019

WebUI: Migrate ui/webui/resources folder for var to let/const.

Also update ESLint checks to enforce these.

Bug: 792774
Change-Id: I7219a999d8420d51af88e8f3a5edb46e1bc99722
Reviewed-on: https://chromium-review.googlesource.com/c/1395297
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621404}
[rename] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/.eslintrc.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/assert.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/event_target.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/link_controller.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/array_data_model.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/autocomplete_list.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/bubble.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/bubble_button.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/card_slider.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/command.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/context_menu_button.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/context_menu_handler.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/controlled_indicator.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/dialogs.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/drag_wrapper.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/expandable_bubble.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/focus_grid.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/focus_manager.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/focus_outline_manager.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/focus_row.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/focus_without_ink.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/grid.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/list.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/list_item.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/list_selection_controller.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/list_selection_model.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/list_single_selection_model.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/menu.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/menu_button.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/menu_item.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/node_utils.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/overlay.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/page_manager/page.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/page_manager/page_manager.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/position_util.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/repeating_button.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/splitter.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/table.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/table/table_column.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/table/table_column_model.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/table/table_header.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/table/table_list.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/table/table_splitter.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/tabs.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/touch_handler.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/cr/ui/tree.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/event_tracker.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/i18n_behavior.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/i18n_template_no_process.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/icon.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/load_time_data.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/parse_html_subset.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/template_data_externs.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/util.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/web_ui_listener_behavior.js
[modify] https://crrev.com/f968f610359dabba8a722e45b10aa28d5bba5a04/ui/webui/resources/js/webui_resource_test.js

Comment 25 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3270b139a830b6f1082923855a6b6a9d4af4b923

commit 3270b139a830b6f1082923855a6b6a9d4af4b923
Author: Chris Morin <cmtm@google.com>
Date: Fri Jan 11 07:29:22 2019

WebUI: partial revert of migration from var to let/const

crrev.com/c/1395297 broke ARC++ opt-in dialog. Partially revert it to
unblock ARC++ development. Add comment to disable ESLint check at
original commiters request.

BUG=792774
BUG=b:122692988
TEST=Ensure arc opt-in dialog can be opened
TBR=dpapad@chromium.org

Change-Id: Iad64d4f3965dfb73097d0a806231dc4ee1fc5e5b
Reviewed-on: https://chromium-review.googlesource.com/c/1406242
Reviewed-by: Christopher Morin <cmtm@google.com>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Christopher Morin <cmtm@google.com>
Cr-Commit-Position: refs/heads/master@{#621935}
[modify] https://crrev.com/3270b139a830b6f1082923855a6b6a9d4af4b923/ui/webui/resources/js/i18n_template_no_process.js

Comment 26 by bugdroid1@chromium.org, Jan 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daa458a43790904db0613714fda2dc0bdcf7c6bb

commit daa458a43790904db0613714fda2dc0bdcf7c6bb
Author: dpapad <dpapad@chromium.org>
Date: Sat Jan 12 02:07:52 2019

WebUI: Re-convert i18n_template_no_process.js to let/const.

Previously this broke the arc_support ChromeOS extension, and was
reverted at https://chromium-review.googlesource.com/c/1406242.

This CL converts parts of that file to use let/const while, without casuing
issues for the arc_support extension.

Bug: 792774
Change-Id: I924f6ebc38185251b103b984c06123b7b98b0dc3
Reviewed-on: https://chromium-review.googlesource.com/c/1407769
Reviewed-by: Christopher Morin <cmtm@google.com>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622263}
[modify] https://crrev.com/daa458a43790904db0613714fda2dc0bdcf7c6bb/ui/webui/resources/js/i18n_template_no_process.js

Sign in to add a comment