New issue
Advanced search Search tips

Issue 792759 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Task

Blocking:
issue 723233



Sign in to add a comment

Add more targeted metrics for Loading Dispatcher v0

Project Member Reported by ksakamoto@chromium.org, Dec 7 2017

Issue description

Existing metrics ( issue 729951 ) were not sufficiently targeted at the use case to capture the expected benefits. Also we didn’t have targeted metrics for responsiveness and interactivity metrics.

We will re-run the experiment after adding more aggressively targeted metrics such as:
- Responsiveness and Interactivity metrics for the foreground tab when [1/2/4/6/8/10/10+] bg tabs are still loading.
- Page Load metrics for the foreground tab when [1/2/4/6/8/10/10+] bg tabs are still loading.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29650ae67de321eeac446a18c797aeba51cdfce8

commit 29650ae67de321eeac446a18c797aeba51cdfce8
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Thu Dec 07 03:42:34 2017

Add UMA that counts number of loading tabs

For ResourceLoadScheduler experiment, we plan to add more aggressively
targeted variants of PageLoad.Clients.MultiTabLoading.* metrics that
will only be logged if there are more than X loading tabs.

This will give us the distribution of number of loading tabs, and will
help us determine the threshold of the targeted metrics.

Bug:  792759 
Change-Id: I8aefd59f52cefd4c1e449795cfdace4fc44fdf98
Reviewed-on: https://chromium-review.googlesource.com/807866
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522329}
[modify] https://crrev.com/29650ae67de321eeac446a18c797aeba51cdfce8/chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer.cc
[modify] https://crrev.com/29650ae67de321eeac446a18c797aeba51cdfce8/chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer.h
[modify] https://crrev.com/29650ae67de321eeac446a18c797aeba51cdfce8/chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/29650ae67de321eeac446a18c797aeba51cdfce8/tools/metrics/histograms/histograms.xml

Cc: panicker@chromium.org
"Number of inflight loading tabs" UMA data from Canary channel comes in.

Desktop:
- only 1 inflight loading tab: 61%
- 2~4 inflight loading tabs: 27%
- 5~ inflight loading tabs: 11%

Android:
- only 1 inflight loading tab: 86%
- 2~4 inflight loading tabs: 13%
- 5~ inflight loading tabs: 1%

Based on that, I'm going to add two variants of MultiTabLoading metrics:
- MultiTabLoading.2OrMore: recorded only when there are 2 or more inflight loading tabs
- MultiTabLoading.5OrMore: recorded only when there are 5 or more inflight loading tabs

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/428cfddddbf57ccc323ca2b4c633c30842e10a28

commit 428cfddddbf57ccc323ca2b4c633c30842e10a28
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Dec 15 05:07:30 2017

Add more aggressively targeted variants of MultiTabLoading metrics

This adds variants of PageLoad.Clients.MultiTabLoading.* metrics that
are recorded only when there are >=2 (or >=5) inflight loading tabs.

Bug:  792759 
Change-Id: Ic1c8711d6424752dd80685b7740ec12fcc1c885e
Reviewed-on: https://chromium-review.googlesource.com/826706
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524329}
[modify] https://crrev.com/428cfddddbf57ccc323ca2b4c633c30842e10a28/chrome/browser/BUILD.gn
[modify] https://crrev.com/428cfddddbf57ccc323ca2b4c633c30842e10a28/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
[modify] https://crrev.com/428cfddddbf57ccc323ca2b4c633c30842e10a28/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[add] https://crrev.com/428cfddddbf57ccc323ca2b4c633c30842e10a28/chrome/browser/page_load_metrics/observers/histogram_suffixes.cc
[add] https://crrev.com/428cfddddbf57ccc323ca2b4c633c30842e10a28/chrome/browser/page_load_metrics/observers/histogram_suffixes.h
[modify] https://crrev.com/428cfddddbf57ccc323ca2b4c633c30842e10a28/chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer.cc
[modify] https://crrev.com/428cfddddbf57ccc323ca2b4c633c30842e10a28/chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer.h
[modify] https://crrev.com/428cfddddbf57ccc323ca2b4c633c30842e10a28/chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer_browsertest.cc
[modify] https://crrev.com/428cfddddbf57ccc323ca2b4c633c30842e10a28/chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/428cfddddbf57ccc323ca2b4c633c30842e10a28/tools/metrics/histograms/histograms.xml

Status: Started (was: Available)
Status: Fixed (was: Started)

Sign in to add a comment