Let findit luci builders run jobs as chromium.chromiumos builders. |
|||
Issue descriptionThese run fine in tryserver.chromium.linux/linux_chrome_variable but in https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.findit/findit_variable/94 we get Traceback (most recent call last): File "/b/swarming/w/ir/cache/builder/findit_variable/src/third_party/chromite/bin/cros", line 169, in <module> DoMain() File "/b/swarming/w/ir/cache/builder/findit_variable/src/third_party/chromite/bin/cros", line 165, in DoMain commandline.ScriptWrapperMain(FindTarget) File "/b/swarming/w/ir/cache/builder/findit_variable/src/third_party/chromite/lib/commandline.py", line 911, in ScriptWrapperMain ret = target(argv[1:]) File "/b/swarming/w/ir/cache/builder/findit_variable/src/third_party/chromite/scripts/cros.py", line 56, in main parser = GetOptions(command.ListCommands()) File "/b/swarming/w/ir/cache/builder/findit_variable/src/third_party/chromite/cli/command.py", line 84, in ListCommands _ImportCommands() File "/b/swarming/w/ir/cache/builder/findit_variable/src/third_party/chromite/cli/command.py", line 75, in _ImportCommands cros_import.ImportModule(import_path.split(os.path.sep)) File "/b/swarming/w/ir/cache/builder/findit_variable/src/third_party/chromite/lib/cros_import.py", line 44, in ImportModule module = __import__(target) File "/b/swarming/w/ir/cache/builder/findit_variable/src/third_party/chromite/cli/cros/cros_stage.py", line 14, in <module> from chromite.cbuildbot import commands File "/b/swarming/w/ir/cache/builder/findit_variable/src/third_party/chromite/cbuildbot/commands.py", line 30, in <module> from chromite.lib import gob_util File "/b/swarming/w/ir/cache/builder/findit_variable/src/third_party/chromite/lib/gob_util.py", line 33, in <module> from oauth2client.contrib import gce ImportError: No module named contrib step returned non-zero exit code: 1
,
Dec 7 2017
@iannucci, could you clarify? The build in question has a third_party/chromite revision from 1 week ago as per the json output of the bot_update step. Is that what you mean?
,
Dec 7 2017
I don't think it's because chromite's pin is old. Head has the same import line: https://chromium.googlesource.com/chromiumos/chromite/+/master/lib/gob_util.py#33 Looking at the bot the findit build is mirroring (https://ci.chromium.org/buildbot/chromium.chromiumos/chromeos-amd64-generic-rel/), its runhooks step sets PYTHONPATH: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2Fchromeos-amd64-generic-rel%2F2818%2F%2B%2Frecipes%2Fsteps%2Fgclient_runhooks%2F0%2Fstdout The findit build does not: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8960916317283152352%2F%2B%2Fsteps%2Fgclient_runhooks%2F0%2Fstdout That would explain why it can't find the oauth2client lib. The fix here is either: - invoke that bit of runhooks via vpython and add an oauth wheel to the env - copy the pythonpath magic to findit's build Fix #1 would probably be best. Though this would involve touching the "cros" tool in depot_tools, which I'm not familiar with at all. I'll take a look, but this might be best for the cros-infra team.
,
Dec 7 2017
,
Dec 11 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tandrii@chromium.org
, Dec 7 2017