Remove the "full boot from scratch" code from session_manager and Upstart |
||||||
Issue descriptionCurrently, we have two Upstart jobs to start the container (arc-setup.conf and arc-setup-for-login-screen.conf) and session_manager has two code paths in StartArcInstance*() for these two jobs. M64+ Chrome OS uses arc-setup-for-login-screen.conf (+ arc-boot-continue.conf) in most cases, and arc-setup.conf is used only for container crash recovery. For crash recovery, however, we can start a mini container first and upgrade it immediately after that. This might be slower than the current way (arc-setup.conf) but since container crash rarely happens, the penalty seems acceptable. Once it's done, we can remove arc-setup.conf and can simplify session_manager and arc_setup.cc code.
,
Dec 7 2017
Platform team started checking arc-setup.conf's status in two more places: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/811984 (swap.sh) https://chrome-internal-review.googlesource.com/c/chromeos/cheets-scripts/+/522819 (arc-{start,stop}-sysctl.conf) We should never forget to modify them (so filing a bug) when we remove arc-setup.conf.
,
Dec 7 2017
,
Dec 7 2017
,
Apr 10 2018
,
Jul 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/512f0f64702f5a252817ec9224a2a74f86a0bd90 commit 512f0f64702f5a252817ec9224a2a74f86a0bd90 Author: Chris Morin <cmtm@google.com> Date: Sat Jul 14 00:29:03 2018 arc-setup: remove references to nonexistent upstart event arc-setup no longer exists since we're using using the mini-container only boot. BUG= chromium:792703 TEST=ensure arc still boots Change-Id: I5fca1aa73812705847643e8d0cf5cace4b88cd37 Reviewed-on: https://chromium-review.googlesource.com/1135714 Commit-Ready: Christopher Morin <cmtm@google.com> Tested-by: Christopher Morin <cmtm@google.com> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> [modify] https://crrev.com/512f0f64702f5a252817ec9224a2a74f86a0bd90/arc/setup/etc/arc-start-sysctl.conf [modify] https://crrev.com/512f0f64702f5a252817ec9224a2a74f86a0bd90/arc/setup/etc/arc-stop-sysctl.conf
,
Jul 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1e937d6bf6f41160eef932d2c96689720f305b83 commit 1e937d6bf6f41160eef932d2c96689720f305b83 Author: Chris Morin <cmtm@google.com> Date: Sat Jul 14 00:29:12 2018 swap.sh: remove check for nonexistent upstart event arc-setup no longer exists since we're using the mini-container only boot. BUG= chromium:792703 TEST=ensure arc still boots Change-Id: I80e84d74a7f867e86cb073f643dacc5390355a37 Reviewed-on: https://chromium-review.googlesource.com/1135721 Commit-Ready: Christopher Morin <cmtm@google.com> Tested-by: Christopher Morin <cmtm@google.com> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> [modify] https://crrev.com/1e937d6bf6f41160eef932d2c96689720f305b83/chromeos-base/swap-init/files/init/swap.sh [rename] https://crrev.com/1e937d6bf6f41160eef932d2c96689720f305b83/chromeos-base/swap-init/swap-init-0.0.1-r23.ebuild
,
Jul 14
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by yusukes@chromium.org
, Dec 6 2017