Issue metadata
Sign in to add a comment
|
Convert ChromeOS specific cookie accesses to Mojo |
||||||||||||||||||||||
Issue descriptionConvert all instances of access to net::CookieStore over to network::mojom::CookieManager. There are uses of cookie store in the following ChromeOS specific files: chromeos/login/auth chrome/browser/chromeos/login chrome/browser/chromeos/login/saml chrome/browser/chromeos/login/signin
,
Dec 6 2017
,
Feb 16 2018
,
May 29 2018
,
Sep 21
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbe36faad8400b2e92f62bbf6cd4e8c9dd4bcee9 commit dbe36faad8400b2e92f62bbf6cd4e8c9dd4bcee9 Author: Reilly Grant <reillyg@google.com> Date: Wed Oct 03 15:34:08 2018 Express ProfileAuthData::Transfer() in terms of storage partitions With the network service we are deprecating the concept of a net::URLRequestContextGetter. A content::StoragePartition (which owns a network::mojom::NetworkContext) is the right layer of abstraction for expressing what this function operates on. Bug: 792678 Change-Id: I22caa1f85357c2b482f6973365d52bcfa59d02d5 Reviewed-on: https://chromium-review.googlesource.com/c/1257896 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596223} [modify] https://crrev.com/dbe36faad8400b2e92f62bbf6cd4e8c9dd4bcee9/chrome/browser/chromeos/login/profile_auth_data.cc [modify] https://crrev.com/dbe36faad8400b2e92f62bbf6cd4e8c9dd4bcee9/chrome/browser/chromeos/login/profile_auth_data.h [modify] https://crrev.com/dbe36faad8400b2e92f62bbf6cd4e8c9dd4bcee9/chrome/browser/chromeos/login/profile_auth_data_unittest.cc [modify] https://crrev.com/dbe36faad8400b2e92f62bbf6cd4e8c9dd4bcee9/chrome/browser/chromeos/login/session/user_session_manager.cc [modify] https://crrev.com/dbe36faad8400b2e92f62bbf6cd4e8c9dd4bcee9/chrome/browser/chromeos/login/session/user_session_manager.h
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f6cb9c079e42cc127c295582dff8a3982cd73cb commit 8f6cb9c079e42cc127c295582dff8a3982cd73cb Author: Reilly Grant <reillyg@google.com> Date: Thu Oct 04 21:36:23 2018 Migrate ProfileAuthDataTest to network::mojom::CookieManager This change refactors the ProfileAuthDataTests to use the CookieManager interface provided by the Network Service rather than calling the net::CookieStore interface directly. Bug: 792678 Change-Id: Iae3283932b932998dd7acfe1b7006de7a5d0176c Reviewed-on: https://chromium-review.googlesource.com/c/1263039 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596864} [modify] https://crrev.com/8f6cb9c079e42cc127c295582dff8a3982cd73cb/chrome/browser/chromeos/login/profile_auth_data_unittest.cc
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89d25d512786f1fd90ba18ada5b49078d8793cac commit 89d25d512786f1fd90ba18ada5b49078d8793cac Author: Reilly Grant <reillyg@google.com> Date: Thu Oct 04 23:52:40 2018 Refactor ProfileAuthData to use network::mojom::CookieManager This change substancially refactors chromeos::ProfileAuthData so that it uses the CookieManager interface provided by the Network Service rather than calling into net::CookieStore directly. Since the new interface can be called from the UI thread this change breaks apart the work performed by this class into tasks which can each complete on the necessary thread. The ProfileAuthDataTransferer class is made RefCountedDeleteOnSequence so that the completion callback is run on the UI thread after all tasks are complete and the object is destroyed. Bug: 792678 Change-Id: I3378def190191235ae277902e855240b131a1961 Reviewed-on: https://chromium-review.googlesource.com/c/1263054 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#596928} [modify] https://crrev.com/89d25d512786f1fd90ba18ada5b49078d8793cac/chrome/browser/chromeos/login/profile_auth_data.cc
,
Dec 3
,
Dec 7
I'm going to mark this as fixed as I don't see anymore ChromeOS uses of net::CookieStore. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rdsmith@chromium.org
, Dec 6 2017