[Stumpy/Guado] Audio devices are not displaying properly. |
||||||||||||||
Issue descriptionChrome Version: 10176.5.0/64.0.3282.11 OS: chromeOS What steps will reproduce the problem? (1) Sign in to the device. (2) Try to find the audio input and output devices from UI settings. What is the expected result? Audio input and output devices should be displayed properly. What happens instead? Audio devices are not displaying. Note: cras_test_client is showing devices information properly. Attaching screenshots.
,
Dec 6 2017
,
Dec 6 2017
,
Dec 8 2017
,
Dec 8 2017
,
Dec 18 2017
Observed same issue on veyron-jaq that is running on AC adapter (battery does not work on this device) with version 64.0.3282.37/10176.20.0. Video & logs are present here: https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cros/792673/veyron-jaq/?debugUI=CLOUD
,
Jan 4 2018
Can we bisect to isolate where this first occurred? Ping as it's a stable blocker.
,
Jan 4 2018
+jennyz
,
Jan 4 2018
jennyz@ can you look into this?
,
Jan 20 2018
Ping for any update on this stable blocker?
,
Jan 29 2018
Pinged owner on IM; need to triage / fix as M64 RBS
,
Jan 29 2018
This is a duplicate of the bug: https://buganizer.corp.google.com/issues/69069722 I am currently working on it. It is much easier to repro on fizz device. It is a UI regression issue introduced into build 64-10066.0.0.
,
Jan 30 2018
Is this limited to GFM then? Note that b/69069722 is blocking M65, not M64. Should we do similar here?
,
Jan 31 2018
,
Feb 7 2018
Issue 782986 has been merged into this issue.
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adce5ebaf1dc580124c81163ecc57be3aaab6f33 commit adce5ebaf1dc580124c81163ecc57be3aaab6f33 Author: Jenny Zhang <jennyz@chromium.org> Date: Thu Feb 08 18:15:18 2018 Ensure the system tray detailed bubble open correctly on all devices. System tray detail bubble is not opened correctly on some devices like fizz, stumpy, guado, etc. The root cause is that the bubble_view_ of the SystemTrayBubble is skipped for doing the relayout after |system_tray_view_| has created items. This issue was introduced with the refatoring rev#511080. https://chromium.googlesource.com/chromium/src/+/5507006ab8a796d105dc69b676bdd34e50c17ea5 Fixed it by enforcing the |bubble_view_| to relayout. On devices with problem, |bubble_view_| is skipped for relayout since its bounds does not change. Bug: 792673 Change-Id: I25c58c7fc4a48e3fabdee383baf15637de14a2cb Reviewed-on: https://chromium-review.googlesource.com/907181 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#535444} [modify] https://crrev.com/adce5ebaf1dc580124c81163ecc57be3aaab6f33/ash/system/tray/system_tray_bubble.cc
,
Feb 8 2018
The fix has been landed in Tot, needs to be merged back to R65 and R64.
,
Feb 8 2018
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 8 2018
Per #14, b/69069722 tagged this as a blocker for M64, not M65. I'll need reasoning as to why this is required for M64 now that we're in stable.
,
Feb 8 2018
+bhthompson for M65
,
Feb 8 2018
,
Feb 8 2018
This is pretty bad UI bug. On fizz, stumpy and guado devices, user won't be able to open the system tray detail bubble to see the device list on network, keyboard, bluetooth, and audio. See the screen shot in #1.
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8ebd4ffb9ebfae0019a04cdfda54894a7a506bd commit f8ebd4ffb9ebfae0019a04cdfda54894a7a506bd Author: Jenny Zhang <jennyz@chromium.org> Date: Thu Feb 08 19:22:09 2018 Ensure the system tray detailed bubble open correctly on all devices. System tray detail bubble is not opened correctly on some devices like fizz, stumpy, guado, etc. The root cause is that the bubble_view_ of the SystemTrayBubble is skipped for doing the relayout after |system_tray_view_| has created items. This issue was introduced with the refatoring rev#511080. https://chromium.googlesource.com/chromium/src/+/5507006ab8a796d105dc69b676bdd34e50c17ea5 Fixed it by enforcing the |bubble_view_| to relayout. On devices with problem, |bubble_view_| is skipped for relayout since its bounds does not change. Bug: 792673 Change-Id: I25c58c7fc4a48e3fabdee383baf15637de14a2cb Reviewed-on: https://chromium-review.googlesource.com/907181 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#535444}(cherry picked from commit adce5ebaf1dc580124c81163ecc57be3aaab6f33) Reviewed-on: https://chromium-review.googlesource.com/909528 Reviewed-by: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#384} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/f8ebd4ffb9ebfae0019a04cdfda54894a7a506bd/ash/system/tray/system_tray_bubble.cc
,
Feb 8 2018
Per #22, I asked about the M64 impact some time ago since the underlying b/69069722 is blocking M65 (Jan 31, #13). I'll need assurance that this has been tested and limited in scope to the 3 boards referenced. Is https://chromium-review.googlesource.com/907181 the only change? Looks like it's limited to the call to bubble_view_->InvalidateLayout();?
,
Feb 8 2018
Per 24#, yes, this is the only change: https://chromium-review.googlesource.com/907181.
,
Feb 8 2018
Thanks Jenny. Do we have data / thoughts re: risk?
,
Feb 8 2018
I think the risk is quite low. The fix just enforce the UI layout to happen, which is what the original code meant to do, but were skipped on some devices.
,
Feb 8 2018
This issue typically happens to fizz/stumpy devices which has no internal display, but use external hdmi display. If there are not a lot users affected, then I am ok to leave R64 alone.
,
Feb 8 2018
Observed the same behavior on Tricky with version : Google Chrome - 65.0.3325.59 (Official Build) dev (64-bit) Platform - 10323.24.0 (Official Build) dev-channel tricky
,
Feb 9 2018
The issue has been fixed on Tot and R65. I will mark it as fixed. If we decide to port it back to R64, please let me know.
,
Feb 13 2018
Verified, issue can fix in Rikku R65-10323.29.0.
,
Mar 2 2018
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by sontis@chromium.org
, Dec 6 2017