New issue
Advanced search Search tips

Issue 792672 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-Servicification

Blocking:
issue 721395



Sign in to add a comment

Convert Android-specific cookie accesses to Mojo

Project Member Reported by rdsmith@chromium.org, Dec 6 2017

Issue description

Convert all instances of access to net::CookieStore over to network::mojom::CookieManager. 

There are uses of cookie store in the following android-specific files:

	content/browser/media/android
	chrome/browser/android/cookies
	chrome/browser/android/download
	chrome/browser/android/profiles

 
Blocking: 721395
Hi,
If issue is available for grab, I'd like to work on it.
Thanks!
Sure, go for it.

Ok! I've added a patch. Whenever you find time, please have a look.
Thanks!

Review URL: https://chromium-review.googlesource.com/c/chromium/src/+/903307

Cc: -rdsmith@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff860c7fb791d30e1532c061471732088e556cc0

commit ff860c7fb791d30e1532c061471732088e556cc0
Author: Pritam <pritam.nikam@samsung.com>
Date: Wed Feb 28 17:18:07 2018

Converts Android-specific cookie accesses to Mojo.

Converts all instances of access to net::CookieStore over to
network::mojom::CookieManager.

Addressed the uses of cookie store in the following android-specific files:
  - chrome/browser/android/cookies
  - chrome/browser/android/profiles

Bug:  792672 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Icdbacc17b7bee4cf191994fda3639865cbf31b01
Reviewed-on: https://chromium-review.googlesource.com/903307
Commit-Queue: Pritam Nikam <pritam.nikam@samsung.com>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539857}
[modify] https://crrev.com/ff860c7fb791d30e1532c061471732088e556cc0/chrome/browser/android/cookies/cookies_fetcher.cc
[modify] https://crrev.com/ff860c7fb791d30e1532c061471732088e556cc0/chrome/browser/android/cookies/cookies_fetcher.h
[modify] https://crrev.com/ff860c7fb791d30e1532c061471732088e556cc0/chrome/browser/android/profiles/profile_manager_utils.cc
[modify] https://crrev.com/ff860c7fb791d30e1532c061471732088e556cc0/services/network/cookie_manager.cc
[modify] https://crrev.com/ff860c7fb791d30e1532c061471732088e556cc0/services/network/cookie_manager.h
[modify] https://crrev.com/ff860c7fb791d30e1532c061471732088e556cc0/services/network/public/mojom/cookie_manager.mojom

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8354cf7075aeae527bae0ffd9583d14176af5c2c

commit 8354cf7075aeae527bae0ffd9583d14176af5c2c
Author: Pritam <pritam.nikam@samsung.com>
Date: Sat Mar 10 08:55:41 2018

Added tests for FlushCookieStore API.

At present, tests for newly added mojom API #FlushCookieStore are missing.
With this patch new unittest is added. This is a follow-up CL to #903307.

BUG= 792672 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I1f4e0b2a989207c09a4bd0c81015d4d4dbce5cde
Reviewed-on: https://chromium-review.googlesource.com/948802
Commit-Queue: Pritam Nikam <pritam.nikam@samsung.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542367}
[modify] https://crrev.com/8354cf7075aeae527bae0ffd9583d14176af5c2c/net/cookies/cookie_monster.cc
[modify] https://crrev.com/8354cf7075aeae527bae0ffd9583d14176af5c2c/net/cookies/cookie_monster.h
[modify] https://crrev.com/8354cf7075aeae527bae0ffd9583d14176af5c2c/net/cookies/cookie_monster_unittest.cc
[modify] https://crrev.com/8354cf7075aeae527bae0ffd9583d14176af5c2c/net/cookies/cookie_store_test_helpers.cc
[modify] https://crrev.com/8354cf7075aeae527bae0ffd9583d14176af5c2c/net/cookies/cookie_store_test_helpers.h
[modify] https://crrev.com/8354cf7075aeae527bae0ffd9583d14176af5c2c/services/network/cookie_manager_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c55c06c517d56afa498d3757e24c20604f9a1bd1

commit c55c06c517d56afa498d3757e24c20604f9a1bd1
Author: Pritam <pritam.nikam@samsung.com>
Date: Thu Mar 15 03:25:59 2018

Converts Android-specific cookie accesses to Mojo.

Converts all instances of access to net::CookieStore over to
network::mojom::CookieManager.

Addressed the uses of cookie store in the following android-specific files:
  - content/browser/media/android

This is a follow-up CL to #903307.

Bug:  792672 
Change-Id: Ifb5ee30dfb746e66aa4c06674abb8e9e22ec1d1b
Reviewed-on: https://chromium-review.googlesource.com/952954
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Pritam Nikam <pritam.nikam@samsung.com>
Cr-Commit-Position: refs/heads/master@{#543297}
[modify] https://crrev.com/c55c06c517d56afa498d3757e24c20604f9a1bd1/content/browser/media/android/media_resource_getter_impl.cc
[modify] https://crrev.com/c55c06c517d56afa498d3757e24c20604f9a1bd1/content/browser/media/android/media_resource_getter_impl.h

All patches required to address this bug are already landed (except under 'download', and will be addressed separately [1]). We can safely move this bug state as 'fixed'.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/903307#message-130690b43816ff5b7ca71f83c4d79f7636dd0783

Thanks!

Comment 10 by dxie@chromium.org, May 17 2018

Labels: -Pri-3 Proj-Servicification-Canary Pri-1

Comment 11 by dxie@google.com, Jun 7 2018

Labels: Hotlist-KnownIssue
Status: Fixed (was: Available)

Sign in to add a comment