Issue metadata
Sign in to add a comment
|
Convert renderer cookie access over to Mojo |
||||||||||||||||||||||||
Issue descriptionThis involves implementing security checks on the RestrictedCookieManager implementation, pushing an instance of that interface to the renderer upon creation, and making the renderer use it in preference to IPC. The implementation has several tricky bits; see https://docs.google.com/document/d/1s1vL8hNDPvOhssgsp8HjgL9yKZMzwo50yY5Hy8X6iE4/edit#heading=h.m4ffbgqsx4f9 It is related to the switching of accesses to the Extensions URLRequestContext ( issue 792651 ) as extension background pages will be accessing cookies in the Extensions URLRequestContext.
,
Feb 17 2018
,
May 17 2018
I'm not sure there's anything left to do here? Extensions code uses a cookie store that lives int he browser process, since network process doesn't know about extensions scheme. I converted this a while ago. Victor: please reopen if you think there's anything I'm missing.
,
May 17 2018
Sadly, I don't think we're done here. This issue appears to be about the renderer process. jsbell@ is currently putting together https://crrev.com/c/1062732 to have document.cookie use RestrictedCookieManager instead of RenderFrameMessageFilter. I'm looking at what needs to be done to make RestrictedCookieManager actually be restricted, so we can make it available without the Experimental Web Platform flag. jam@: If I'm misunderstanding something, let's discuss.
,
May 22 2018
The renderer process, with or without the network service, does mojo calls to the browser which does the security checks. See RenderFrameMessageFilter::SetCookie https://cs.chromium.org/chromium/src/content/browser/frame_host/render_frame_message_filter.cc?rcl=5e64c59cc7704c25c81311b5ec2c78ddb5ca9af9&l=491 so I think there's nothing else to do. Sending the restricted cookie manager to the renderer seems orthogonal (as that'll be used with or without the network service).
,
May 22 2018
jam@: Thank you for explaining this to me in an offline conversation! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by rdsmith@chromium.org
, Dec 6 2017