New issue
Advanced search Search tips

Issue 792666 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 721395



Sign in to add a comment

Convert renderer cookie access over to Mojo

Project Member Reported by rdsmith@chromium.org, Dec 6 2017

Issue description

This involves implementing security checks on the RestrictedCookieManager implementation, pushing an instance of that interface to the renderer upon creation, and making the renderer use it in preference to IPC.

The implementation has several tricky bits; see https://docs.google.com/document/d/1s1vL8hNDPvOhssgsp8HjgL9yKZMzwo50yY5Hy8X6iE4/edit#heading=h.m4ffbgqsx4f9

It is related to the switching of accesses to the Extensions URLRequestContext ( issue 792651 ) as extension background pages will be accessing cookies in the Extensions URLRequestContext.
 
Blocking: 721395
Cc: -rdsmith@chromium.org

Comment 3 by jam@chromium.org, May 17 2018

Status: Fixed (was: Assigned)
I'm not sure there's anything left to do here?

Extensions code uses a cookie store that lives int he browser process, since network process doesn't know about extensions scheme. I converted this a while ago.

Victor: please reopen if you think there's anything I'm missing.

Comment 4 by pwnall@chromium.org, May 17 2018

Cc: jam@chromium.org jsb...@chromium.org
Status: Assigned (was: Fixed)
Sadly, I don't think we're done here.

This issue appears to be about the renderer process. jsbell@ is currently putting together https://crrev.com/c/1062732 to have document.cookie use RestrictedCookieManager instead of RenderFrameMessageFilter. I'm looking at what needs to be done to make RestrictedCookieManager actually be restricted, so we can make it available without the Experimental Web Platform flag.

jam@: If I'm misunderstanding something, let's discuss.

Comment 5 by jam@chromium.org, May 22 2018

The renderer process, with or without the network service, does mojo calls to the browser which does the security checks.

See RenderFrameMessageFilter::SetCookie
https://cs.chromium.org/chromium/src/content/browser/frame_host/render_frame_message_filter.cc?rcl=5e64c59cc7704c25c81311b5ec2c78ddb5ca9af9&l=491

so I think there's nothing else to do. Sending the restricted cookie manager to the renderer seems orthogonal (as that'll be used with or without the network service).

Comment 6 by pwnall@chromium.org, May 22 2018

Status: Fixed (was: Assigned)
jam@: Thank you for explaining this to me in an offline conversation!

Sign in to add a comment