New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792664 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 711307
issue 776804



Sign in to add a comment

dev-python/numpy needs to be upgraded on ChromeOS

Project Member Reported by cmt...@chromium.org, Dec 6 2017

Issue description

The telemetry tests inside Chrome have recently changed their requirements.  They now require at least numpy version 1.8.0.  The current ChromeOS version is 1.7.1.  This needs to be upgraded.
 
Please note that, at the moment, it also needs to be strictly earlier than 1.12.0, which had a few breaking changes.
Blockedon: 711307
Components: Infra>Client>ChromeOS
This issue has no component, so it's unlikely to be seen. Setting Infra>Client>ChromeOS but I'm not 100% certain this is correct.

Also, the Telemetry change that changed this was 7 months ago. Did this problem only just start?
Cc: perezju@chromium.org achuith@chromium.org kainino@chromium.org
There's a warning:
WARNING:root:Unable to import numpy due to: Incorrect numpy version found, expected 1.8.0 <= version < 1.12.0, found version 1.7.1

It's not clear what if anything is actually failing. 

I also don't think Infra is the right component, but not sure what is.
Oh yes, of course, since these are optional dependencies (gives large performance boost). Is it really P1, then?
Autotest trips over the warning and dies with a failure

18:28:45 INFO | autoserv| Telemetry completed with exit code: 0.
18:28:45 INFO | autoserv| stdout:[ RUN      ] http://chromium.github.io/octane/index.html?auto=1
18:28:45 INFO | autoserv| [       OK ] http://chromium.github.io/octane/index.html?auto=1 (64332 ms)
18:28:45 INFO | autoserv| [  PASSED  ] 1 test.
18:28:45 INFO | autoserv| 
18:28:45 INFO | autoserv| View result at file:///usr/local/telemetry/src/tools/perf/results-chart.json
18:28:45 INFO | autoserv| 
18:28:45 INFO | autoserv| stderr:/home/cmtice/.ssh/config line 20: Unsupported option "rsaauthentication"
18:28:45 INFO | autoserv| /home/cmtice/.ssh/config line 71: Unsupported option "rsaauthentication"
18:28:45 INFO | autoserv| WARNING:root:Unable to import numpy due to: Incorrect numpy version found, expected 1.8.0 <= version < 1.12.0, found version 1.7.1
18:28:45 INFO | autoserv| WARNING:root:Unable to import numpy due to: Incorrect numpy version found, expected 1.8.0 <= version < 1.12.0, found version 1.7.1
18:28:45 INFO | autoserv| 
18:28:45 INFO | autoserv| The test failed with the following exception
18:28:45 INFO | autoserv| Traceback (most recent call last):
18:28:45 INFO | autoserv| File "/mnt/host/source/src/third_party/autotest/files/client/common_lib/test.py", line 631, in _exec
18:28:45 INFO | autoserv| _call_test_function(self.execute, *p_args, **p_dargs)
18:28:45 INFO | autoserv| File "/mnt/host/source/src/third_party/autotest/files/client/common_lib/test.py", line 837, in _call_test_function
18:28:45 INFO | autoserv| raise error.UnhandledTestFail(e)
18:28:45 INFO | autoserv| UnhandledTestFail: Unhandled AttributeError: 'module' object has no attribute 'DUT_SCP_OPTIONS'
18:28:45 INFO | autoserv| Traceback (most recent call last):
18:28:45 INFO | autoserv| File "/mnt/host/source/src/third_party/autotest/files/client/common_lib/test.py", line 831, in _call_test_function
18:28:45 INFO | autoserv| return func(*args, **dargs)
18:28:45 INFO | autoserv| File "/mnt/host/source/src/third_party/autotest/files/client/common_lib/test.py", line 495, in execute
18:28:45 INFO | autoserv| dargs)
18:28:45 INFO | autoserv| File "/mnt/host/source/src/third_party/autotest/files/client/common_lib/test.py", line 362, in _call_run_once_with_retry
18:28:45 INFO | autoserv| postprocess_profiled_run, args, dargs)
18:28:45 INFO | autoserv| File "/mnt/host/source/src/third_party/autotest/files/client/common_lib/test.py", line 400, in _call_run_once
18:28:45 INFO | autoserv| self.run_once(*args, **dargs)
18:28:45 INFO | autoserv| File "/mnt/host/source/src/third_party/autotest/files/server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py", line 198, in run_once
18:28:45 INFO | autoserv| result = self.scp_telemetry_results(client_ip, dut)
18:28:45 INFO | autoserv| File "/mnt/host/source/src/third_party/autotest/files/server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py", line 116, in scp_telemetry_results
18:28:45 INFO | autoserv| cmd.extend(['scp', telemetry_runner.DUT_SCP_OPTIONS, RSA_KEY, '-v',
18:28:45 INFO | autoserv| AttributeError: 'module' object has no attribute 'DUT_SCP_OPTIONS'
18:28:45 INFO | autoserv| 
18:28:45 INFO | autoserv| FAIL	telemetry_Crosperf	telemetry_Crosperf	timestamp=1512606525	localtime=Dec 06 18:28:45	Unhandled AttributeError: 'module' object has no attribute 'DUT_SCP_OPTIONS'
18:28:45 INFO | autoserv| Traceback (most recent call last):
18:28:45 INFO | autoserv| File "/mnt/host/source/src/third_party/autotest/files/client/common_lib/test.py", line 831, in _call_test_function
18:28:45 INFO | autoserv| return func(*args, **dargs)
18:28:45 INFO | autoserv| File "/mnt/host/source/src/third_party/autotest/files/client/common_lib/test.py", line 495, in execute
18:28:45 INFO | autoserv| dargs)
18:28:45 INFO | autoserv| File "/mnt/host/source/src/third_party/autotest/files/client/common_lib/test.py", line 362, in _call_run_once_with_retry
18:28:45 INFO | autoserv| postprocess_profiled_run, args, dargs)
18:28:45 INFO | autoserv| File "/mnt/host/source/src/third_party/autotest/files/client/common_lib/test.py", line 400, in _call_run_once
18:28:45 INFO | autoserv| self.run_once(*args, **dargs)
18:28:45 INFO | autoserv| File "/mnt/host/source/src/third_party/autotest/files/server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py", line 198, in run_once
18:28:45 INFO | autoserv| result = self.scp_telemetry_results(client_ip, dut)
18:28:45 INFO | autoserv| File "/mnt/host/source/src/third_party/autotest/files/server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py", line 116, in scp_telemetry_results
18:28:45 INFO | autoserv| cmd.extend(['scp', telemetry_runner.DUT_SCP_OPTIONS, RSA_KEY, '-v',
18:28:45 INFO | autoserv| AttributeError: 'module' object has no attribute 'DUT_SCP_OPTIONS'
18:28:45 INFO | autoserv| END FAIL	telemetry_Crosperf	telemetry_Crosperf	timestamp=1512606525	localtime=Dec 06 18:28:45
18:28:45 INFO | autoserv| Finished processing control file
18:28:45 INFO | autoserv| Skipping crash dump/info collection as requested.
18:28:46 INFO | autoserv| [stderr] /home/cmtice/.ssh/config line 20: Unsupported option "rsaauthentication"
18:28:46 INFO | autoserv| [stderr] /home/cmtice/.ssh/config line 71: Unsupported option "rsaauthentication"
18:28:46 INFO | autoserv| [stderr] /home/cmtice/.ssh/config line 20: Unsupported option "rsaauthentication"
18:28:46 INFO | autoserv| [stderr] /home/cmtice/.ssh/config line 71: Unsupported option "rsaauthentication"
18:28:47 INFO | autoserv| get_network_stats: at-end RXbytes 25355046 TXbytes 1347950
18:28:48 INFO | autoserv| record_state_duration failed: job_or_task_id=None, hostname=chromeos2-row9-rack9-host9.cros, status=Running
-----------------------------------------------------------------------------------------
/tmp/test_that_results_J6RGCs/results-1-telemetry_Crosperf                    [  FAILED  ]
/tmp/test_that_results_J6RGCs/results-1-telemetry_Crosperf                      FAIL: Unhandled AttributeError: 'module' object has no attribute 'DUT_SCP_OPTIONS'
/tmp/test_that_results_J6RGCs/results-1-telemetry_Crosperf/telemetry_Crosperf [  FAILED  ]
/tmp/test_that_results_J6RGCs/results-1-telemetry_Crosperf/telemetry_Crosperf   FAIL: Unhandled AttributeError: 'module' object has no attribute 'DUT_SCP_OPTIONS'
-----------------------------------------------------------------------------------------
Total PASS: 0/2 (0%)

wait, I think that's a different problem...

Yes, that was caused by a different code change in autotest. But the numpy version should still be upgraded.  I am working on a CL for this at the moment.
Labels: -Pri-1 Pri-3
dropping to P-3. I've seen the rsaauthentication failure and it's unrelated.
Cc: kbr@chromium.org
Hey, please do sync with +kbr and see  issue 776804 , since we're trying to move away from having Telemetry download binaries for these modules and have them provided by infra (through vpython) instead.

Comment 10 by kbr@chromium.org, Dec 7 2017

Blockedon: 776804
Obviously we need to get things working on ChromeOS again, so if you have a small patch to these version numbers which makes things run, please post it.

We aim to get rid of our custom binaries for numpy and cv2 in  Issue 776804 . Linking to that bug though we can reverse the blocked on/blocking relationship.

Summary: dev-python/numpy needs to be upgraded on ChromeOS (was: dev-python/numpy needs to be upgraded)
https://chromium-review.googlesource.com/c/chromiumos/overlays/portage-stable/+/812159

Patch is currently under review; should hopefully go in by the end of today.
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/51af82ea93ba370548b9b975aee1754dfd337252

commit 51af82ea93ba370548b9b975aee1754dfd337252
Author: Caroline Tice <cmtice@google.com>
Date: Sun Dec 10 04:32:29 2017

numpy: upgraded package to upstream

Upgraded dev-python/numpy to version 1.10.4 on amd64, x86 AND version 1.9.2 on arm, arm64

BUG= chromium:792664 
TEST=Successfully tested with trybots for kevin-release, daisy-release, and
lumpy release.  Built tryjob images, then used images to run Telemetry tests
on DUTS.  Warnings went away.

Change-Id: Id935535457bd230d66d22f0ca032e575be1b56be
Reviewed-on: https://chromium-review.googlesource.com/812159
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/39f333bb48cb60b2f2252cf17b47b76fc5c39c3e/dev-python/numpy/files/numpy-1.6.2-distutils.patch
[add] https://crrev.com/51af82ea93ba370548b9b975aee1754dfd337252/dev-python/numpy/files/numpy-1.9.2-no-hardcode-blas.patch
[delete] https://crrev.com/39f333bb48cb60b2f2252cf17b47b76fc5c39c3e/dev-python/numpy/files/numpy-1.8.0-no-hardcode-blas.patch
[modify] https://crrev.com/51af82ea93ba370548b9b975aee1754dfd337252/dev-python/numpy/metadata.xml
[delete] https://crrev.com/39f333bb48cb60b2f2252cf17b47b76fc5c39c3e/dev-python/numpy/files/numpy-1.7.0-atlas.patch
[modify] https://crrev.com/51af82ea93ba370548b9b975aee1754dfd337252/dev-python/numpy/Manifest
[add] https://crrev.com/51af82ea93ba370548b9b975aee1754dfd337252/metadata/md5-cache/dev-python/numpy-1.9.2
[delete] https://crrev.com/39f333bb48cb60b2f2252cf17b47b76fc5c39c3e/dev-python/numpy/files/numpy-1.6.2-test-pareto.patch
[delete] https://crrev.com/39f333bb48cb60b2f2252cf17b47b76fc5c39c3e/dev-python/numpy/files/numpy-1.7.1-distutils-python33.patch
[delete] https://crrev.com/39f333bb48cb60b2f2252cf17b47b76fc5c39c3e/metadata/md5-cache/dev-python/numpy-1.7.1
[rename] https://crrev.com/51af82ea93ba370548b9b975aee1754dfd337252/dev-python/numpy/numpy-1.9.2.ebuild
[delete] https://crrev.com/39f333bb48cb60b2f2252cf17b47b76fc5c39c3e/dev-python/numpy/files/numpy-1.6.1-atlas.patch

Labels: -Pri-3 Pri-2
Status: Fixed (was: Untriaged)
Assuming this is now fixed. Thanks Caroline!
Components: -Infra>Client>ChromeOS
Status: Verified (was: Fixed)

Sign in to add a comment