Migrate LoginDisplayHostWebUI into LoginDisplayHost LoginDisplayHostWebUI has a lot of non-webui functionality. It should be moved into LoginDisplayHost so it can be shared with LoginDisplayHostViews.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcc96e391a7d57deb3beda5509f132dcc3748666 commit dcc96e391a7d57deb3beda5509f132dcc3748666 Author: Jacob Dufault <jdufault@google.com> Date: Wed Dec 20 17:48:27 2017 cros: Move app launching from LoginDisplayHostWebUI to LoginDisplayHost. Bug: 792654 Change-Id: Icf7419c14f4a32d1c168e40060e495c7581bc0de Reviewed-on: https://chromium-review.googlesource.com/812152 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#525365} [modify] https://crrev.com/dcc96e391a7d57deb3beda5509f132dcc3748666/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc [modify] https://crrev.com/dcc96e391a7d57deb3beda5509f132dcc3748666/chrome/browser/chromeos/login/login_browsertest.cc [modify] https://crrev.com/dcc96e391a7d57deb3beda5509f132dcc3748666/chrome/browser/chromeos/login/ui/login_display_host.cc [modify] https://crrev.com/dcc96e391a7d57deb3beda5509f132dcc3748666/chrome/browser/chromeos/login/ui/login_display_host.h [modify] https://crrev.com/dcc96e391a7d57deb3beda5509f132dcc3748666/chrome/browser/chromeos/login/ui/login_display_host_views.cc [modify] https://crrev.com/dcc96e391a7d57deb3beda5509f132dcc3748666/chrome/browser/chromeos/login/ui/login_display_host_views.h [modify] https://crrev.com/dcc96e391a7d57deb3beda5509f132dcc3748666/chrome/browser/chromeos/login/ui/login_display_host_webui.cc [modify] https://crrev.com/dcc96e391a7d57deb3beda5509f132dcc3748666/chrome/browser/chromeos/login/ui/login_display_host_webui.h [modify] https://crrev.com/dcc96e391a7d57deb3beda5509f132dcc3748666/chrome/browser/chromeos/login/ui/mock_login_display_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73671d45c6cb8e4188ab727e5a30b77342016359 commit 73671d45c6cb8e4188ab727e5a30b77342016359 Author: Jacob Dufault <jdufault@google.com> Date: Thu Jan 04 17:35:01 2018 cros: Rename startup_sound_played_ to oobe_startup_sound_played_ I spent some time porting this to LoginDisplayHost only to later realize it only applies to oobe. Make that very clear/explicit it is oobe-only. Bug: 792654 Change-Id: I152b9399188cbd62451be2e6044620a30fc6f1e3 Reviewed-on: https://chromium-review.googlesource.com/824954 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#527024} [modify] https://crrev.com/73671d45c6cb8e4188ab727e5a30b77342016359/chrome/browser/chromeos/login/ui/login_display_host_webui.cc [modify] https://crrev.com/73671d45c6cb8e4188ab727e5a30b77342016359/chrome/browser/chromeos/login/ui/login_display_host_webui.h
Comment 1 by jdufault@chromium.org
, Dec 6 2017