New issue
Advanced search Search tips

Issue 792642 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Use messaging framework in form.js when it's implemented.

Project Member Reported by dvadym@chromium.org, Dec 6 2017 
For support of cross-origin iframes in Autofill and Password Manager messaging framework should be implemented. Details are in go/bling-iframe-injection.

form.js implements form/input event handlers. Now injected functions from the main frame are called in form.js. It works for iframes with the same origin as the main frame, but it wouldn't work for cross-origin iframes. When messaging framework is implemented, sending messages should be implemented for cross-origin support.

Comment 1 by ma...@chromium.org, May 1 2018

Status: Untriaged (was: Available)

Comment 2 by dvadym@chromium.org, May 7 2018

Status: Available (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd

commit d0e0bace88bc7fe8bffaa27d1572bb7020b847dd
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Fri Sep 21 15:39:25 2018

Implement Autofill in iframe

- Known bugs: navigation buttons do not work in iframes.
- Payment Request is only enabled in main frame.
- This CL does not enable autofill in iFrame by default.

Bug:  881364 , 792642
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia18b8a0543d0c754a22d3ee9287171f6807f5f5c
Reviewed-on: https://chromium-review.googlesource.com/1233575
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593196}
[modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/components/autofill/ios/browser/autofill_agent.mm
[modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/components/autofill/ios/browser/autofill_driver_ios.h
[modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/components/autofill/ios/browser/autofill_util.h
[modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/components/autofill/ios/browser/autofill_util.mm
[modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/components/autofill/ios/form_util/resources/form.js
[modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/components/password_manager/ios/password_controller_helper.mm
[modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/ios/chrome/browser/autofill/form_structure_browsertest.mm
[modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/ios/web/public/test/fakes/fake_web_frame.cc
[modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/ios/web/web_state/js/resources/message.js
[modify] https://crrev.com/d0e0bace88bc7fe8bffaa27d1572bb7020b847dd/ios/web_view/test/web_view_autofill_inttest.mm
►

Sign in to add a comment