Thanks for all of these! I'll do a big triage of  Issue 671916  blockers when the current phase is complete. See go/macviewstracking

[Bulk Edit]
Applying M-68 milestone per email discussion with ellyjones@. Pls change it if milestone is incorrectly applied. 

MacViews triage: let's target this at M-68.

** Bulk Edit **

FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31adef92e414f5855cd9def5d176968af4c5c587

commit 31adef92e414f5855cd9def5d176968af4c5c587
Author: Leonard Grey <lgrey@chromium.org>
Date: Mon Apr 16 18:10:45 2018

MacView: Use system icons for bookmark bar folders

Cocoa browser's logic for deciding whether to use the light (dark mode)
or regular icon requires converting the theme frame color to an NSColor
in NSCalibratedWhiteColorSpace and checking against an empirical
threshold.

To keep things in Views-land and maintain the same interface, this
change uses the light icon iff color_utils::IsDark returns false
for the given text color.

In practice, I will venture that anywhere this disagrees with Cocoa
is a borderline case anyway.

Bug:  792610 
Change-Id: I57b1c0cb90cf06fce4a8a3f31806dedd86791ebc
Reviewed-on: https://chromium-review.googlesource.com/1012966
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551037}
[modify] https://crrev.com/31adef92e414f5855cd9def5d176968af4c5c587/chrome/browser/ui/bookmarks/bookmark_utils.cc
[modify] https://crrev.com/31adef92e414f5855cd9def5d176968af4c5c587/chrome/browser/ui/bookmarks/bookmark_utils.h

Able to reproduce this issue on Mac OS 10.12.6 on the build without fix 67.0.3396.0 and the issue is fixed on the latest Canary 68.0.3398.0.

By enabling #views-browser-windows flag, can observe that the bookmarks bar is showing the correct bookmarks folder icons.
Attached is the screen shot for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..

Deleted: 792610-M68.png 98.8 KB

	792610-M68.png 98.8 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31adef92e414f5855cd9def5d176968af4c5c587

commit 31adef92e414f5855cd9def5d176968af4c5c587
Author: Leonard Grey <lgrey@chromium.org>
Date: Mon Apr 16 18:10:45 2018

MacView: Use system icons for bookmark bar folders

Cocoa browser's logic for deciding whether to use the light (dark mode)
or regular icon requires converting the theme frame color to an NSColor
in NSCalibratedWhiteColorSpace and checking against an empirical
threshold.

To keep things in Views-land and maintain the same interface, this
change uses the light icon iff color_utils::IsDark returns false
for the given text color.

In practice, I will venture that anywhere this disagrees with Cocoa
is a borderline case anyway.

Bug:  792610 
Change-Id: I57b1c0cb90cf06fce4a8a3f31806dedd86791ebc
Reviewed-on: https://chromium-review.googlesource.com/1012966
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551037}
[modify] https://crrev.com/31adef92e414f5855cd9def5d176968af4c5c587/chrome/browser/ui/bookmarks/bookmark_utils.cc
[modify] https://crrev.com/31adef92e414f5855cd9def5d176968af4c5c587/chrome/browser/ui/bookmarks/bookmark_utils.h