New issue
Advanced search Search tips

Issue 792608 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 671916



Sign in to add a comment

[macViewsBrowser] Top chrome not redrawn after theme change

Project Member Reported by shrike@chromium.org, Dec 6 2017

Issue description

Chrome Version: 65.0.3287.0
OS: macOS 10.12

What steps will reproduce the problem?
(1) Install a theme from the store, such as https://chrome.google.com/webstore/detail/galaxy-view/dcbeddldohkakodfncjnkkjfojggbahp?hl=en

What is the expected result?
The toolbar and bookmarks bar should be redrawn based on the new theme setting

What happens instead?
The toolbar and menu bar retain their previous appearance. Mousing over a toolbar or bookmarks bar item causes it to redraw, although it doesn't force toolbar items to draw with their new title text color (you have to click on the tab to get that to happen)

 
Screen Shot 2017-12-06 at 12.26.17 PM.png
279 KB View Download
Blocking: 671916
Labels: Pri-2
Status: Available (was: Untriaged)
Thanks for all of these! I'll do a big triage of  Issue 671916  blockers when the current phase is complete. See go/macviewstracking
Labels: M-68
[Bulk Edit]
Applying M-68 milestone per email discussion with ellyjones@. Pls change it if milestone is incorrectly applied. 
Labels: -M-68 Target-68
Owner: sdy@chromium.org
Status: Assigned (was: Available)
MacViews triage: Just tried this - the toolbar does redraw, but the bookmarks bar does not and the tab strip does not. Targeting for M-68 for sdy :)

Comment 4 by gov...@chromium.org, Mar 27 2018

Labels: M-68

Comment 5 by gov...@chromium.org, Mar 29 2018

** Bulk Edit **

FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.

Comment 6 by sdy@chromium.org, Apr 16 2018

Labels: Sprint-1

Comment 7 by sdy@chromium.org, Apr 23 2018

Owner: lgrey@chromium.org
lgrey@: Is this fixed by your theme work? If not, feel free to kick it back to me.

Comment 8 by lgrey@chromium.org, Apr 23 2018

Status: Fixed (was: Assigned)
Yup!
Labels: Needs-Feedback
Tried checking the issue on reported chrome version 65.0.3287.0 using Mac 10.12.6 by installing the theme given in comment#0.
We are able to see the appearance of the installed theme in tab strip and bookmark bar without being hovering mouse on them i.e., Issue is not reproducible from our end on reported version. Attaching the screen cast of the same.

lgrey@ : Could you please have a look at the screen cast and let us know if anything missed from our end. please help us in verifying the fix.

Thanks!
792608 CL.mp4
1.3 MB View Download
vamshi.kommuri@ this issue was for Canary with #views-browser-windows enabled

Sign in to add a comment