New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792607 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 762559



Sign in to add a comment

Add createImageBitmap resize tests for all filter qualities

Project Member Reported by zakerinasab@chromium.org, Dec 6 2017

Issue description

The current createImageBitmap resize tests only test high filter quality. Modify the tests to also examine pixelated, low and medium resize qualities.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4c244a31ad974ffd8b62ac92f78154bf3136dff

commit d4c244a31ad974ffd8b62ac92f78154bf3136dff
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Wed Dec 06 21:44:59 2017

Refactor createImageBitmap resize layout tests

This change reduces createImageBitmap resize test tolerance from 10 to 0
for all image sources except for blob (which is set to 5).
It also refactors the tests to include pixelated, low and medium filter
qualities. Furthermore, it separates the test path for premul and unpremul
image bitmap sources when the filter quality is high, to match the way this
is implemented in chromium.

Bug:  744647 ,  792607 
Change-Id: I4e0b8af71d88f5885ff56540a17ec8b716cd58d7
Reviewed-on: https://chromium-review.googlesource.com/809808
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522204}
[modify] https://crrev.com/d4c244a31ad974ffd8b62ac92f78154bf3136dff/third_party/WebKit/LayoutTests/fast/webgl/resources/tex-image-and-sub-image-image-bitmap-utils-resize.js
[modify] https://crrev.com/d4c244a31ad974ffd8b62ac92f78154bf3136dff/third_party/WebKit/LayoutTests/fast/webgl/texImage-imageBitmap-from-blob-resize.html
[modify] https://crrev.com/d4c244a31ad974ffd8b62ac92f78154bf3136dff/third_party/WebKit/LayoutTests/fast/webgl/texImage-imageBitmap-from-canvas-resize.html
[modify] https://crrev.com/d4c244a31ad974ffd8b62ac92f78154bf3136dff/third_party/WebKit/LayoutTests/fast/webgl/texImage-imageBitmap-from-image-resize.html
[modify] https://crrev.com/d4c244a31ad974ffd8b62ac92f78154bf3136dff/third_party/WebKit/LayoutTests/fast/webgl/texImage-imageBitmap-from-imageData-resize.html
[modify] https://crrev.com/d4c244a31ad974ffd8b62ac92f78154bf3136dff/third_party/WebKit/LayoutTests/fast/webgl/texImage-imageBitmap-from-offscreen-canvas-resize.html

Status: Fixed (was: Assigned)
Blocking: 762559

Sign in to add a comment