[macViewsBrowser] Tab favicons are missing |
||||||||||
Issue descriptionChrome Version: 65.0.3287.0 OS: macOS 10.12 The loading spinner appears, but after it finishes there's a blank space where the favicon should be. In addition to the fix, there needs to be some kind of test to alert us if this breaks again.
,
Dec 6 2017
Thanks for all of these! I'll do a big triage of Issue 671916 blockers when the current phase is complete. See go/macviewstracking
,
Feb 8 2018
[Bulk Edit] Applying M-68 milestone per email discussion with ellyjones@. Pls change it if milestone is incorrectly applied.
,
Mar 23 2018
MacViews triage: targeting this for M67 since it's highly visible.
,
Mar 23 2018
I can take this one if you don't mind.
,
Mar 26 2018
weili@, is there nay progress here? Note: M67 branch is coming soon on April 12th and this is BLOCKING canary/dev experiment as it is P1.
,
Mar 27 2018
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e67dc3f09004bb560d682c6ed4026a73aec4af83 commit e67dc3f09004bb560d682c6ed4026a73aec4af83 Author: Wei Li <weili@chromium.org> Date: Thu Mar 29 03:21:53 2018 Allow MacViews to display favicons Use the same function to retrieve favicon for web contents for MacViews as on the other platforms, so the favicon can be displayed. BUG= 792605 Change-Id: Ide93ddb52747f86e04d09f7741af6e881d5374d6 Reviewed-on: https://chromium-review.googlesource.com/979258 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#546724} [modify] https://crrev.com/e67dc3f09004bb560d682c6ed4026a73aec4af83/chrome/browser/ui/tab_ui_helper.cc [modify] https://crrev.com/e67dc3f09004bb560d682c6ed4026a73aec4af83/chrome/browser/ui/views/frame/browser_view_browsertest.cc
,
Mar 29 2018
Is anything pending or this can be marked as fixed?
,
Mar 29 2018
This looks fixed in trunk.
,
Apr 6 2018
Unable to reproduce the issue on mac 10.12.6 using chrome reported version #65.0.3287.0as per comment #0. Observed that there is no blank space at the favicon place after the spinner finishes loading. Same behaviour in observed in latest chrome version #67.0.3390.0 after enabling flag MacViews-Browser i.e here is no blank space at the favicon place after the spinner finishes loading. Attached a screen cast for reference. weili@ - Could you please check the attached screen cast and please help us in confirming the fix. Thanks...!!
,
Apr 6 2018
krajshree@, the video showed Chrome version 67.0.3390.0. You need to try version before 67.0.3384.0 to reproduce the problem and make sure --enable-features=ViewsBrowserWindows is there.
,
Apr 13 2018
Able to reproduce the issue using chrome version #67.0.3382.0(without fix) by enabling flag --enable-features=ViewsBrowserWindows. Verified the fix on Mac 10.12.6 using Chrome version #67.0.3396.0 as per the comment #0 and #12. Attaching screen cast for reference. Observed that after loading spinner in the tab finished spinning a favicon appeared. Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by shrike@chromium.org
, Dec 6 2017