Text in Audio permission button should be sans-serif instead of serif |
|||||
Issue descriptionWe should change font to sans-serif with a medium weight.
,
Dec 11 2017
,
Dec 11 2017
Please provide the rational why this change should be cherry picked into M64 release branch.
,
Dec 12 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 13 2017
Please merge this issue to M64 branch 3282 if it has been verified in canary. The sooner the better. Thanks!
,
Dec 13 2017
verified on Chrome canary 65.0.3292.0
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57ff98b308ff69717078985ca1443fd5e0d8a3ca commit 57ff98b308ff69717078985ca1443fd5e0d8a3ca Author: Biao She <bshe@chromium.org> Date: Wed Dec 13 19:32:37 2017 Change the text font in audio permission button to san-serif-medium TBR=bshe@chromium.org (cherry picked from commit eeffe2ed5dd945f082afe981f9e6add02840fe52) Bug: 792600 Change-Id: I5b49dc226ca27cea0b686d3b118956b18d8ddbd4 Reviewed-on: https://chromium-review.googlesource.com/811837 Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522432} Reviewed-on: https://chromium-review.googlesource.com/825166 Reviewed-by: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#212} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/57ff98b308ff69717078985ca1443fd5e0d8a3ca/chrome/browser/vr/elements/audio_permission_prompt_texture.cc
,
Dec 13 2017
Thanks everyone! I have merged the change. close this one now. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Dec 7 2017