New issue
Advanced search Search tips

Issue 792589 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Deprecated Keyboard Shortcut notification uses Settings icon instead of Keyboard icon

Project Member Reported by michae...@chromium.org, Dec 6 2017

Issue description

Chrome Version: 63.0.3239.70

The notification shown when using a deprecated keyboard shortcut used to display a keyboard icon. Now it uses a cogwheel -- the Settings icon. (But there are no relevant settings to change.)

1. Use a deprecated keyboard shortcut, e.g. Shift+Esc to open the task manager

A notification appears: 

"The shortcut to open the task manager has changed. Please use Search+Esc instead of Shift+Esc."

Expected: Notification uses a keyboard icon.
Actual: Notification uses the Settings icon (cogwheel/gear).

The message is IDS_DEPRECATED_SHOW_TASK_MANAGER_MSG, and used to use the icon for the Bluetooth keyboard. It's still using that icon in the code, so something about how the notification is displayed has changed.

Compare the two notifications from "Chrome OS system" in the screenshot -- one for display (with a monitor icon), the other for the keyboard shortcut (with the cogwheel).

This may have changed in https://crrev.com/c/634774 (relanded as crrev.com/c/637650). Looking at issue 758269, it was requested that the large icon be replaced with a small icon, but since other new-style system notifications use relevant icons (like Display, in the screenshot), it seems we can use the keyboard icon here.
 
Screenshot 2017-12-06 at 11.28.46 AM.png
117 KB View Download
Cc: tetsui@chromium.org
Owner: sgabr...@chromium.org
+sgabriel@ I wonder if you have any suggestions. (fix or wont fix?)

This is in spec so WAI, but let's confirm with UX.

https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZYhMpwexg3v6/files/MCEowXfTF5pvhOuwFGrMLHX4wMSJbxAVNpw


Good catch. The cog wheel is the default "Chrome OS system messaging" icon badge, I just forgot to create a specific keyboard one for these type of notifications.

Asset attached. @Tetsui can you add it to every keyboard related notifications?
ic_notification_keyboard.svg
803 bytes Download
Cc: -tetsui@chromium.org sgabr...@chromium.org
Owner: tetsui@chromium.org
#2 Thank you for the icon! I will update them.

Comment 4 by tetsui@chromium.org, Dec 11 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7af450c160f6935bd30dde84e7fc5dac32782193

commit 7af450c160f6935bd30dde84e7fc5dac32782193
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Wed Dec 13 03:12:14 2017

Use keyboard icon for deprecated shortcut notification.

Deprecated Shortcut notification was using cogwheel icon.
This CL changes the notification to use more specific keyboard icon.

TEST=manual (Press Shift-Esc)
BUG= 792589 

Change-Id: I62ed098ade7f3fd3d03bd140553190fed5293bb4
Reviewed-on: https://chromium-review.googlesource.com/818866
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523672}
[modify] https://crrev.com/7af450c160f6935bd30dde84e7fc5dac32782193/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/7af450c160f6935bd30dde84e7fc5dac32782193/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/7af450c160f6935bd30dde84e7fc5dac32782193/ash/resources/vector_icons/notification_keyboard.icon

Comment 6 by tetsui@chromium.org, Dec 13 2017

Status: Fixed (was: Started)
Status: Archived (was: Fixed)

Sign in to add a comment