New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 792586 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: Dec 2017
Cc:
█ amp@chromium.org
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Media Router] Invalid provider ID used for sinks discovered in browser

Project Member Reported by taku...@chromium.org, Dec 6 2017 
We don't set the provider ID for Cast/Dial sinks discovered in browser (it defaults to UNKNOWN), so we get the following error when such a sink gets converted to Mojo:

FATAL:media_router_struct_traits.h(635)] Check failed: false. Invalid MediaRouteProvider::Id: 2
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9ef5260cdea70b3f1aabf1bf19ee1985d01c236

commit e9ef5260cdea70b3f1aabf1bf19ee1985d01c236
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Wed Dec 06 21:11:40 2017

Add Provider ID to MediaSinks discovered in browser

Set the provider ID for Cast/Dial sinks discovered in browser, so that it's not UNKNOWN.
We will remove UNKNOWN as the default argument for the ctor param in a separate patch to avoid bugs like this.

Bug:  792586 
Change-Id: Ia43a3e451908f8a8e3c902b7869196f2ff6a7b2a
Reviewed-on: https://chromium-review.googlesource.com/811666
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522194}
[modify] https://crrev.com/e9ef5260cdea70b3f1aabf1bf19ee1985d01c236/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc
[modify] https://crrev.com/e9ef5260cdea70b3f1aabf1bf19ee1985d01c236/chrome/browser/media/router/discovery/mdns/cast_media_sink_service.cc
[modify] https://crrev.com/e9ef5260cdea70b3f1aabf1bf19ee1985d01c236/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl.cc

Comment 2 by taku...@chromium.org, Dec 7 2017

Status: Fixed (was: Started)
►

Sign in to add a comment