New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792585 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add metric for how Tether session completes

Project Member Reported by khorimoto@chromium.org, Dec 6 2017

Issue description

We should add a metric which indicates how a Tether session completes:
  *User closes laptop lid.
  *User disconnects from network
  *User logs out
  *Tether connection dropped
 
Labels: -M-64 M-65
Owner: ----
Status: Available (was: Assigned)
Owner: hansberry@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94bd6e828afab5407d287ab72c04cd290d462773

commit 94bd6e828afab5407d287ab72c04cd290d462773
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Thu Jan 11 22:18:40 2018

Record how Tether sessions complete.

Bug:  792585 
Change-Id: Ie6cb66aeeddb13d61276ceeb5aee85a5fbf9ffd6
Reviewed-on: https://chromium-review.googlesource.com/852520
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528779}
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/fake_tether_component.cc
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/fake_tether_component.h
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/fake_tether_disconnector.cc
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/fake_tether_disconnector.h
[add] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/fake_tether_session_completion_logger.cc
[add] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/fake_tether_session_completion_logger.h
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/network_connection_handler_tether_delegate.cc
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/network_connection_handler_tether_delegate_unittest.cc
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/synchronous_shutdown_object_container_impl.cc
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/synchronous_shutdown_object_container_impl.h
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/tether_component.h
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/tether_component_impl.cc
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/tether_component_impl.h
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/tether_component_impl_unittest.cc
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/tether_disconnector.h
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/tether_disconnector_impl.cc
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/tether_disconnector_impl.h
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/tether_disconnector_impl_unittest.cc
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/tether_network_disconnection_handler.cc
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/tether_network_disconnection_handler.h
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/tether_network_disconnection_handler_unittest.cc
[add] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/tether_session_completion_logger.cc
[add] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/tether_session_completion_logger.h
[add] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/chromeos/components/tether/tether_session_completion_logger_unittest.cc
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/94bd6e828afab5407d287ab72c04cd290d462773/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment