New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792579 link

Starred by 1 user

Issue metadata

Status: Closed
Owner:
Last visit > 30 days ago
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 784495



Sign in to add a comment

Add embedded GAIA webview to views-based login

Project Member Reported by jdufault@chromium.org, Dec 6 2017

Issue description

Add embedded GAIA webview to views-based login.

WebUI structure:
- views::WebView pointing to login HTML
  - <webview gaia>

Views Structure:
- Views-based login UI
  - views::WebView hosting minimal HTML so we can customize <webview>
    - <webview gaia>

The structure w.r.t. the gaia webview is the same so this approach should minimize porting difficulties. It also makes it feasible to inject any custom code into the gaia webview if needed, since we have the host views::WebView instance.
 
Blocking: 784495
We may want to do something like InternetDetailDialog.

Comment 3 by r...@chromium.org, Dec 8 2017

Components: UI>Shell>StartScreen
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b5fa36f784c1bb1897e17f5e4bd22a0f64f4c27

commit 5b5fa36f784c1bb1897e17f5e4bd22a0f64f4c27
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Fri Jan 19 18:00:43 2018

Decouple GaiaScreenHandler with SigninScreenHandlerDelegate

Currently GaiaScreenHandler talks to backend via
SigninScreenHandlerDelegate. In the views based login screen,
SigninScreenHandlerDelegate will not be initialized, so the connection
layer is changed to LoginDisplayHost.

Bug:  792579 
Change-Id: I781bcc1cae28b12bfabf33ed5e216bff591ebb35
Reviewed-on: https://chromium-review.googlesource.com/875170
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530557}
[modify] https://crrev.com/5b5fa36f784c1bb1897e17f5e4bd22a0f64f4c27/chrome/browser/chromeos/login/ui/login_display_host.cc
[modify] https://crrev.com/5b5fa36f784c1bb1897e17f5e4bd22a0f64f4c27/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/5b5fa36f784c1bb1897e17f5e4bd22a0f64f4c27/chrome/browser/chromeos/login/ui/login_display_host_views.cc
[modify] https://crrev.com/5b5fa36f784c1bb1897e17f5e4bd22a0f64f4c27/chrome/browser/chromeos/login/ui/login_display_host_views.h
[modify] https://crrev.com/5b5fa36f784c1bb1897e17f5e4bd22a0f64f4c27/chrome/browser/ui/webui/chromeos/login/active_directory_password_change_screen_handler.cc
[modify] https://crrev.com/5b5fa36f784c1bb1897e17f5e4bd22a0f64f4c27/chrome/browser/ui/webui/chromeos/login/active_directory_password_change_screen_handler.h
[modify] https://crrev.com/5b5fa36f784c1bb1897e17f5e4bd22a0f64f4c27/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/5b5fa36f784c1bb1897e17f5e4bd22a0f64f4c27/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5b3420fe9611e7f79b59544be293cfe0fb2ac3c

commit a5b3420fe9611e7f79b59544be293cfe0fb2ac3c
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Tue Jan 23 00:20:34 2018

clean up signin screen handler delegate

Remove redundant functions in SigninScreenHandlerDelegate.
This is a follow-up CL of
https://chromium-review.googlesource.com/c/chromium/src/+/875170

Bug:  792579 
Change-Id: Ia8f82c59595f35e1bd8440dfd545863ca1e42e74
Reviewed-on: https://chromium-review.googlesource.com/879426
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531076}
[modify] https://crrev.com/a5b3420fe9611e7f79b59544be293cfe0fb2ac3c/chrome/browser/chromeos/login/app_launch_signin_screen.cc
[modify] https://crrev.com/a5b3420fe9611e7f79b59544be293cfe0fb2ac3c/chrome/browser/chromeos/login/app_launch_signin_screen.h
[modify] https://crrev.com/a5b3420fe9611e7f79b59544be293cfe0fb2ac3c/chrome/browser/chromeos/login/existing_user_controller.h
[modify] https://crrev.com/a5b3420fe9611e7f79b59544be293cfe0fb2ac3c/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/a5b3420fe9611e7f79b59544be293cfe0fb2ac3c/chrome/browser/chromeos/login/lock/webui_screen_locker.h
[modify] https://crrev.com/a5b3420fe9611e7f79b59544be293cfe0fb2ac3c/chrome/browser/chromeos/login/ui/login_display.h
[modify] https://crrev.com/a5b3420fe9611e7f79b59544be293cfe0fb2ac3c/chrome/browser/chromeos/login/ui/login_display_webui.cc
[modify] https://crrev.com/a5b3420fe9611e7f79b59544be293cfe0fb2ac3c/chrome/browser/chromeos/login/ui/login_display_webui.h
[modify] https://crrev.com/a5b3420fe9611e7f79b59544be293cfe0fb2ac3c/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/a5b3420fe9611e7f79b59544be293cfe0fb2ac3c/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6abfd13fcc88e2fa36abff3eeef9f32c0330e30a

commit 6abfd13fcc88e2fa36abff3eeef9f32c0330e30a
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Wed Jan 31 01:51:58 2018

Clean up LockContentsView before debug data dispatcher goes away

This is to fix the crash case happened when we open user menu or the gaia
dialog and then just kill chrome.

Bug:  792579 
Change-Id: I30d5e56bdf2b7e17b4f34de9e4935b42ee47c3dc
Reviewed-on: https://chromium-review.googlesource.com/894888
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533155}
[modify] https://crrev.com/6abfd13fcc88e2fa36abff3eeef9f32c0330e30a/ash/login/ui/lock_debug_view.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fba0e7598ea7386ff0e0eae976d33b0b107412f

commit 9fba0e7598ea7386ff0e0eae976d33b0b107412f
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Wed Feb 07 01:41:09 2018

Create Gaia sign webview in chrome for views login screen.

This is a basic flow of adding a new user in the views login screen.
Changes including:
1. Add ShowGaiaSignin mojo call for the views login screen to request
show gaia screen in chrome.
2. Create GaiaDialogDelegate to manage the behavior of the dialog which
hosts the gaia content.
3. Updating LoginHostDisplay to support views login case:
Act like an intermediate layer for communication between GaiaScreenHandler
and GaiaDialogDelegate. Also owns the WizardController to support post
login screens.
4. Add handler functions in GaiaScreenHandler to update the gaia screen
size and visibility. Move HandleShowAddUser/OnShowAddUser from
SigninScreenHandler to GaiaScreenHandler because its more relevant to
gaia screen.
5. Update JS code to handle views login case.


Bug:  792579 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2802e857eb3c6c825e0a463010c856958badd2b7
Reviewed-on: https://chromium-review.googlesource.com/892042
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534867}
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/ash/login/login_screen_controller.cc
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/ash/login/login_screen_controller.h
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/chromeos/login/screens/gaia_view.h
[add] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/chromeos/login/ui/gaia_dialog_delegate.cc
[add] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/chromeos/login/ui/gaia_dialog_delegate.h
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/chromeos/login/ui/login_display_host_views.cc
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/chromeos/login/ui/login_display_host_views.h
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/chromeos/login/ui/login_display_views.cc
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/resources/chromeos/login/md_login.js
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/ui/ash/login_screen_client.h
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
[modify] https://crrev.com/9fba0e7598ea7386ff0e0eae976d33b0b107412f/ui/login/display_manager.js

Status: Closed (was: Assigned)
I believe this is obsolete. Please reopen if still needed.

Sign in to add a comment