New issue
Advanced search Search tips

Issue 792575 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 731255



Sign in to add a comment

Make sure videodetection works with mus without viz

Project Member Reported by sky@chromium.org, Dec 6 2017

Issue description

This is to ensure videodetection still works when chrome is run with mus and no viz. That is, chrome --mus.
 
I believe for this, ShellPortMus::AddVideoDetectorObserver() should do what ShellPortLocal does (i.e. get HostFrameSinkManager from aura::Env and add observer there) when !switches::IsMusHostingViz(). And that should be sufficient.

Comment 2 Deleted

Comment 3 by samans@chromium.org, Dec 13 2017

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f42bde1a82319bfe994413bf09758abb0aaffcb

commit 6f42bde1a82319bfe994413bf09758abb0aaffcb
Author: Saman Sami <samans@chromium.org>
Date: Wed Dec 13 22:29:04 2017

Make video detection work with --mus

With --mus the browser process hosts viz so we must directly talk to
HostFrameSinkManager to add a VideoDetectorObserver instead of going
through the ui service which has no access to viz whatsoever.

Tested on my workstation both --mus, --mus=viz and --mash.

Bug:  792575 
Change-Id: Ifba73334ddc667af0a2b6076c3add9ada59f3362
Reviewed-on: https://chromium-review.googlesource.com/823103
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523913}
[modify] https://crrev.com/6f42bde1a82319bfe994413bf09758abb0aaffcb/ash/shell_port_mus.cc

Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment