New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 792573 link

Starred by 1 user
Status: WontFix
Owner:
mdjones@chromium.org
Closed: Feb 2018
Cc:
cl...@chromium.org
twelling...@chromium.org
tedc...@chromium.org
█ k...@chromium.org
█ hannahs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Chrome Home] Temporarily show bookmarks, downloads, and history in overflow menu

Project Member Reported by mdjones@chromium.org, Dec 6 2017 
We should show the bookmarks, downloads, and history menu items for a short period after Chrome Home is enabled. The idea here is to help users more easily find where their content went.

Each time one of the items is clicked, the bottom sheet can open to the desired content with the corresponding nav button highlighted. After some number of times being opened from the menu (10 maybe), the options will disappear and the IPH at the top of the menu could appear.

Comment 1 by mdjones@chromium.org, Dec 6 2017

Status: Started (was: Assigned)
Attaching video of prototype:
recording.mp4
4.3 MB View Download

Comment 2 by mdjones@chromium.org, Dec 8 2017 

I added the help bubble to the prototype:
recording.mp4
3.6 MB View Download

Comment 3 by hannahs@chromium.org, Dec 13 2017 

LGTM! The only nice to have would be to make the blue highlight in the bottom nav a circle to make it feel more a tap was registered (can we reuse what we did for the Downloads IPH?)

And maybe have it pulse 1 more time since you might miss it reading the IPH bubble?

Chris wdyt?

Comment 4 by mdjones@chromium.org, Dec 13 2017 

I tried the circular highlight but it looks off-center/wrong because it centers on the whole view rather than just the icon. I could make the highlight on the icon but then it would be too small. I'll see if this is something we can customize.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2

commit eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2
Author: Matthew Jones <mdjones@chromium.org>
Date: Tue Dec 19 16:12:42 2017

[Home] Allow bookmarks, downloads, and history menu items to open sheet

This change adds a finch flag "ChromeHomeMenuItemsExpandSheet" that
allows the bookmarks, downloads, and history menu items to be shown
despite Chrome Home being enabled. Selecting these items expands the
bottom sheet to half height with the selected content being shown.
The tap count will be reset if either Chrome Home or the feature is
disabled. Tap count can be configured via finch with the "max_taps"
parameter.

BUG= 792573 

Change-Id: Ibc66e59aa773a69c474f08e2fc7fa9c708d33468
Reviewed-on: https://chromium-review.googlesource.com/806257
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525049}
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkPersonalizedSigninPromoTest.java
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/browser/about_flags.cc
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/eab91aa0061dd1f3e1df2a0943fbd9a7c2a920d2/tools/metrics/histograms/enums.xml

Comment 6 by mdjones@chromium.org, Feb 12 2018

Status: WontFix (was: Started)
Chrome Home is being turned down so I'm marking this as WontFix.
►

Sign in to add a comment