New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792568 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 671916



Sign in to add a comment

[macViewsBrowser] Extension items not centered vertically in the toolbar

Project Member Reported by shrike@chromium.org, Dec 6 2017

Issue description

Chrome Version: 65.0.3287.0
OS: macOS 10.12

See screenshot
 
Screen Shot 2017-12-06 at 11.05.09 AM.png
6.7 KB View Download
Blocking: 671916
Labels: Pri-2
Status: Available (was: Untriaged)
Thanks for all of these! I'll do a big triage of  Issue 671916  blockers when the current phase is complete. See go/macviewstracking
Owner: spqc...@chromium.org
Status: Assigned (was: Available)
spqchan@, can you take a peek at this please? :)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2234f2313c767f2c7b8e26c66d084abbe891e8c6

commit 2234f2313c767f2c7b8e26c66d084abbe891e8c6
Author: spqchan <spqchan@chromium.org>
Date: Thu Jan 18 19:26:04 2018

[Views] Fix extension button vertical alignment

The current toolbar layout assumes that all of the child
views on the toolbar, except for the location bar, have the
same height.

However, on Mac, the browser action buttons have a slightly
smaller height than the other buttons. This causes the
browser action buttons to be vertically misaligned.

This CL addresses the issue by calculating the browser action
container layout separately from the rest of the child views.

Bug:  792568 
Change-Id: I6be4c480dae8259ada79491b843aebbee5e6fcfc
Reviewed-on: https://chromium-review.googlesource.com/871572
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530226}
[modify] https://crrev.com/2234f2313c767f2c7b8e26c66d084abbe891e8c6/chrome/browser/ui/views/toolbar/toolbar_view.cc

Labels: TE-Verified-M65 TE-Verified-65.0.3325.0
Verified the fix on Mac 10.13.1 using Chrome version #65.0.3325.0 as per the comment #0.
Attaching screen shot for reference.
Observed that the position of extension icon properly aligned.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
792568 cl verified.png
7.5 KB View Download
Status: Fixed (was: Started)

Comment 7 by shrike@chromium.org, Jan 19 2018

> Verified the fix on Mac 10.13.1 using Chrome version #65.0.3325.0 as per the comment #0.

This is the MacViewsBrowser version of Chrome Mac - unless you compiled 65.0.3325.0 with the proper flags you are likely using the non-MVB version which doesn't exhibit this bug?

Sign in to add a comment