New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Duplicate
Merged: issue 781998
Owner:
Last visit > 30 days ago
Closed: Sep 21
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment
link

Issue 792565: desktopui_ScreenLocker failing on betty

Reported by sheriff-...@appspot.gserviceaccount.com, Dec 6 2017 Project Member

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of rspangler@google.com

/tmp/cbuildbotSb9dnC/smoke/test_harness/all/SimpleTestVerify/1_autotest_tests/results-36-desktopui_ScreenLocker                                                                  [  FAILED  ]
/tmp/cbuildbotSb9dnC/smoke/test_harness/all/SimpleTestVerify/1_autotest_tests/results-36-desktopui_ScreenLocker                                                                    FAIL: Screen not locked after using keyboard shortcut
/tmp/cbuildbotSb9dnC/smoke/test_harness/all/SimpleTestVerify/1_autotest_tests/results-36-desktopui_ScreenLocker/desktopui_ScreenLocker                                           [  FAILED  ]
/tmp/cbuildbotSb9dnC/smoke/test_harness/all/SimpleTestVerify/1_autotest_tests/results-36-desktopui_ScreenLocker/desktopui_ScreenLocker                                             FAIL: Screen not locked after using keyboard shortcut

Builders failed on: 
- betty-arc64-nyc-android-pfq: 
  https://luci-milo.appspot.com/buildbot/chromeos/betty-arc64-nyc-android-pfq/346
 

Comment 1 by rspangler@chromium.org, Dec 6 2017

Cc: -rspangler@google.com rspangler@chromium.org steve...@chromium.org
Owner: jdufault@chromium.org
Status: Assigned (was: Available)
Y'all touched a related bug recently (issue 781845).  Can you help get this one to the right place?

Comment 2 by jdufault@chromium.org, Dec 6 2017

Owner: xiaoyinh@chromium.org
xiaoyinh@ is currently reworking the desktopui_ScreenLocker test to use views-based lock.

Comment 3 by jdufault@chromium.org, Dec 6 2017

Cc: jdufault@chromium.org

Comment 5 by davidri...@chromium.org, Dec 6 2017

Labels: -Pri-1 Pri-0
This is failing pre-CQ runs as well.

If a proper fix is not incoming immediately, can we please get a revert to avoid blocking all other developers.

For example:
https://chromium-review.googlesource.com/c/806877/
https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/pre_cq/71542

Comment 6 by xiaoyinh@chromium.org, Dec 6 2017

Reverted my CL which changed the autotest API.

https://chromium-review.googlesource.com/c/chromium/src/+/812264

Comment 7 by pkasting@chromium.org, Dec 6 2017

Labels: -Pri-0 -Sheriff-Chromium Pri-1
Status: Started (was: Assigned)
Fingers crossed that this is fixed by the revert in comment 6; removing from sheriff queue.

Comment 8 by dgarr...@chromium.org, Dec 6 2017

Just noting that a number of builds have continued to fail after the revert, but so far, all of them were started BEFORE the revert.

Comment 9 by akes...@chromium.org, Dec 7 2017

Labels: -Pri-1 Pri-0
This is still failing, including builds that started post revert.

https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/pre_cq/71632

Comment 10 by akes...@chromium.org, Dec 7 2017

It's time to remove this test from bvt-cq

Comment 11 by bugdroid1@chromium.org, Dec 7 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4db1324ac3990d2ca0393b64346ef2da7f435c64

commit 4db1324ac3990d2ca0393b64346ef2da7f435c64
Author: Aviv Keshet <akeshet@chromium.org>
Date: Thu Dec 07 02:57:57 2017

temporarily remove desktopui_ScreenLocker from smoke suite

BUG= chromium:792565 
TEST=None

Change-Id: Ib86ae0cb2a2ead68a25e92c6702e9e96e2b6eb29
Reviewed-on: https://chromium-review.googlesource.com/813202
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/4db1324ac3990d2ca0393b64346ef2da7f435c64/client/site_tests/desktopui_ScreenLocker/control

Comment 12 by akes...@chromium.org, Dec 7 2017

Labels: -Pri-0 Pri-2

Comment 13 by akes...@chromium.org, Dec 7 2017

Test removed from smoke, fix at leisure.

Comment 14 by derat@chromium.org, Dec 7 2017

Cc: derat@chromium.org
When this is fixed, it'd be nice to see some investigation of how it started failing on the CQ. Was it broken by a change to something not exercised by the Chrome OS CQ or Chrome PFQ?

Comment 15 by xiaoyinh@chromium.org, Sep 21

Mergedinto: 781998
Status: Duplicate (was: Started)

Sign in to add a comment