New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792553 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug

Blocked on:
issue 792649



Sign in to add a comment

Centralize UKM scheme checks to be in ukm_recorder_impl.cc

Project Member Reported by asvitk...@chromium.org, Dec 6 2017

Issue description

Centralize UKM scheme checks to be in ukm_recorder_impl.cc.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bbcb250731a720f8a18774762213b48de1a2ff9

commit 6bbcb250731a720f8a18774762213b48de1a2ff9
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Thu Dec 07 17:51:13 2017

Centralize UKM scheme checks to be in ukm_recorder_impl.cc.

Includes a unit test. Also fixes some lint warnings.

BUG= 792553 
TBR=khushalsagar@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I4d582129d50bc2a7403b0bc0028bbf0ff4fd6b4e
Reviewed-on: https://chromium-review.googlesource.com/811627
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522467}
[modify] https://crrev.com/6bbcb250731a720f8a18774762213b48de1a2ff9/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/6bbcb250731a720f8a18774762213b48de1a2ff9/cc/trees/ukm_manager_unittest.cc
[modify] https://crrev.com/6bbcb250731a720f8a18774762213b48de1a2ff9/components/ukm/content/source_url_recorder.cc
[modify] https://crrev.com/6bbcb250731a720f8a18774762213b48de1a2ff9/components/ukm/content/source_url_recorder_browsertest.cc
[modify] https://crrev.com/6bbcb250731a720f8a18774762213b48de1a2ff9/components/ukm/content/source_url_recorder_test.cc
[modify] https://crrev.com/6bbcb250731a720f8a18774762213b48de1a2ff9/components/ukm/ukm_recorder_impl.cc
[modify] https://crrev.com/6bbcb250731a720f8a18774762213b48de1a2ff9/components/ukm/ukm_service_unittest.cc
[modify] https://crrev.com/6bbcb250731a720f8a18774762213b48de1a2ff9/tools/metrics/histograms/enums.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7187c3e3690514144956e7ce9d8b4e6d91c1208c

commit 7187c3e3690514144956e7ce9d8b4e6d91c1208c
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Fri Dec 08 21:51:04 2017

Update UKM URL scheme checks.

ftp://, chrome:// and about: URLs are included, though we strip
query params for the latter two.

BUG= 792553 

Change-Id: I4271b017384e1c9cf66c9071dc56f20a950e4906
Reviewed-on: https://chromium-review.googlesource.com/817703
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522891}
[modify] https://crrev.com/7187c3e3690514144956e7ce9d8b4e6d91c1208c/components/ukm/ukm_recorder_impl.cc
[modify] https://crrev.com/7187c3e3690514144956e7ce9d8b4e6d91c1208c/components/ukm/ukm_service_unittest.cc

Labels: Merge-Request-64
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 9 2017

Labels: -Merge-Request-64 Hotlist-Merge-Approved Merge-Approved-64
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: OS-Android OS-Chrome OS-Fuchsia OS-iOS OS-Linux OS-Mac OS-Windows
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 11 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d7f7caca7bcf85eafb51e5814d36c469cc64408

commit 2d7f7caca7bcf85eafb51e5814d36c469cc64408
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Mon Dec 11 18:59:53 2017

Centralize UKM scheme checks to be in ukm_recorder_impl.cc.

Includes a unit test. Also fixes some lint warnings.

BUG= 792553 
TBR=asvitkine@chromium.org, khushalsagar@chromium.org

(cherry picked from commit 6bbcb250731a720f8a18774762213b48de1a2ff9)

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I4d582129d50bc2a7403b0bc0028bbf0ff4fd6b4e
Reviewed-on: https://chromium-review.googlesource.com/811627
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522467}
Reviewed-on: https://chromium-review.googlesource.com/819974
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#139}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/cc/trees/ukm_manager_unittest.cc
[modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/components/ukm/content/source_url_recorder.cc
[modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/components/ukm/content/source_url_recorder_browsertest.cc
[modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/components/ukm/content/source_url_recorder_test.cc
[modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/components/ukm/ukm_recorder_impl.cc
[modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/components/ukm/ukm_service_unittest.cc
[modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/tools/metrics/histograms/enums.xml

Merged the first CL.

For the second CL, it depends on crbug.com/792649, for which I've also requested merge now.
Blockedon: 792649
Labels: M-64
Status: Fixed (was: Started)
Both CLs now merged to M64.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fceaa7193753a8ca54eb63b099610c0d63b6a31

commit 2fceaa7193753a8ca54eb63b099610c0d63b6a31
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Tue Dec 12 18:37:08 2017

Update UKM URL scheme checks.

ftp://, chrome:// and about: URLs are included, though we strip
query params for the latter two.

BUG= 792553 
TBR=asvitkine@chromium.org

(cherry picked from commit 7187c3e3690514144956e7ce9d8b4e6d91c1208c)

Change-Id: I4271b017384e1c9cf66c9071dc56f20a950e4906
Reviewed-on: https://chromium-review.googlesource.com/817703
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522891}
Reviewed-on: https://chromium-review.googlesource.com/822976
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#176}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/2fceaa7193753a8ca54eb63b099610c0d63b6a31/components/ukm/ukm_recorder_impl.cc
[modify] https://crrev.com/2fceaa7193753a8ca54eb63b099610c0d63b6a31/components/ukm/ukm_service_unittest.cc

Sign in to add a comment