Centralize UKM scheme checks to be in ukm_recorder_impl.cc |
|||||||
Issue descriptionCentralize UKM scheme checks to be in ukm_recorder_impl.cc.
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7187c3e3690514144956e7ce9d8b4e6d91c1208c commit 7187c3e3690514144956e7ce9d8b4e6d91c1208c Author: Alexei Svitkine <asvitkine@chromium.org> Date: Fri Dec 08 21:51:04 2017 Update UKM URL scheme checks. ftp://, chrome:// and about: URLs are included, though we strip query params for the latter two. BUG= 792553 Change-Id: I4271b017384e1c9cf66c9071dc56f20a950e4906 Reviewed-on: https://chromium-review.googlesource.com/817703 Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#522891} [modify] https://crrev.com/7187c3e3690514144956e7ce9d8b4e6d91c1208c/components/ukm/ukm_recorder_impl.cc [modify] https://crrev.com/7187c3e3690514144956e7ce9d8b4e6d91c1208c/components/ukm/ukm_service_unittest.cc
,
Dec 8 2017
,
Dec 9 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 11 2017
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d7f7caca7bcf85eafb51e5814d36c469cc64408 commit 2d7f7caca7bcf85eafb51e5814d36c469cc64408 Author: Alexei Svitkine <asvitkine@chromium.org> Date: Mon Dec 11 18:59:53 2017 Centralize UKM scheme checks to be in ukm_recorder_impl.cc. Includes a unit test. Also fixes some lint warnings. BUG= 792553 TBR=asvitkine@chromium.org, khushalsagar@chromium.org (cherry picked from commit 6bbcb250731a720f8a18774762213b48de1a2ff9) Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I4d582129d50bc2a7403b0bc0028bbf0ff4fd6b4e Reviewed-on: https://chromium-review.googlesource.com/811627 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522467} Reviewed-on: https://chromium-review.googlesource.com/819974 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#139} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/cc/trees/ukm_manager_unittest.cc [modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/components/ukm/content/source_url_recorder.cc [modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/components/ukm/content/source_url_recorder_browsertest.cc [modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/components/ukm/content/source_url_recorder_test.cc [modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/components/ukm/ukm_recorder_impl.cc [modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/components/ukm/ukm_service_unittest.cc [modify] https://crrev.com/2d7f7caca7bcf85eafb51e5814d36c469cc64408/tools/metrics/histograms/enums.xml
,
Dec 11 2017
Merged the first CL. For the second CL, it depends on crbug.com/792649, for which I've also requested merge now.
,
Dec 12 2017
,
Dec 12 2017
Both CLs now merged to M64.
,
Dec 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fceaa7193753a8ca54eb63b099610c0d63b6a31 commit 2fceaa7193753a8ca54eb63b099610c0d63b6a31 Author: Alexei Svitkine <asvitkine@chromium.org> Date: Tue Dec 12 18:37:08 2017 Update UKM URL scheme checks. ftp://, chrome:// and about: URLs are included, though we strip query params for the latter two. BUG= 792553 TBR=asvitkine@chromium.org (cherry picked from commit 7187c3e3690514144956e7ce9d8b4e6d91c1208c) Change-Id: I4271b017384e1c9cf66c9071dc56f20a950e4906 Reviewed-on: https://chromium-review.googlesource.com/817703 Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522891} Reviewed-on: https://chromium-review.googlesource.com/822976 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#176} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/2fceaa7193753a8ca54eb63b099610c0d63b6a31/components/ukm/ukm_recorder_impl.cc [modify] https://crrev.com/2fceaa7193753a8ca54eb63b099610c0d63b6a31/components/ukm/ukm_service_unittest.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Dec 7 2017