New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792552 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add UMA counters for background GC tasks

Project Member Reported by u...@chromium.org, Dec 6 2017

Issue description

Currently UMA tracks GC time only on the main thread.

As we are moving more GC work to background threads, we need to track how much time GC spends there.

This will allow us to spot unexpected regressions and make informed trade-off decisions.


 

Comment 1 by u...@chromium.org, Dec 7 2017

Cc: altimin@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/94523395c56ba1a55935deea8a33d375fa464bce

commit 94523395c56ba1a55935deea8a33d375fa464bce
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Mon Dec 11 17:34:50 2017

[heap] Add UMA histograms for background GC work.

This adds the following histograms:
- V8.GCBackgroundMarking
- V8.GCBackgroundScavenger
- V8.GCBackgroundSweeping

Bug:  chromium:792552 
Change-Id: Iae6fa3258f4fe0d4ed5e415c541a6d29101893a9
Reviewed-on: https://chromium-review.googlesource.com/819530
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50005}
[modify] https://crrev.com/94523395c56ba1a55935deea8a33d375fa464bce/src/counters.h
[modify] https://crrev.com/94523395c56ba1a55935deea8a33d375fa464bce/src/heap/gc-tracer.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b191d47eef6f7ce2776e4cf34a5f585b095b2866

commit b191d47eef6f7ce2776e4cf34a5f585b095b2866
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Wed Dec 13 12:32:28 2017

Add UMA histogram that tracks time spent in background GC tasks.

This adds the following histograms to histograms.xml:
- V8.GCBackgroundMarking
- V8.GCBackgroundScavenger
- V8.GCBackgroundSweeping

Bug:  chromium:792552 
Change-Id: I15f3df49773b630620d6c67121c46ad7fff3e179
Reviewed-on: https://chromium-review.googlesource.com/819610
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523754}
[modify] https://crrev.com/b191d47eef6f7ce2776e4cf34a5f585b095b2866/tools/metrics/histograms/histograms.xml

Comment 4 by u...@chromium.org, Dec 15 2017

Status: Fixed (was: Assigned)

Sign in to add a comment