New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792548 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit 16 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

A with display:block causes InsertText command crash

Project Member Reported by ClusterFuzz, Dec 6 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5715361885585408

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000048
Crash State:
  blink::CompositeEditCommand::InsertNodeAfter
  blink::InsertParagraphSeparatorCommand::DoApply
  blink::CompositeEditCommand::ApplyCommandToComposite
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=340068:340078

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5715361885585408

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 6 2017

Components: Blink>Editing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 2 by yosin@chromium.org, Dec 7 2017

Components: -Blink>Editing Blink>Editing>Command
Labels: -Pri-1 Pri-3
Status: Available (was: Untriaged)
Summary: A with display:block causes InsertText command crash (was: Null-dereference READ in blink::CompositeEditCommand::InsertNodeAfter)
Lower to Pri-3 since this is caused by unusual HTML.
Owner: tanvir.r...@samsung.com
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8128752a67b6a2d68982f3cffb50bcd7a33f24ff

commit 8128752a67b6a2d68982f3cffb50bcd7a33f24ff
Author: tanvir.rizvi <tanvir.rizvi@samsung.com>
Date: Mon Dec 18 06:13:35 2017

Fix for clusterfuzz crash while insertText is executed

While executing insertTextCommand with text having
paragraph seperator, on a unusual selection content
which has a nested anchor element within same block,
this crash happens.
While insertion of the paragraph seperator,
the |PositionAvoidingSpecialElementBoundary| algorithm
inserts new A element which was making the already
calculated start block parent 'null' making content
to crash.
The crash is avoided by doing safety checks.

Bug:  792548 
Change-Id: Ica9e38857edac95a7151fda993ae5ef6e7b17ca3
Reviewed-on: https://chromium-review.googlesource.com/822550
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#524656}
[modify] https://crrev.com/8128752a67b6a2d68982f3cffb50bcd7a33f24ff/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
[modify] https://crrev.com/8128752a67b6a2d68982f3cffb50bcd7a33f24ff/third_party/WebKit/Source/core/editing/commands/InsertTextCommandTest.cpp

Project Member

Comment 5 by ClusterFuzz, Dec 18 2017

ClusterFuzz has detected this issue as fixed in range 524655:524656.

Detailed report: https://clusterfuzz.com/testcase?key=5715361885585408

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000048
Crash State:
  blink::CompositeEditCommand::InsertNodeAfter
  blink::InsertParagraphSeparatorCommand::DoApply
  blink::CompositeEditCommand::ApplyCommandToComposite
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=340068:340078
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=524655:524656

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5715361885585408

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Dec 18 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 5715361885585408 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment