Issue metadata
Sign in to add a comment
|
Select to Speak issues with gmail drafts |
||||||||||||||||||||||||
Issue descriptionChrome OS Version: 65.0.3286.0 When using StS in gmail, I'm noticing that when you open a new draft to write and type text, it's currently not possible to then use StS to select that text and have it read aloud; when I try to select that text in the draft, StS reads what is behind it. Note that this is specifically when you hit the Compose button and a draft appears in the lower right corner, not when you are replying to a message in the main content area of gmail (that seems to work okay).
,
Dec 6 2017
I actually can't reproduce this at Trunk / HEAD with ChromeOS on Linux. Can I take a look at what device setup you have?
,
Dec 7 2017
Perhaps device scale factor is at fault -- check for px vs dips in hittest code.
,
Dec 8 2017
Looks like the event.target returned for the hit test is different on the pixel chromebook (or a ChromeOS on Linux device scaled with --ash-host-window-bounds="801+0-800x800*2") as compared to a ChromeOS on Linux device not scaled. In the former, the event target is a cell in the list behind the email. In the later, the event target is within the new email dialog.
,
Dec 12 2017
,
Dec 13 2017
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05fad8d38f7a036175b3b5dd5711b441aba49f63 commit 05fad8d38f7a036175b3b5dd5711b441aba49f63 Author: Katie Dektar <katydek@google.com> Date: Thu Dec 14 03:01:37 2017 Fix hit test: DIP must be converted to PX for RenderFrameHost hittest. This fixes a bug where in gmail selecting text in an open draft also selected text behind that pop up window. The bug was occuring because the hittest was returning a node that was behind the open dialog/window, and select-to-speak walked up its tree to find a higher level root with which to build the nodes to speak. The bug only showed up on high density screens because then DIP and PX were significantly different. On 1:1 screens it could not be found. A test is added which fails without this one-line change but passes with it. Bug: 792545 Change-Id: I21519b6cfaae97cb11c711b11b7a6b3e4b6fe017 Reviewed-on: https://chromium-review.googlesource.com/826043 Commit-Queue: Katie D <katie@chromium.org> Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#523992} [modify] https://crrev.com/05fad8d38f7a036175b3b5dd5711b441aba49f63/chrome/browser/extensions/api/automation/automation_apitest.cc [modify] https://crrev.com/05fad8d38f7a036175b3b5dd5711b441aba49f63/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc [modify] https://crrev.com/05fad8d38f7a036175b3b5dd5711b441aba49f63/chrome/test/data/extensions/api_test/automation/tests/desktop/hit_test.js
,
Dec 14 2017
,
Jan 10 2018
,
Apr 10 2018
Moving from just having STS label to also having the UI>Accessibility>SelectToSpeak component to make searching easier in the future.
,
May 23 2018
,
May 24 2018
Verified using new button Google Chrome 68.0.3431.0 (Official Build) dev (64-bit) Firmware Version Google_Lulu.6301.136.57 # Enable STS # Open Gmail draft in lower right corner; type some words in the draft # Use mouse to invoke button # Draw focus ring around words in the draft STS works as expected. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by katie@chromium.org
, Dec 6 2017