New issue
Advanced search Search tips

Issue 792533 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 469639



Sign in to add a comment

Implement Constructor option passing in AudioWorkletNode

Project Member Reported by hongchan@chromium.org, Dec 6 2017

Issue description

Spec: https://webaudio.github.io/web-audio-api/#instantiation-of-AudioWorkletNode-and-AudioWorkletProcessor

Implement StructuredSerialization of `options` in AudioWorkletNode instantiation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97bd22e173e6480549b7d8e4525817d8ec290fc0

commit 97bd22e173e6480549b7d8e4525817d8ec290fc0
Author: Hongchan Choi <hongchan@chromium.org>
Date: Thu Feb 01 00:58:54 2018

Pass AudioWorkletNodeOptions to AudioWorkletProcessor constructor

This CL enables a cross-thread messaging from AudioWorkletNode
constructor to AudioWorkletProcessor (subclass) constructor.

Spec:
https://webaudio.github.io/web-audio-api/#instantiation-of-AudioWorkletNode-and-AudioWorkletProcessor

WG decision:
https://github.com/WebAudio/web-audio-api/issues/1459

Bug:  792533 
Change-Id: I4fe5bc8188f98533e6c046406002f1cfcb7ff3b8
Reviewed-on: https://chromium-review.googlesource.com/812509
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533500}
[add] https://crrev.com/97bd22e173e6480549b7d8e4525817d8ec290fc0/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/node-option-to-processor.html
[add] https://crrev.com/97bd22e173e6480549b7d8e4525817d8ec290fc0/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/option-test-processor.js
[modify] https://crrev.com/97bd22e173e6480549b7d8e4525817d8ec290fc0/third_party/WebKit/Source/modules/webaudio/AudioWorklet.cpp
[modify] https://crrev.com/97bd22e173e6480549b7d8e4525817d8ec290fc0/third_party/WebKit/Source/modules/webaudio/AudioWorklet.h
[modify] https://crrev.com/97bd22e173e6480549b7d8e4525817d8ec290fc0/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScope.cpp
[modify] https://crrev.com/97bd22e173e6480549b7d8e4525817d8ec290fc0/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScope.h
[modify] https://crrev.com/97bd22e173e6480549b7d8e4525817d8ec290fc0/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp
[modify] https://crrev.com/97bd22e173e6480549b7d8e4525817d8ec290fc0/third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.cpp
[modify] https://crrev.com/97bd22e173e6480549b7d8e4525817d8ec290fc0/third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.h
[modify] https://crrev.com/97bd22e173e6480549b7d8e4525817d8ec290fc0/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.cpp
[modify] https://crrev.com/97bd22e173e6480549b7d8e4525817d8ec290fc0/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.h
[modify] https://crrev.com/97bd22e173e6480549b7d8e4525817d8ec290fc0/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.idl
[modify] https://crrev.com/97bd22e173e6480549b7d8e4525817d8ec290fc0/third_party/WebKit/Source/modules/webaudio/AudioWorkletNodeOptions.idl

Status: Verified (was: Started)

Sign in to add a comment