Views: Constrained windows are draggable |
|||||||
Issue descriptionChrome Version: 65.0.3286.0 OS: 10.12.6 What steps will reproduce the problem? (1) --enable-features=SecondaryUiMd,ShowAllDialogsWithViewsToolkit (2) Bookmark a website to the bookmarks bar (3) Right click and choose "Edit" on the item in the bookmarks bar (4) Click and hold on the "Edit Bookmark" dialog title (5) Drag the mouse all around the screen What is the expected result? The constrained dialog stays put/attached to the place where it opened. Or not, it's kinda fun that it doesn't, but this is definitely a behavior change from Cocoa. What happens instead? The constrained window is draggable. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jan 10 2018
For the record: we wanted to disable dialog dragging on non-Mac platforms but we decided it was out of scope. If you need this for Mac, I think it's okay to make the change across all platforms.
,
Jan 23 2018
These Proj=MacViews bugs should probably be tracking for Phase 3 ( Issue 603386 ) - m66.
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ccf96e6fc17d994f4d5b654d209a2af64cfc922 commit 7ccf96e6fc17d994f4d5b654d209a2af64cfc922 Author: Trent Apted <tapted@chromium.org> Date: Fri Mar 23 00:09:52 2018 MacViews: Disallow dragging of modals. views::BubbleFrameView::NonClientHitTest() dutifully returns HTCAPTION for points that hit the dialog title on non-bubble dialogs. This is interpreted as a draggable region. But everyone freaks out when modal windows are draggable, so disallow it. Other platforms may still want window-modals to be draggable. But on Mac these are sheets and dragging those is especially trippy. Bug: 824422 , 792528 , 500783 Change-Id: I2b9802e53cad7e762fc74d8b4ac73c4d82d067ba Reviewed-on: https://chromium-review.googlesource.com/974810 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#545298} [modify] https://crrev.com/7ccf96e6fc17d994f4d5b654d209a2af64cfc922/ui/views/cocoa/bridged_native_widget.mm
,
Mar 26 2018
tapted: is this Fixed now by the CL in #4?
,
Mar 26 2018
For Mac, yes (primarily to address the extra-weird Issue 824422 for window-modals). Constrained windows (parent-modal) were at one time movable as well on *all* platforms (this bug). But when I tried Windows/Linux recently I couldn't reproduce this. Even though we definitely have reproduced it in the past (e.g. with http-auth). And the same code in NonClientHitTest() that returned HTCAPTION to trigger the move on Mac is still around. So I don't know what's going on :/. There may be a separate regression, or something I've missed.
,
Mar 26 2018
+ellyjones@, PTAL comment #6. Thank you.
,
Mar 29 2018
Can this be marked as fixed per comment #6?
,
Mar 29 2018
Sure. per #c6: this is fixed on mac. I don't know what's happening on Linux/Windows -- seems not to repro any more. (Feel free to reopen if it does).
,
Apr 6 2018
Tested the issue on latest chrome 67.0.3390.0 using Mac 10.12.6, Ubuntu 14.04 & Windows-10 with steps mentioned below: 1) Launched chrome by enabling "SecondaryUiMd, ShowAllDialogsWithViewsToolkit", Bookmarked a website to the bookmarks bar 2) Right click and choose "Edit" in the bookmarks bar, Clicked and hold on the "Edit Bookmark" dialog title 3) Dragged the mouse all around the screen and observations are as follows: Mac 10.12.6: Not able to drag "Edit Bookmark" dialog box on launching chrome with and without flags, Ubuntu 14.04:Not able to drag "Edit Bookmark" dialog box, but on dragging it total chrome window got dragged on launching chrome with and without flags, Windows-10: Able to drag "Edit Bookmark" dialog box on launching chrome with and without flags mentioned above. @Trent Apted: Please find the attached screen cast of all three OS for your reference and please help in verifying the fix. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tapted@chromium.org
, Dec 6 2017Labels: Proj-HarmonyDialogs M-65 OS-Linux OS-Windows
Owner: tapted@chromium.org
Status: Assigned (was: Untriaged)
Summary: Views: Constrained windows are draggable (was: MacViews: Constrained windows are draggable)