New issue
Advanced search Search tips

Issue 792527 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

chromium.fyi builders are failing compile due to missing protobuf python package.

Project Member Reported by iannucci@chromium.org, Dec 6 2017

Issue description

(https://ci.chromium.org/p/chromium/g/chromium.fyi/console)

It looks like some python scripts are assuming that the protobuf python package is installed everywhere. I suspect an expedient way to resolve this would be to add protobuf to https://chromium.googlesource.com/chromium/src.git/+/master/.vpython and then to change the script invocation to use vpython instead of python.

Protobuf is already built for vpython (https://chromium.googlesource.com/infra/infra/+/master/infra/tools/dockerbuild/wheels.md)

Filing this on behalf of creis@. +sheriffs too.
 
Owner: sebmarchand@chromium.org
Status: Fixed (was: Untriaged)
This was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/811945 , I think.
A revert wouldn't have been necessary if we had a consistent package deployment mechanism in place. Filed bug 792650 to enable one.
Cc: beccahughes@chromium.org
For the record, this has been fixed by these 2 reverts:
- https://chromium-review.googlesource.com/c/chromium/src/+/812044
- https://chromium-review.googlesource.com/c/chromium/src/+/811945

There's been an attempt to fix this in https://chromium-review.googlesource.com/c/chromium/src/+/810787 but this wasn't sufficient.

Sign in to add a comment