Include unstripped binaries in tests' runtime-deps, to allow symbolization on swarming. |
||
Issue descriptionIssue 773444 moved stripping of Fuchsia binaries from happening at run-time, during bootfs generation, to using the clang_toolchain |strip| script hook to do the work. This means that each swarming isolate is now passed only the stripped binaries, rather than the unstripped binaries, and so the runner script can no longer symbolize crashes.
,
Dec 12 2017
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d0153fb52415ac79ffbbd3da589a8378a7ba59c commit 3d0153fb52415ac79ffbbd3da589a8378a7ba59c Author: Kevin Marshall <kmarshall@chromium.org> Date: Wed Jan 31 22:25:53 2018 Fuchsia: Construct Fuchsia packages using stripped binaries. The packaging step now uses the binaries which were stripped via "eu-strip". The unstripped binaries are included in the build output as runtime dependencies, to support symbolization. Bug: 792521 , 788851 Change-Id: I73351d7e68c81487591e85c9b598effec9ff45a6 Reviewed-on: https://chromium-review.googlesource.com/891628 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#533445} [modify] https://crrev.com/3d0153fb52415ac79ffbbd3da589a8378a7ba59c/build/config/fuchsia/build_manifest.py [modify] https://crrev.com/3d0153fb52415ac79ffbbd3da589a8378a7ba59c/build/config/fuchsia/rules.gni [modify] https://crrev.com/3d0153fb52415ac79ffbbd3da589a8378a7ba59c/build/fuchsia/runner_common.py [modify] https://crrev.com/3d0153fb52415ac79ffbbd3da589a8378a7ba59c/build/fuchsia/runner_v2/symbolizer.py [modify] https://crrev.com/3d0153fb52415ac79ffbbd3da589a8378a7ba59c/build/toolchain/fuchsia/BUILD.gn [modify] https://crrev.com/3d0153fb52415ac79ffbbd3da589a8378a7ba59c/build/toolchain/gcc_toolchain.gni [modify] https://crrev.com/3d0153fb52415ac79ffbbd3da589a8378a7ba59c/testing/test.gni
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/105d8abde9a7c706df0953c08b69f39f542291c0 commit 105d8abde9a7c706df0953c08b69f39f542291c0 Author: Kevin Marshall <kmarshall@chromium.org> Date: Fri Feb 02 18:56:10 2018 Fix and tidy unstripped binary path resolution logic. The code as checked in breaks on Swarming because it attempts to read the stripped file, which is omitted on isolated builds. This CL does the ELF check on the unstripped file instead, and consolidates the logic within a function. Bug: 792521 Change-Id: I0042bb9b234f34ebc65c6b3ab10c075771b777ef Reviewed-on: https://chromium-review.googlesource.com/899677 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#534112} [modify] https://crrev.com/105d8abde9a7c706df0953c08b69f39f542291c0/build/fuchsia/runner_v2/symbolizer.py |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Dec 11 2017