New issue
Advanced search Search tips

Issue 792518 link

Starred by 14 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 777081
issue 798001



Sign in to add a comment

Improve tainting behavior for filter types

Project Member Reported by chrishtr@chromium.org, Dec 6 2017

Issue description

Many filter types taint subsequent filters, even though they don't need to.
Examples are FEFlood and SVGFEElement. FEFlood should only taint if the color
is currentColor, and SVGFEElement should only taint cross-origin images.

Some of the tests changed in https://chromium-review.googlesource.com/c/chromium/src/+/782649/ would start applying the filter
again if these issues were fixed.

 

Comment 1 by f...@opera.com, Jan 2 2018

Blocking: 798001
Examples of SVG demos that are broken because of the inappropriate tainting of same-domain or dataURI feImage references in this tweet:

https://twitter.com/w3unpocodetodo/status/992130115030175744

Comment 3 by f...@opera.com, Jun 29 2018

 Issue 856173  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72d42782270b4c5578791b8b8c5aeb0ec81b6cee

commit 72d42782270b4c5578791b8b8c5aeb0ec81b6cee
Author: Fredrik Söderquist <fs@opera.com>
Date: Sat Sep 22 08:30:50 2018

Use StyleColor for the flood-color and lighting-color properties

This changes the _interface_ to these properties in ComputedStyle
(and SVGComputedStyle) to use StyleColor - storage is changed to
a <Color, bool> (separated) pair. Usage is updated accordingly.
This is needed in order to support "better" tainting on 'feFlood'
and other filter primitive elements to which these properties apply.
The actual tainting functions will be updated in a follow-up CL.

Bug: 792518
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I705ee38219615c4c691e4a5fbc73799a72b604da
Reviewed-on: https://chromium-review.googlesource.com/797271
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593438}
[add] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/WebKit/LayoutTests/svg/filters/feflood-currentcolor-expected.html
[add] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/WebKit/LayoutTests/svg/filters/feflood-currentcolor.html
[add] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/WebKit/LayoutTests/svg/filters/felighting-currentcolor-expected.html
[add] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/WebKit/LayoutTests/svg/filters/felighting-currentcolor.html
[modify] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/blink/renderer/core/css/css_properties.json5
[modify] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/blink/renderer/core/layout/svg/layout_svg_resource_filter_primitive.cc
[modify] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/blink/renderer/core/style/computed_style.h
[modify] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/blink/renderer/core/style/svg_computed_style.cc
[modify] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/blink/renderer/core/style/svg_computed_style.h
[modify] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/blink/renderer/core/style/svg_computed_style_defs.cc
[modify] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/blink/renderer/core/style/svg_computed_style_defs.h
[modify] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/blink/renderer/core/svg/svg_fe_diffuse_lighting_element.cc
[modify] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/blink/renderer/core/svg/svg_fe_drop_shadow_element.cc
[modify] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/blink/renderer/core/svg/svg_fe_flood_element.cc
[modify] https://crrev.com/72d42782270b4c5578791b8b8c5aeb0ec81b6cee/third_party/blink/renderer/core/svg/svg_fe_specular_lighting_element.cc

Blocking: 777081

Sign in to add a comment