Historically the relative cwd has been passed via the isolated file, along the command. It is now possible (and encouraged) to pass the command directly through the API, but the relative cwd was left out by inadvertence.
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/aab8df9091adb8f69d9d14356283ae8b7fcf2089 commit aab8df9091adb8f69d9d14356283ae8b7fcf2089 Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Fri Dec 08 02:44:07 2017 swarming: refactor local_smoke_test before doing actual changes Test only change. - Use textwrap.dedent() to make the inline scripts more readable. - Remove default arguments. - Move the script in test_isolated_command in a subdirectory. This is in preparation to support --relative-cwd. Since this change is causing some amount of churn, I decided to split the non-functional churn in its own CL to simplify reviewing. This will make the actual change when --relative-cwd support is added more obvious. R=iannucci@chromium.org Bug: 792491 Change-Id: I2ece5cbb85da7481fb55046a4b59a00ad7231139 Reviewed-on: https://chromium-review.googlesource.com/815495 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/aab8df9091adb8f69d9d14356283ae8b7fcf2089/appengine/swarming/local_smoke_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/e6fa13578262f3f71abd9511ce88ae6af1696fad commit e6fa13578262f3f71abd9511ce88ae6af1696fad Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Fri Dec 08 15:06:07 2017 swarming: add --relative-cwd support server side Do not add client side yet, as we want to deploy the server everywhere before adding client side support. R=iannucci@chromium.org Bug: 792491 Change-Id: I788ca3b42cedabda35d784081fcb3cbc174ce129 Reviewed-on: https://chromium-review.googlesource.com/815594 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/e6fa13578262f3f71abd9511ce88ae6af1696fad/appengine/swarming/handlers_bot.py [modify] https://crrev.com/e6fa13578262f3f71abd9511ce88ae6af1696fad/appengine/swarming/handlers_bot_test.py [modify] https://crrev.com/e6fa13578262f3f71abd9511ce88ae6af1696fad/appengine/swarming/local_smoke_test.py [modify] https://crrev.com/e6fa13578262f3f71abd9511ce88ae6af1696fad/appengine/swarming/server/task_request.py [modify] https://crrev.com/e6fa13578262f3f71abd9511ce88ae6af1696fad/appengine/swarming/server/task_request_test.py [modify] https://crrev.com/e6fa13578262f3f71abd9511ce88ae6af1696fad/appengine/swarming/swarming_bot/bot_code/task_runner.py [modify] https://crrev.com/e6fa13578262f3f71abd9511ce88ae6af1696fad/appengine/swarming/swarming_rpcs.py [modify] https://crrev.com/e6fa13578262f3f71abd9511ce88ae6af1696fad/client/run_isolated.py [modify] https://crrev.com/e6fa13578262f3f71abd9511ce88ae6af1696fad/client/tests/run_isolated_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/5891df301d881d57269a942a8ecf448a1ca145a8 commit 5891df301d881d57269a942a8ecf448a1ca145a8 Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Fri Dec 22 02:46:12 2017 client: add --relative-cwd to swarming.py trigger This requires the server version 3263-e6fa135 to have been deployed everywhere. R=iannucci@chromium.org Bug: 792491 Change-Id: I95b37726d46761bc4dea7ab2bd39d0d64fcd8000 Reviewed-on: https://chromium-review.googlesource.com/815654 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/5891df301d881d57269a942a8ecf448a1ca145a8/appengine/swarming/local_smoke_test.py [modify] https://crrev.com/5891df301d881d57269a942a8ecf448a1ca145a8/client/swarming.py [modify] https://crrev.com/5891df301d881d57269a942a8ecf448a1ca145a8/client/tests/swarming_test.py
Had forgot to close.
Comment 1 by bugdroid1@chromium.org
, Dec 8 2017