WindowPortMus::CreateLayerTreeFrameSink doesn't return a correct frame sink |
||||||
Issue descriptionWith recent change (moving the viz from ui to a separate process). It breaks exo and fast_ink. It is because the WindowPortMus::CreateLayerTreeFrameSink doesn't return a correct frame sink.
,
Dec 6 2017
I don't think the code in WindowPortMus::CreateLayerTreeFrameSink has changed. Is it possible GetLocalSurfaceId() needs to be customized for windows hosting exo? I'm not sure who is a good owner for this. Peng or Sadrul?
,
Dec 6 2017
Reproduce steps with exo. 1. build desktop chromeos # Launch chrome 2. out/mus/chrome --mus --enable-wayland-server --ash-enable-wayland-server --user-data-dir=/tmp/penghuang-mustash --has-internal-stylus --force-enable-stylus-tools --pen-devices=4 --ash-debug-shortcuts --use-first-display-as-internal # Launch wayland rect client 3. ninja -j1000 -k50 -C out/mus wayland_rects_client && out/mus/wayland_rects_client --num-rects=10 --show-fps-counter --size=256x256
,
Dec 8 2017
,
Dec 8 2017
My understanding is Peng is actively working on this, so moving to started.
,
Dec 8 2017
Yeah. I am working on it.
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe678147420c0ea622dcdebd4d86e7b6162d5c40 commit fe678147420c0ea622dcdebd4d86e7b6162d5c40 Author: Peng Huang <penghuang@chromium.org> Date: Wed Dec 13 01:35:24 2017 Fix exo for IsMusHostingVis() == false Bug: 792479 , 793924 Test: Test on device with android apps Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I8c9beb8f835c294b6e2eb1dec4654a8d501c0952 Reviewed-on: https://chromium-review.googlesource.com/806689 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#523647} [modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ash/test/ash_test_helper.cc [modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ash/test/ash_test_suite.cc [modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ui/aura/local/layer_tree_frame_sink_local.h [modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ui/aura/mus/DEPS [modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ui/aura/mus/window_port_mus.h [modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ui/aura/mus/window_port_mus_unittest.cc [modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ui/compositor/test/in_process_context_factory.cc
,
Dec 13 2017
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e763ffcb4b98659e76d280a86c7c61072f090fcc commit e763ffcb4b98659e76d280a86c7c61072f090fcc Author: Christos Froussios <cfroussios@chromium.org> Date: Wed Dec 13 13:59:35 2017 Revert "Fix exo for IsMusHostingVis() == false" This reverts commit fe678147420c0ea622dcdebd4d86e7b6162d5c40. Reason for revert: Breaks several tests in ash_unittests-mus on Builder Linux Chromium OS ASan LSan Tests See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/25187 Original change's description: > Fix exo for IsMusHostingVis() == false > > Bug: 792479 , 793924 > Test: Test on device with android apps > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I8c9beb8f835c294b6e2eb1dec4654a8d501c0952 > Reviewed-on: https://chromium-review.googlesource.com/806689 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523647} TBR=penghuang@chromium.org,sadrul@chromium.org,sky@chromium.org,piman@chromium.org Change-Id: If258d1188a54f4406b6f0edf0c37ead6c89379b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 792479 , 793924 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/823925 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#523764} [modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ash/test/ash_test_helper.cc [modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ash/test/ash_test_suite.cc [modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ui/aura/local/layer_tree_frame_sink_local.h [modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ui/aura/mus/DEPS [modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ui/aura/mus/window_port_mus.h [modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ui/aura/mus/window_port_mus_unittest.cc [modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ui/compositor/test/in_process_context_factory.cc
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d4f463847c0dd17130b102b2694ddffa71e29f1 commit 7d4f463847c0dd17130b102b2694ddffa71e29f1 Author: Peng Huang <penghuang@chromium.org> Date: Wed Dec 13 18:30:23 2017 Fix a container overflow in HostFrameSinkManager. Bug: 792479 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I8144cc1ebaa73900237e4accd69d4e50891a1d80 Reviewed-on: https://chromium-review.googlesource.com/824434 Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#523829} [modify] https://crrev.com/7d4f463847c0dd17130b102b2694ddffa71e29f1/components/viz/host/host_frame_sink_manager.cc
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec6a3c6be2bd853352d4cf9aaa85307b1df88528 commit ec6a3c6be2bd853352d4cf9aaa85307b1df88528 Author: Peng Huang <penghuang@chromium.org> Date: Wed Dec 13 18:34:10 2017 Revert "Revert "Fix exo for IsMusHostingVis() == false"" This reverts commit e763ffcb4b98659e76d280a86c7c61072f090fcc. Reason for revert: The problem for reverting https://crrev.com/c/806689 has been fixed by https://crrev.com/c/824434. Original change's description: > Revert "Fix exo for IsMusHostingVis() == false" > > This reverts commit fe678147420c0ea622dcdebd4d86e7b6162d5c40. > > Reason for revert: Breaks several tests in ash_unittests-mus on Builder Linux Chromium OS ASan LSan Tests > See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/25187 > > Original change's description: > > Fix exo for IsMusHostingVis() == false > > > > Bug: 792479 , 793924 > > Test: Test on device with android apps > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Change-Id: I8c9beb8f835c294b6e2eb1dec4654a8d501c0952 > > Reviewed-on: https://chromium-review.googlesource.com/806689 > > Commit-Queue: Peng Huang <penghuang@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#523647} > > TBR=penghuang@chromium.org,sadrul@chromium.org,sky@chromium.org,piman@chromium.org > > Change-Id: If258d1188a54f4406b6f0edf0c37ead6c89379b4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 792479 , 793924 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/823925 > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523764} TBR=penghuang@chromium.org,sadrul@chromium.org,sky@chromium.org,piman@chromium.org,cfroussios@chromium.org Change-Id: I5ec6e8befda01fbbd320ee048aab998623e2b830 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 792479 , 793924 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/825282 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#523830} [modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ash/test/ash_test_helper.cc [modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ash/test/ash_test_suite.cc [modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ui/aura/local/layer_tree_frame_sink_local.h [modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ui/aura/mus/DEPS [modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ui/aura/mus/window_port_mus.h [modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ui/aura/mus/window_port_mus_unittest.cc [modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ui/compositor/test/in_process_context_factory.cc
,
Feb 26 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by penghuang@chromium.org
, Dec 6 2017Reproduce steps with fast_ink: 1. build desktop chromeos 2. use xinput to find your mouse device id (for example id is 4), and use the id in below command line for --pen-devices=id 3. out/mus/chrome --mus --enable-wayland-server --ash-enable-wayland-server --user-data-dir=/tmp/penghuang-mustash --has-internal-stylus --force-enable-stylus-tools --pen-devices=4 --ash-debug-shortcuts --use-first-display-as-internal 4. Click the pen icon on systray and select Laser pointer in the menu 5. You should be able to use your mouse as a pen to draw on screen, but it doesn't work now. (sdk kevin R64-10171.0.0) penghuang@penghuang-linux ~/sources/chromium/src $ xinput ⎡ Virtual core pointer id=2 [master pointer (3)] ⎜ ↳ Virtual core XTEST pointer id=4 [slave pointer (2)] ⎜ ↳ Xvfb mouse id=6 [slave pointer (2)] ⎣ Virtual core keyboard id=3 [master keyboard (2)] ↳ Virtual core XTEST keyboard id=5 [slave keyboard (3)] ↳ Xvfb keyboard id=7 [slave keyboard (3)]