[Autofill] Replace all hardcoded year and months in the tests |
||||||
Issue descriptionReplace all hardcoded year and months in the tests by appropriate functions (example [1]) or by using the TestAutofillClock. [1] https://cs.chromium.org/chromium/src/components/autofill/core/browser/credit_card_save_manager_unittest.cc?q=credit_card_save_manager_unitt&sq=package:chromium&dr&l=71-75
,
May 1 2018
,
May 1 2018
,
Jul 10
I will try to make a patch
,
Jul 11
I have uploaded a patch. PTAL. https://chromium-review.googlesource.com/c/chromium/src/+/1133038
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a310e5a3100305763afd1849b9cd5553ebbf05e4 commit a310e5a3100305763afd1849b9cd5553ebbf05e4 Author: “asish.singh” <asish.singh@samsung.com> Date: Wed Jul 11 12:15:17 2018 [Autofill] Replace all hardcoded months in the test Replace all hardcoded months in the tests by NextMonth() function. BUG= 792475 Change-Id: I6ccfdbd7c8dce43b8156e540bb17b6379f43dba5 Reviewed-on: https://chromium-review.googlesource.com/1133038 Reviewed-by: Prashant Nevase <prashant.n@samsung.com> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#574129} [modify] https://crrev.com/a310e5a3100305763afd1849b9cd5553ebbf05e4/AUTHORS [modify] https://crrev.com/a310e5a3100305763afd1849b9cd5553ebbf05e4/components/autofill/core/browser/credit_card_save_manager_unittest.cc
,
Sep 6
Seb, can we mark as fixed?
,
Dec 17
,
Dec 19
Seems like this is fixed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by se...@chromium.org
, Dec 22 2017Status: Started (was: Available)