New issue
Advanced search Search tips

Issue 792464 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Global-buffer-overflow in blink::CSSParserToken::GetType

Project Member Reported by ClusterFuzz, Dec 6 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5244215851483136

Fuzzer: libFuzzer_stylesheet_contents_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Global-buffer-overflow READ 4
Crash Address: 0x7fd81073c148
Crash State:
  blink::CSSParserToken::GetType
  blink::CSSPropertyParserHelpers::ParseRGBParameters
  blink::CSSPropertyParserHelpers::ParseColorFunction
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=521690:521709

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5244215851483136

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 6 2017

Components: Blink>CSS
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Owner: ericwilligers@chromium.org
Seems likely to be a dupe of  Issue 792306 . Eric?
Labels: Pri-1
Actually, while the regression comes from the same CL, it appears to be in a different function. The patch for 792306 might avoid the crash for this specific fuzzed-input, but adding another digit at the end seems likely to trigger the same crash.

   o{color:rgb(0
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 7 2017

Labels: M-64
Project Member

Comment 5 by sheriffbot@chromium.org, Dec 7 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 7 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 7 by sheriffbot@chromium.org, Dec 8 2017

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcb44ac06933a5f1300db5c0677ffe2a07a569ac

commit fcb44ac06933a5f1300db5c0677ffe2a07a569ac
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Tue Dec 12 08:41:21 2017

CSS Parser: Detect incomplete rgba colors

args.Peek() - 1  is only valid if we are not at the end (or beginning)
of the token stream.

BUG= 792464 

Change-Id: I1a475ce873723877d6bbb9d7b24c3773dd1090ee
Reviewed-on: https://chromium-review.googlesource.com/821793
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523375}
[modify] https://crrev.com/fcb44ac06933a5f1300db5c0677ffe2a07a569ac/third_party/WebKit/Source/core/css/StyleEngineTest.cpp
[modify] https://crrev.com/fcb44ac06933a5f1300db5c0677ffe2a07a569ac/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
[modify] https://crrev.com/fcb44ac06933a5f1300db5c0677ffe2a07a569ac/third_party/WebKit/Source/core/css/parser/CSSPropertyParserTest.cpp

Status: Fixed (was: Started)
Project Member

Comment 11 by ClusterFuzz, Dec 13 2017

ClusterFuzz has detected this issue as fixed in range 523370:523382.

Detailed report: https://clusterfuzz.com/testcase?key=5244215851483136

Fuzzer: libFuzzer_stylesheet_contents_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Global-buffer-overflow READ 4
Crash Address: 0x7fd81073c148
Crash State:
  blink::CSSParserToken::GetType
  blink::CSSPropertyParserHelpers::ParseRGBParameters
  blink::CSSPropertyParserHelpers::ParseColorFunction
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=521690:521709
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=523370:523382

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5244215851483136

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by sheriffbot@chromium.org, Dec 13 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 13 by ClusterFuzz, Dec 13 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5244215851483136 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Dec 15 2017

Labels: Merge-Request-64
Project Member

Comment 15 by sheriffbot@chromium.org, Dec 15 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -M-64 -Merge-Review-64 M-65
Regression and fix range are both in 65.
Cc: hichris...@gmail.com
Labels: -ReleaseBlock-Stable
Project Member

Comment 19 by sheriffbot@chromium.org, Mar 21 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Beta Security_Impact-Stable

Sign in to add a comment