New issue
Advanced search Search tips

Issue 792432 link

Starred by 1 user
Status: Fixed
Owner:
peria@chromium.org
Closed: Nov 14
Cc:
yukishiino@chromium.org
peria@chromium.org
haraken@chromium.org
bashi@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

IDL: remove [PrimaryGlobal]

Project Member Reported by annevank...@gmail.com, Dec 6 2017 
See https://github.com/w3c/web-platform-tests/pull/8585 for test changes.

Background and other specification changes linked from https://github.com/heycam/webidl/issues/365.

(It would help if the Blink>Bindings component was annotated with "IDL".)

Comment 1 by krajshree@chromium.org, Dec 7 2017

Labels: Needs-Milestone Triaged-ET TE-NeedsTriageHelp
The issue seems to be out of TE-scope as it is related to object and functions as per url: https://github.com/heycam/webidl/issues/365. Hence, adding label TE-NeedsTriageHelp for further investigation from dev team.

Thanks...!!

Comment 2 by jbroman@chromium.org, Dec 7 2017

Cc: haraken@chromium.org peria@chromium.org bashi@chromium.org
Status: Available (was: Unconfirmed)
Marking as Available since this is likely to be low priority. ccing IDL compiler folk who might have opinions.

We might even want to mark this as GoodFirstBug since, IIUC, it simply involves adding [Exposed] to a bunch of stuff (possibly as specs are updated?), then removing [PrimaryGlobal] and adding a check that all interfaces have [Exposed].

Comment 3 by jbroman@chromium.org, Dec 7 2017

Labels: -OS-Mac

Comment 4 by bashi@chromium.org, Dec 8 2017 

+1

Comment 5 by pramod...@samsung.com, Dec 28 2017 

Hi,
I am interested to work on this.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcf875241e1d29f6b140250b7bb948eb2fdd8ce9

commit dcf875241e1d29f6b140250b7bb948eb2fdd8ce9
Author: Pramod B S <pramod.bs@samsung.com>
Date: Wed Jan 03 05:02:20 2018

IDL: Add [Exposed=Window] to MutationObserver and DOMTokenList

Required [Exposed] to get rid of [PrimaryGlobal]

Spec: https://github.com/heycam/webidl/issues/365

Bug:  792432 
Change-Id: I4ed66ed7116eaf4ded7d07d991c81c01e827ca1c
Reviewed-on: https://chromium-review.googlesource.com/847393
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#526622}
[modify] https://crrev.com/dcf875241e1d29f6b140250b7bb948eb2fdd8ce9/third_party/WebKit/Source/core/dom/DOMTokenList.idl
[modify] https://crrev.com/dcf875241e1d29f6b140250b7bb948eb2fdd8ce9/third_party/WebKit/Source/core/dom/MutationObserver.idl
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f1459436be930c7332ec418d6116ca368573730

commit 5f1459436be930c7332ec418d6116ca368573730
Author: Pramod B S <pramod.bs@samsung.com>
Date: Thu Jan 04 16:10:18 2018

IDL: Required [Exposed] to get rid of [PrimaryGlobal]

Required [Exposed] to get rid of [PrimaryGlobal]

Spec: https://github.com/heycam/webidl/issues/365

Bug:  792432 
Change-Id: I48abf9f25dc5968da5680d8e95598270199ba812
Reviewed-on: https://chromium-review.googlesource.com/848465
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#526994}
[modify] https://crrev.com/5f1459436be930c7332ec418d6116ca368573730/third_party/WebKit/Source/core/events/ClipboardEvent.idl
[modify] https://crrev.com/5f1459436be930c7332ec418d6116ca368573730/third_party/WebKit/Source/modules/battery/BatteryManager.idl
[modify] https://crrev.com/5f1459436be930c7332ec418d6116ca368573730/third_party/WebKit/Source/modules/clipboard/Clipboard.idl
[modify] https://crrev.com/5f1459436be930c7332ec418d6116ca368573730/third_party/WebKit/Source/modules/sensor/AbsoluteOrientationSensor.idl
[modify] https://crrev.com/5f1459436be930c7332ec418d6116ca368573730/third_party/WebKit/Source/modules/sensor/Accelerometer.idl
[modify] https://crrev.com/5f1459436be930c7332ec418d6116ca368573730/third_party/WebKit/Source/modules/sensor/AmbientLightSensor.idl
[modify] https://crrev.com/5f1459436be930c7332ec418d6116ca368573730/third_party/WebKit/Source/modules/sensor/LinearAccelerationSensor.idl
[modify] https://crrev.com/5f1459436be930c7332ec418d6116ca368573730/third_party/WebKit/Source/modules/sensor/OrientationSensor.idl
[modify] https://crrev.com/5f1459436be930c7332ec418d6116ca368573730/third_party/WebKit/Source/modules/sensor/RelativeOrientationSensor.idl
[modify] https://crrev.com/5f1459436be930c7332ec418d6116ca368573730/third_party/WebKit/Source/modules/sensor/Sensor.idl
[modify] https://crrev.com/5f1459436be930c7332ec418d6116ca368573730/third_party/WebKit/Source/modules/sensor/SensorErrorEvent.idl
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75dbf72ba7113fd6130c8ad71fb499ae86e2e881

commit 75dbf72ba7113fd6130c8ad71fb499ae86e2e881
Author: Pramod B S <pramod.bs@samsung.com>
Date: Tue Jan 09 09:48:38 2018

IDL: Required [Exposed] to get rid of [PrimaryGlobal]

Modified files in CSSOM and CSSOM View module.

Spec: https://github.com/heycam/webidl/issues/365

Bug:  792432 
Change-Id: I4d38d30ceef4419dc8b52adf8ea3484e42d69e0d
Reviewed-on: https://chromium-review.googlesource.com/856282
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#527947}
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/css/CSSGroupingRule.idl
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/css/CSSImportRule.idl
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/css/CSSNamespaceRule.idl
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/css/CSSPageRule.idl
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/css/CSSRule.idl
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/css/CSSRuleList.idl
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/css/CSSStyleRule.idl
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/css/CSSStyleSheet.idl
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/css/MediaList.idl
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/css/MediaQueryList.idl
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/css/MediaQueryListEvent.idl
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/css/StyleSheet.idl
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/css/StyleSheetList.idl
[modify] https://crrev.com/75dbf72ba7113fd6130c8ad71fb499ae86e2e881/third_party/WebKit/Source/core/frame/Screen.idl
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/595df152f478cf1ae15731b6f6b6acc38a1d2627

commit 595df152f478cf1ae15731b6f6b6acc38a1d2627
Author: Pramod B S <pramod.bs@samsung.com>
Date: Thu Jan 11 05:17:40 2018

IDL: Required [Exposed] to get rid of [PrimaryGlobal]

Modified files in DeviceOrietation event,
DOM parsing, serialization and HTML Standard.

Spec: https://github.com/heycam/webidl/issues/365

Bug:  792432 
Change-Id: If80340f9a1daa04a4f89fc6adcb08a5dce4dd45f
Reviewed-on: https://chromium-review.googlesource.com/858937
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#528565}
[modify] https://crrev.com/595df152f478cf1ae15731b6f6b6acc38a1d2627/third_party/WebKit/Source/core/html/HTMLUnknownElement.idl
[modify] https://crrev.com/595df152f478cf1ae15731b6f6b6acc38a1d2627/third_party/WebKit/Source/core/html/forms/RadioNodeList.idl
[modify] https://crrev.com/595df152f478cf1ae15731b6f6b6acc38a1d2627/third_party/WebKit/Source/core/html/track/AudioTrack.idl
[modify] https://crrev.com/595df152f478cf1ae15731b6f6b6acc38a1d2627/third_party/WebKit/Source/core/html/track/AudioTrackList.idl
[modify] https://crrev.com/595df152f478cf1ae15731b6f6b6acc38a1d2627/third_party/WebKit/Source/core/html/track/VideoTrack.idl
[modify] https://crrev.com/595df152f478cf1ae15731b6f6b6acc38a1d2627/third_party/WebKit/Source/core/html/track/VideoTrackList.idl
[modify] https://crrev.com/595df152f478cf1ae15731b6f6b6acc38a1d2627/third_party/WebKit/Source/core/xml/DOMParser.idl
[modify] https://crrev.com/595df152f478cf1ae15731b6f6b6acc38a1d2627/third_party/WebKit/Source/core/xml/XMLSerializer.idl
[modify] https://crrev.com/595df152f478cf1ae15731b6f6b6acc38a1d2627/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2D.idl
[modify] https://crrev.com/595df152f478cf1ae15731b6f6b6acc38a1d2627/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.idl
[modify] https://crrev.com/595df152f478cf1ae15731b6f6b6acc38a1d2627/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl
[modify] https://crrev.com/595df152f478cf1ae15731b6f6b6acc38a1d2627/third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.idl
[modify] https://crrev.com/595df152f478cf1ae15731b6f6b6acc38a1d2627/third_party/WebKit/Source/modules/sensor/Gyroscope.idl
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/994f9306326194446b67d89b6b6006a63087073f

commit 994f9306326194446b67d89b6b6006a63087073f
Author: Pramod B S <pramod.bs@samsung.com>
Date: Wed Jan 17 04:07:27 2018

IDL: Required [Exposed] to get rid of [PrimaryGlobal]

Modified files in imagecapture, mediarecorder and
presentation modules.

Spec: https://github.com/heycam/webidl/issues/365

Bug:  792432 
Change-Id: Ica4e157ab6b962bf185823ef6e6163c34bfb03cb
Reviewed-on: https://chromium-review.googlesource.com/868091
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529594}
[modify] https://crrev.com/994f9306326194446b67d89b6b6006a63087073f/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.idl
[modify] https://crrev.com/994f9306326194446b67d89b6b6006a63087073f/third_party/WebKit/Source/modules/imagecapture/ImageCapture.idl
[modify] https://crrev.com/994f9306326194446b67d89b6b6006a63087073f/third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.idl
[modify] https://crrev.com/994f9306326194446b67d89b6b6006a63087073f/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl
[modify] https://crrev.com/994f9306326194446b67d89b6b6006a63087073f/third_party/WebKit/Source/modules/mediarecorder/BlobEvent.idl
[modify] https://crrev.com/994f9306326194446b67d89b6b6006a63087073f/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl
[modify] https://crrev.com/994f9306326194446b67d89b6b6006a63087073f/third_party/WebKit/Source/modules/presentation/Presentation.idl
[modify] https://crrev.com/994f9306326194446b67d89b6b6006a63087073f/third_party/WebKit/Source/modules/presentation/PresentationAvailability.idl
[modify] https://crrev.com/994f9306326194446b67d89b6b6006a63087073f/third_party/WebKit/Source/modules/presentation/PresentationConnection.idl
[modify] https://crrev.com/994f9306326194446b67d89b6b6006a63087073f/third_party/WebKit/Source/modules/presentation/PresentationConnectionAvailableEvent.idl
[modify] https://crrev.com/994f9306326194446b67d89b6b6006a63087073f/third_party/WebKit/Source/modules/presentation/PresentationConnectionCloseEvent.idl
[modify] https://crrev.com/994f9306326194446b67d89b6b6006a63087073f/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.idl
[modify] https://crrev.com/994f9306326194446b67d89b6b6006a63087073f/third_party/WebKit/Source/modules/presentation/PresentationReceiver.idl
[modify] https://crrev.com/994f9306326194446b67d89b6b6006a63087073f/third_party/WebKit/Source/modules/presentation/PresentationRequest.idl
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e712b35b1db176bf4757164cf6a5754e1b1e2518

commit e712b35b1db176bf4757164cf6a5754e1b1e2518
Author: Pramod B S <pramod.bs@samsung.com>
Date: Tue Jan 23 08:48:39 2018

IDL: Required [Exposed] to get rid of [PrimaryGlobal]

Modified files in core/events module.

Spec: https://github.com/heycam/webidl/issues/365

Bug:  792432 
Change-Id: Ie5422d805a6be8fd61292ed2d0ed752020b36724
Reviewed-on: https://chromium-review.googlesource.com/880425
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#531187}
[modify] https://crrev.com/e712b35b1db176bf4757164cf6a5754e1b1e2518/third_party/WebKit/Source/core/events/BeforeUnloadEvent.idl
[modify] https://crrev.com/e712b35b1db176bf4757164cf6a5754e1b1e2518/third_party/WebKit/Source/core/events/CompositionEvent.idl
[modify] https://crrev.com/e712b35b1db176bf4757164cf6a5754e1b1e2518/third_party/WebKit/Source/core/events/DragEvent.idl
[modify] https://crrev.com/e712b35b1db176bf4757164cf6a5754e1b1e2518/third_party/WebKit/Source/core/events/FocusEvent.idl
[modify] https://crrev.com/e712b35b1db176bf4757164cf6a5754e1b1e2518/third_party/WebKit/Source/core/events/HashChangeEvent.idl
[modify] https://crrev.com/e712b35b1db176bf4757164cf6a5754e1b1e2518/third_party/WebKit/Source/core/events/InputEvent.idl
[modify] https://crrev.com/e712b35b1db176bf4757164cf6a5754e1b1e2518/third_party/WebKit/Source/core/events/KeyboardEvent.idl
[modify] https://crrev.com/e712b35b1db176bf4757164cf6a5754e1b1e2518/third_party/WebKit/Source/core/events/MouseEvent.idl
[modify] https://crrev.com/e712b35b1db176bf4757164cf6a5754e1b1e2518/third_party/WebKit/Source/core/events/PageTransitionEvent.idl
[modify] https://crrev.com/e712b35b1db176bf4757164cf6a5754e1b1e2518/third_party/WebKit/Source/core/events/PopStateEvent.idl
[modify] https://crrev.com/e712b35b1db176bf4757164cf6a5754e1b1e2518/third_party/WebKit/Source/core/events/TouchEvent.idl
[modify] https://crrev.com/e712b35b1db176bf4757164cf6a5754e1b1e2518/third_party/WebKit/Source/core/events/UIEvent.idl
[modify] https://crrev.com/e712b35b1db176bf4757164cf6a5754e1b1e2518/third_party/WebKit/Source/core/events/WheelEvent.idl
[modify] https://crrev.com/e712b35b1db176bf4757164cf6a5754e1b1e2518/third_party/WebKit/Source/core/input/Touch.idl
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d54b782863e4fbd15819f0378a3d2d4dcd07ce03

commit d54b782863e4fbd15819f0378a3d2d4dcd07ce03
Author: Pramod B S <pramod.bs@samsung.com>
Date: Fri Feb 02 12:16:33 2018

IDL: Required [Exposed] to get rid of [PrimaryGlobal]

Modified files in peerconnection module.

Spec: https://github.com/heycam/webidl/issues/365

Bug:  792432 
Change-Id: Ic3c8c895d6d71737b07aca504662ab756b06a9d9
Reviewed-on: https://chromium-review.googlesource.com/896916
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#534028}
[modify] https://crrev.com/d54b782863e4fbd15819f0378a3d2d4dcd07ce03/third_party/WebKit/Source/modules/peerconnection/RTCCertificate.idl
[modify] https://crrev.com/d54b782863e4fbd15819f0378a3d2d4dcd07ce03/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.idl
[modify] https://crrev.com/d54b782863e4fbd15819f0378a3d2d4dcd07ce03/third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.idl
[modify] https://crrev.com/d54b782863e4fbd15819f0378a3d2d4dcd07ce03/third_party/WebKit/Source/modules/peerconnection/RTCIceCandidate.idl
[modify] https://crrev.com/d54b782863e4fbd15819f0378a3d2d4dcd07ce03/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
[modify] https://crrev.com/d54b782863e4fbd15819f0378a3d2d4dcd07ce03/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.idl
[modify] https://crrev.com/d54b782863e4fbd15819f0378a3d2d4dcd07ce03/third_party/WebKit/Source/modules/peerconnection/RTCRtpReceiver.idl
[modify] https://crrev.com/d54b782863e4fbd15819f0378a3d2d4dcd07ce03/third_party/WebKit/Source/modules/peerconnection/RTCRtpSender.idl
[modify] https://crrev.com/d54b782863e4fbd15819f0378a3d2d4dcd07ce03/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescription.idl
[modify] https://crrev.com/d54b782863e4fbd15819f0378a3d2d4dcd07ce03/third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.idl
[modify] https://crrev.com/d54b782863e4fbd15819f0378a3d2d4dcd07ce03/third_party/WebKit/Source/modules/peerconnection/RTCTrackEvent.idl

Comment 13 by peria@chromium.org, Feb 2 2018

Cc: yukishiino@chromium.org

Comment 14 by peria@chromium.org, Nov 12

Owner: peria@chromium.org
Status: Started (was: Available)
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43e45d3b87ee87ce9d10518d5f3a5ec0884d07b5

commit 43e45d3b87ee87ce9d10518d5f3a5ec0884d07b5
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Mon Nov 12 05:57:22 2018

Web IDL: Fix use cases of [Global] and [PrimaryGlobal]

Web IDL spec says [Global] must take an argument, and
its support for [PrimaryGlobal] was removed.
This CL updates IDL files to follow its spec, but keeps
code for [PrimaryGlobal] as-is.


Bug:  792432 
Change-Id: I56bc07487a5a366aed49385140b9b57a8eeb646c
Reviewed-on: https://chromium-review.googlesource.com/c/1331093
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607153}
[modify] https://crrev.com/43e45d3b87ee87ce9d10518d5f3a5ec0884d07b5/third_party/blink/renderer/bindings/IDLExtendedAttributes.txt
[modify] https://crrev.com/43e45d3b87ee87ce9d10518d5f3a5ec0884d07b5/third_party/blink/renderer/bindings/tests/idls/core/test_integer_indexed_global.idl
[delete] https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/blink/renderer/bindings/tests/idls/core/test_integer_indexed_primary_global.idl
[modify] https://crrev.com/43e45d3b87ee87ce9d10518d5f3a5ec0884d07b5/third_party/blink/renderer/bindings/tests/idls/core/test_interface_check_security.idl
[delete] https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_primary_global.cc
[delete] https://crrev.com/e7316d0c2c1a3ea146197778d926502c9646e4bf/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_primary_global.h
[modify] https://crrev.com/43e45d3b87ee87ce9d10518d5f3a5ec0884d07b5/third_party/blink/renderer/core/frame/window.idl
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f904e6a0b07b06c5f19ce9a0c3e36c84d6014570

commit f904e6a0b07b06c5f19ce9a0c3e36c84d6014570
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Mon Nov 12 07:49:30 2018

Web IDL: Drop support of [PrimaryGlobal]

This CL drops support of an IDL extended attribute [PrimaryGlobal],
and cleans up some comments about it.


Bug:  792432 
Change-Id: I6f476966e08a5dbd58aca5e72ad41bb9e8bb89bb
Reviewed-on: https://chromium-review.googlesource.com/c/1329709
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607163}
[modify] https://crrev.com/f904e6a0b07b06c5f19ce9a0c3e36c84d6014570/third_party/blink/renderer/bindings/IDLExtendedAttributes.md
[modify] https://crrev.com/f904e6a0b07b06c5f19ce9a0c3e36c84d6014570/third_party/blink/renderer/bindings/IDLExtendedAttributes.txt
[modify] https://crrev.com/f904e6a0b07b06c5f19ce9a0c3e36c84d6014570/third_party/blink/renderer/bindings/scripts/compute_global_objects.py
[modify] https://crrev.com/f904e6a0b07b06c5f19ce9a0c3e36c84d6014570/third_party/blink/renderer/bindings/scripts/generate_global_constructors.py
[modify] https://crrev.com/f904e6a0b07b06c5f19ce9a0c3e36c84d6014570/third_party/blink/renderer/bindings/scripts/generate_origin_trial_features.py
[modify] https://crrev.com/f904e6a0b07b06c5f19ce9a0c3e36c84d6014570/third_party/blink/renderer/bindings/scripts/generate_v8_context_snapshot_external_references.py
[modify] https://crrev.com/f904e6a0b07b06c5f19ce9a0c3e36c84d6014570/third_party/blink/renderer/bindings/scripts/v8_interface.py
[modify] https://crrev.com/f904e6a0b07b06c5f19ce9a0c3e36c84d6014570/third_party/blink/renderer/bindings/scripts/v8_utilities.py
[modify] https://crrev.com/f904e6a0b07b06c5f19ce9a0c3e36c84d6014570/third_party/blink/renderer/bindings/templates/interface_base.cc.tmpl

Comment 17 by peria@chromium.org, Nov 14

Status: Fixed (was: Started)
►

Sign in to add a comment